Re: [LTP] [PATCH] Add goals of patch review and tips

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > I'd make a clarification for that mknod01 patch review,
> > the reason why Cyril merge V1 manually is that V2
> > involves new change (I neglected) in mknod02, which
> > should be separated in another patch.

> > Cyril did the right thing there. But he didn't explain that.

> I did the right thing by accident though. I only realized there is v2
> later on...

I really didn't want to blame anybody. I just wanted to demonstrate occasional
problems due wrong patch setup in patchwork. Therefore I proposed to all active
developers including these who aren't LTP maintainers (we have quite a few from
SUSE) to maintain their *latest* version of the patchset in patchwork (just to
set the older version either "Superseded" or "Changes requested". That would
reduce these confusions.

I'm ok not to make it as a written rule (it might lead to confusion to encourage
all contributors to make a patchwork account, OTOH it's useful even for rare
kernel contributions, thus I have patchwork accounts in both
https://patchwork.ozlabs.org/ and https://patchwork.kernel.org/).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp