From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Date: Thu, 23 Mar 2023 10:02:38 -0500 Message-ID: <20230323150238.GA2550157@bhelgaas> References: Mime-Version: 1.0 Return-path: List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679583760; bh=A4cz5sAtdGojClghNnzslTTn+0telsrqWPrc7ZEY92A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QZ2KDQiDLNeolamz/rBZXmXKaml10w90GcGwB6l5yO87qYFqQPDIQgKZ80zht8Qsc Xeoi/zLrt2EtH3nbngx/R5sYZx0Xwf4JkO9knqHSrKtOYd2+7MSeapV8B/zw9rxmZf 9UhNHPKZpA1ucTpj/VgulfE/ACFQnVZP8YBw36pan4Gf8wwyvTOnEEDjDM2KPQPTQp ZGCnVZCISmiqwx5zKNrKd8Mk7Zh6u/0oYwI8LPRfc1PEUXu67DDtdxfqNx9ryyF1pw 4cNq1h1H67JIwrFngX1Sl9ypuAP/OCB5kx8wJtxg7nOzQYMGU2gbmFC/O67YEr6JCJ aHqE0tG0UVQoQ== Content-Disposition: inline In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard On Thu, Mar 23, 2023 at 04:30:01PM +0200, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 02:28:04PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 20, 2023 at 03:16:30PM +0200, Andy Shevchenko wrote: > ... > > > > + pci_dev_for_each_resource_p(dev, r) { > > > /* zap the 2nd function of the winbond chip */ > > > - if (dev->resource[i].flags & IORESOURCE_IO > > > - && dev->bus->number == 0 && dev->devfn == 0x81) > > > - dev->resource[i].flags &= ~IORESOURCE_IO; > > > - if (dev->resource[i].start == 0 && dev->resource[i].end) { > > > - dev->resource[i].flags = 0; > > > - dev->resource[i].end = 0; > > > + if (dev->bus->number == 0 && dev->devfn == 0x81 && > > > + r->flags & IORESOURCE_IO) > > > > This is a nice literal conversion, but it's kind of lame to test > > bus->number and devfn *inside* the loop here, since they can't change > > inside the loop. > > Hmm... why are you asking me, even if I may agree on that? It's > in the original code and out of scope of this series. Yeah, I don't think it would be *unreasonable* to clean this up at the same time so the maintainers can look at both at the same time (this is arch/powerpc/platforms/pseries/pci.c, so Michael, et al), but no need for you to do anything, certainly. I can post a follow-up patch. > > but > > since we're converging on the "(dev, res)" style, I think we should > > reverse the names so we have something like: > > > > pci_dev_for_each_resource(dev, res) > > pci_dev_for_each_resource_idx(dev, res, i) > > Wouldn't it be more churn, including pci_bus_for_each_resource() correction? Yes, it definitely is a little more churn because we already have pci_bus_for_each_resource() that would have to be changed. I poked around looking for similar patterns elsewhere with: git grep "#define.*for_each_.*_p(" git grep "#define.*for_each_.*_idx(" I didn't find any other "_p" iterators and just a few "_idx" ones, so my hope is to follow what little precedent there is, as well as converge on the basic "*_for_each_resource()" iterators and remove the "_idx()" versions over time by doing things like the pci_claim_resource() change. What do you think? If it seems like excessive churn, we can do it as-is and still try to reduce the use of the index variable over time. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36D5C7619A for ; Thu, 23 Mar 2023 15:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjCWPEK (ORCPT ); Thu, 23 Mar 2023 11:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbjCWPEJ (ORCPT ); Thu, 23 Mar 2023 11:04:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E3528E74; Thu, 23 Mar 2023 08:02:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2957B8215E; Thu, 23 Mar 2023 15:02:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7276DC4339E; Thu, 23 Mar 2023 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679583760; bh=A4cz5sAtdGojClghNnzslTTn+0telsrqWPrc7ZEY92A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QZ2KDQiDLNeolamz/rBZXmXKaml10w90GcGwB6l5yO87qYFqQPDIQgKZ80zht8Qsc Xeoi/zLrt2EtH3nbngx/R5sYZx0Xwf4JkO9knqHSrKtOYd2+7MSeapV8B/zw9rxmZf 9UhNHPKZpA1ucTpj/VgulfE/ACFQnVZP8YBw36pan4Gf8wwyvTOnEEDjDM2KPQPTQp ZGCnVZCISmiqwx5zKNrKd8Mk7Zh6u/0oYwI8LPRfc1PEUXu67DDtdxfqNx9ryyF1pw 4cNq1h1H67JIwrFngX1Sl9ypuAP/OCB5kx8wJtxg7nOzQYMGU2gbmFC/O67YEr6JCJ aHqE0tG0UVQoQ== Date: Thu, 23 Mar 2023 10:02:38 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Message-ID: <20230323150238.GA2550157@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Mar 23, 2023 at 04:30:01PM +0200, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 02:28:04PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 20, 2023 at 03:16:30PM +0200, Andy Shevchenko wrote: > ... > > > > + pci_dev_for_each_resource_p(dev, r) { > > > /* zap the 2nd function of the winbond chip */ > > > - if (dev->resource[i].flags & IORESOURCE_IO > > > - && dev->bus->number == 0 && dev->devfn == 0x81) > > > - dev->resource[i].flags &= ~IORESOURCE_IO; > > > - if (dev->resource[i].start == 0 && dev->resource[i].end) { > > > - dev->resource[i].flags = 0; > > > - dev->resource[i].end = 0; > > > + if (dev->bus->number == 0 && dev->devfn == 0x81 && > > > + r->flags & IORESOURCE_IO) > > > > This is a nice literal conversion, but it's kind of lame to test > > bus->number and devfn *inside* the loop here, since they can't change > > inside the loop. > > Hmm... why are you asking me, even if I may agree on that? It's > in the original code and out of scope of this series. Yeah, I don't think it would be *unreasonable* to clean this up at the same time so the maintainers can look at both at the same time (this is arch/powerpc/platforms/pseries/pci.c, so Michael, et al), but no need for you to do anything, certainly. I can post a follow-up patch. > > but > > since we're converging on the "(dev, res)" style, I think we should > > reverse the names so we have something like: > > > > pci_dev_for_each_resource(dev, res) > > pci_dev_for_each_resource_idx(dev, res, i) > > Wouldn't it be more churn, including pci_bus_for_each_resource() correction? Yes, it definitely is a little more churn because we already have pci_bus_for_each_resource() that would have to be changed. I poked around looking for similar patterns elsewhere with: git grep "#define.*for_each_.*_p(" git grep "#define.*for_each_.*_idx(" I didn't find any other "_p" iterators and just a few "_idx" ones, so my hope is to follow what little precedent there is, as well as converge on the basic "*_for_each_resource()" iterators and remove the "_idx()" versions over time by doing things like the pci_claim_resource() change. What do you think? If it seems like excessive churn, we can do it as-is and still try to reduce the use of the index variable over time. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1789C76196 for ; Thu, 23 Mar 2023 15:03:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Pj7rt16D6z3fGT for ; Fri, 24 Mar 2023 02:03:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QZ2KDQiD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QZ2KDQiD; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Pj7qp2LfZz3cj9 for ; Fri, 24 Mar 2023 02:02:46 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27E14B8208A; Thu, 23 Mar 2023 15:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7276DC4339E; Thu, 23 Mar 2023 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679583760; bh=A4cz5sAtdGojClghNnzslTTn+0telsrqWPrc7ZEY92A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QZ2KDQiDLNeolamz/rBZXmXKaml10w90GcGwB6l5yO87qYFqQPDIQgKZ80zht8Qsc Xeoi/zLrt2EtH3nbngx/R5sYZx0Xwf4JkO9knqHSrKtOYd2+7MSeapV8B/zw9rxmZf 9UhNHPKZpA1ucTpj/VgulfE/ACFQnVZP8YBw36pan4Gf8wwyvTOnEEDjDM2KPQPTQp ZGCnVZCISmiqwx5zKNrKd8Mk7Zh6u/0oYwI8LPRfc1PEUXu67DDtdxfqNx9ryyF1pw 4cNq1h1H67JIwrFngX1Sl9ypuAP/OCB5kx8wJtxg7nOzQYMGU2gbmFC/O67YEr6JCJ aHqE0tG0UVQoQ== Date: Thu, 23 Mar 2023 10:02:38 -0500 From: Bjorn Helgaas To: Andy Shevchenko Subject: Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Message-ID: <20230323150238.GA2550157@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rich Felker , linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, Bjorn Helgaas , Andrew Lunn , sparclinux@vger.kernel.org, Stefano Stabellini , Yoshinori Sato , Gregory Clement , "Rafael J. Wysocki" , Russell King , linux-acpi@vger.kernel.org, Miguel Ojeda , xen-devel@lists.xenproject.org, Matt Turner , Anatolij Gustschin , Sebastian Hesselbarth , Arnd Bergmann , Niklas Schnelle , Richard Henderson , Nicholas Piggin , Ivan Kokshaysky , John Paul Adrian Glaubitz , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Juergen Gross , Thomas Bogendoerfer , linuxppc-dev@lists.ozlabs.org, Randy Dunlap , linux-kernel@vger.kernel.org, Oleksandr Tyshchenko , linux-alpha@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , "David S. Miller" , "Maciej W. Rozycki" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 23, 2023 at 04:30:01PM +0200, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 02:28:04PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 20, 2023 at 03:16:30PM +0200, Andy Shevchenko wrote: > ... > > > > + pci_dev_for_each_resource_p(dev, r) { > > > /* zap the 2nd function of the winbond chip */ > > > - if (dev->resource[i].flags & IORESOURCE_IO > > > - && dev->bus->number == 0 && dev->devfn == 0x81) > > > - dev->resource[i].flags &= ~IORESOURCE_IO; > > > - if (dev->resource[i].start == 0 && dev->resource[i].end) { > > > - dev->resource[i].flags = 0; > > > - dev->resource[i].end = 0; > > > + if (dev->bus->number == 0 && dev->devfn == 0x81 && > > > + r->flags & IORESOURCE_IO) > > > > This is a nice literal conversion, but it's kind of lame to test > > bus->number and devfn *inside* the loop here, since they can't change > > inside the loop. > > Hmm... why are you asking me, even if I may agree on that? It's > in the original code and out of scope of this series. Yeah, I don't think it would be *unreasonable* to clean this up at the same time so the maintainers can look at both at the same time (this is arch/powerpc/platforms/pseries/pci.c, so Michael, et al), but no need for you to do anything, certainly. I can post a follow-up patch. > > but > > since we're converging on the "(dev, res)" style, I think we should > > reverse the names so we have something like: > > > > pci_dev_for_each_resource(dev, res) > > pci_dev_for_each_resource_idx(dev, res, i) > > Wouldn't it be more churn, including pci_bus_for_each_resource() correction? Yes, it definitely is a little more churn because we already have pci_bus_for_each_resource() that would have to be changed. I poked around looking for similar patterns elsewhere with: git grep "#define.*for_each_.*_p(" git grep "#define.*for_each_.*_idx(" I didn't find any other "_p" iterators and just a few "_idx" ones, so my hope is to follow what little precedent there is, as well as converge on the basic "*_for_each_resource()" iterators and remove the "_idx()" versions over time by doing things like the pci_claim_resource() change. What do you think? If it seems like excessive churn, we can do it as-is and still try to reduce the use of the index variable over time. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2102DC6FD1C for ; Thu, 23 Mar 2023 15:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=RYIDLiy2kJ+20Bgco4Uh2pU+h2nG7Ri/jJPHSBPD0KM=; b=WWnfsnYHLRS55/ OV5qqXxvz9Ah93S6AAPzg/dkHQwuFLX1VsaNaWmEZr3yXxyJnBEAV1UDxI+cwcmsnCztrh+AE1Nmo QkxnzKLHoYoAbkIEs97UaEOw+hRWHRaie1nP3021+7pKHF6myeeZ/3+rYn365TKSTBu+kraNc6FBA ZgdpM+O4opqD1yBoyl8HpKqHcsAzX3zYfWXvjKyyjapwznXT4i5SQNNjQaLnVnmv9ZbPjjeB3B7px tWyEdq73EkKxBw0xhe9za05hADkoGkjJGiTrIsAikvN8EZzOvA/OU9RDdJPPVIpnsQTVjjAxYZuUe xAAwTac1RtSAijemYVVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfMSq-002IRw-1l; Thu, 23 Mar 2023 15:02:52 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfMSh-002IN4-2j for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 15:02:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27E14B8208A; Thu, 23 Mar 2023 15:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7276DC4339E; Thu, 23 Mar 2023 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679583760; bh=A4cz5sAtdGojClghNnzslTTn+0telsrqWPrc7ZEY92A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QZ2KDQiDLNeolamz/rBZXmXKaml10w90GcGwB6l5yO87qYFqQPDIQgKZ80zht8Qsc Xeoi/zLrt2EtH3nbngx/R5sYZx0Xwf4JkO9knqHSrKtOYd2+7MSeapV8B/zw9rxmZf 9UhNHPKZpA1ucTpj/VgulfE/ACFQnVZP8YBw36pan4Gf8wwyvTOnEEDjDM2KPQPTQp ZGCnVZCISmiqwx5zKNrKd8Mk7Zh6u/0oYwI8LPRfc1PEUXu67DDtdxfqNx9ryyF1pw 4cNq1h1H67JIwrFngX1Sl9ypuAP/OCB5kx8wJtxg7nOzQYMGU2gbmFC/O67YEr6JCJ aHqE0tG0UVQoQ== Date: Thu, 23 Mar 2023 10:02:38 -0500 From: Bjorn Helgaas To: Andy Shevchenko Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v6 1/4] PCI: Introduce pci_dev_for_each_resource() Message-ID: <20230323150238.GA2550157@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_080244_188110_9FC6F197 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 23, 2023 at 04:30:01PM +0200, Andy Shevchenko wrote: > On Wed, Mar 22, 2023 at 02:28:04PM -0500, Bjorn Helgaas wrote: > > On Mon, Mar 20, 2023 at 03:16:30PM +0200, Andy Shevchenko wrote: > ... > > > > + pci_dev_for_each_resource_p(dev, r) { > > > /* zap the 2nd function of the winbond chip */ > > > - if (dev->resource[i].flags & IORESOURCE_IO > > > - && dev->bus->number == 0 && dev->devfn == 0x81) > > > - dev->resource[i].flags &= ~IORESOURCE_IO; > > > - if (dev->resource[i].start == 0 && dev->resource[i].end) { > > > - dev->resource[i].flags = 0; > > > - dev->resource[i].end = 0; > > > + if (dev->bus->number == 0 && dev->devfn == 0x81 && > > > + r->flags & IORESOURCE_IO) > > > > This is a nice literal conversion, but it's kind of lame to test > > bus->number and devfn *inside* the loop here, since they can't change > > inside the loop. > > Hmm... why are you asking me, even if I may agree on that? It's > in the original code and out of scope of this series. Yeah, I don't think it would be *unreasonable* to clean this up at the same time so the maintainers can look at both at the same time (this is arch/powerpc/platforms/pseries/pci.c, so Michael, et al), but no need for you to do anything, certainly. I can post a follow-up patch. > > but > > since we're converging on the "(dev, res)" style, I think we should > > reverse the names so we have something like: > > > > pci_dev_for_each_resource(dev, res) > > pci_dev_for_each_resource_idx(dev, res, i) > > Wouldn't it be more churn, including pci_bus_for_each_resource() correction? Yes, it definitely is a little more churn because we already have pci_bus_for_each_resource() that would have to be changed. I poked around looking for similar patterns elsewhere with: git grep "#define.*for_each_.*_p(" git grep "#define.*for_each_.*_idx(" I didn't find any other "_p" iterators and just a few "_idx" ones, so my hope is to follow what little precedent there is, as well as converge on the basic "*_for_each_resource()" iterators and remove the "_idx()" versions over time by doing things like the pci_claim_resource() change. What do you think? If it seems like excessive churn, we can do it as-is and still try to reduce the use of the index variable over time. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel