From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0EDFC6FD20 for ; Fri, 24 Mar 2023 13:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbjCXNNn (ORCPT ); Fri, 24 Mar 2023 09:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbjCXNNm (ORCPT ); Fri, 24 Mar 2023 09:13:42 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B0FCD2128; Fri, 24 Mar 2023 06:13:40 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pfhEh-00010v-04; Fri, 24 Mar 2023 14:13:39 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9A431C1B8C; Fri, 24 Mar 2023 14:13:10 +0100 (CET) Date: Fri, 24 Mar 2023 14:13:10 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH v2 4/4] MIPS: c-r4k: Always install dma flush functions Message-ID: <20230324131310.GE15824@alpha.franken.de> References: <20230222132425.7442-1-jiaxun.yang@flygoat.com> <20230222132425.7442-5-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230222132425.7442-5-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Feb 22, 2023 at 01:24:25PM +0000, Jiaxun Yang wrote: > As nowadays DMA coherence is managed per device, it is possible > to have a system that is defaulted to coherent dma but still > have noncoherent device that needs to use those flush functions. > > Just install them unconditionally. > > Signed-off-by: Jiaxun Yang > --- > arch/mips/mm/c-r4k.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]