From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE247C6FD1C for ; Fri, 24 Mar 2023 14:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uACHv/59axT/BNzdghWhGLqy8KADwSK3/VA4d257wnw=; b=S5rBuiHZ7f264V reiZ5hgfSx5OciUprznRb9bluYz019/F6UZ6rvuSuS/unp7IKGRPH1ClwdmXcYGcQ8oGZ0mlN2IHp ObG88J/Zaf88uGAfRHPWWhLEHcRkjKtcQVwHa0UKbJlgh/7ceofE6jcPdm3FDA8MpVdCDwG0YZhRT x2WBt3oxtiYQBSJwG5TgFhRqi62WQCTxiYcDL6gu2u+mcBOMSHMQ7d9IxlFePt504HottRJFf1pO8 YHq4zOAtj9DvZ/EKGc8qIBfmgSHN3ntSvZu7oqcVX7k0iLfS/zcERMkJDDU46quP80BspkL8K+gCy 6Pky4rlddHeCookED/KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfiWa-004eQX-1x; Fri, 24 Mar 2023 14:36:12 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfiWW-004ePS-1q for linux-mtd@lists.infradead.org; Fri, 24 Mar 2023 14:36:11 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6C35FE000F; Fri, 24 Mar 2023 14:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1679668565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lv8p1+PnrZtKSya53OQStnceMrUDgZxb7dVA77owBQU=; b=LDvZj8jhrSHGoSqGXF0XTnlLPkBgVRq9egUk6tPUXR6//bl14C2On9KPoNqcs3EezMzKHQ mH+5cnvswV9S1tCBIQYNrEx6MJdsUl5byowb/CtQ555xlq3qh+nTTcxirEeaa+3lDHPHX1 ULZe7KTowTGVnFRDCuZosfZc7jxglLimnKRtxBwHrr5iv/isPgQYvBBT40nyZj9iDbU02b ZC8G+Jtdx3XPDnncvFkA9LJx9y3Yq2revwFVuWsArVVz2pDxkPqeQhXYxjXWp8f0mMGPhV gwIB69zyKpUH/pAe2CiGjT4vTwcbOCV8THQPya/zpJn7LjvSD89JRx3MXuVcIQ== Date: Fri, 24 Mar 2023 15:36:02 +0100 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Cc: richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, masonccyang@mxic.com.tw, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jaime Liao , YouChing Subject: Re: [PATCH 1/2] dt-bindings: mtd: nand: Macronix: document new binding Message-ID: <20230324153602.66a8841d@xps-13> In-Reply-To: References: <20230323124510.2484808-1-noltari@gmail.com> <20230323124510.2484808-2-noltari@gmail.com> <20230324104020.54754079@xps-13> <20230324114911.19e00ae1@xps-13> <20230324144559.3473c537@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_073608_918096_751428DD X-CRM114-Status: GOOD ( 55.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgw4FsdmFybywKCisgWW91Q2hpbmcgYW5kIEphaW1lIGZyb20gTWFjcm9uaXgKVExEUiBmb3Ig dGhlbTogdGhlcmUgaXMgYSBtaXNiZWhhdmlvciBzaW5jZSBNYXNvbiBhZGRlZCBibG9jawpwcm90 ZWN0aW9uIHN1cHBvcnQuIEp1c3QgY2hlY2tpbmcgaWYgdGhlIGJsb2NrcyBhcmUgcHJvdGVjdGVk IHNlZW1zIHRvCm1pc2NvbmZpZ3VyZSB0aGUgY2hpcCBlbnRpcmVseSwgc2VlIGJlbG93LiBBbnkg aGludHM/Cgpub2x0YXJpQGdtYWlsLmNvbSB3cm90ZSBvbiBGcmksIDI0IE1hciAyMDIzIDE1OjE1 OjQ3ICswMTAwOgoKPiBIaSBNaXF1w6hsLAo+IAo+IDIwMjMtMDMtMjQgMTQ6NDUgR01UKzAxOjAw LCBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPjoKPiA+IEhpIMOBbHZh cm8sCj4gPgo+ID4gbm9sdGFyaUBnbWFpbC5jb20gd3JvdGUgb24gRnJpLCAyNCBNYXIgMjAyMyAx MjoyMToxMSArMDEwMDoKPiA+ICAKPiA+PiBFbCB2aWUsIDI0IG1hciAyMDIzIGEgbGFzIDExOjQ5 LCBNaXF1ZWwgUmF5bmFsCj4gPj4gKDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPikgZXNjcmli acOzOiAgCj4gPj4gPgo+ID4+ID4gSGkgw4FsdmFybywKPiA+PiA+Cj4gPj4gPiBub2x0YXJpQGdt YWlsLmNvbSB3cm90ZSBvbiBGcmksIDI0IE1hciAyMDIzIDExOjMxOjE3ICswMTAwOgo+ID4+ID4g IAo+ID4+ID4gPiBIaSBNaXF1w6hsLAo+ID4+ID4gPgo+ID4+ID4gPiBFbCB2aWUsIDI0IG1hciAy MDIzIGEgbGFzIDEwOjQwLCBNaXF1ZWwgUmF5bmFsCj4gPj4gPiA+ICg8bWlxdWVsLnJheW5hbEBi b290bGluLmNvbT4pIGVzY3JpYmnDszogIAo+ID4+ID4gPiA+Cj4gPj4gPiA+ID4gSGkgw4FsdmFy bywKPiA+PiA+ID4gPgo+ID4+ID4gPiA+IG5vbHRhcmlAZ21haWwuY29tIHdyb3RlIG9uIFRodSwg MjMgTWFyIDIwMjMgMTM6NDU6MDkgKzAxMDA6Cj4gPj4gPiA+ID4gIAo+ID4+ID4gPiA+ID4gQWRk IG5ldyAibXhpYyxkaXNhYmxlLWJsb2NrLXByb3RlY3Rpb24iIGJpbmRpbmcgZG9jdW1lbnRhdGlv bi4KPiA+PiA+ID4gPiA+IFRoaXMgYmluZGluZyBhbGxvd3MgZGlzYWJsaW5nIGJsb2NrIHByb3Rl Y3Rpb24gc3VwcG9ydCBmb3IgdGhvc2UKPiA+PiA+ID4gPiA+IGRldmljZXMgbm90Cj4gPj4gPiA+ ID4gPiBzdXBwb3J0aW5nIGl0Lgo+ID4+ID4gPiA+ID4KPiA+PiA+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IMOBbHZhcm8gRmVybsOhbmRleiBSb2phcyA8bm9sdGFyaUBnbWFpbC5jb20+Cj4gPj4gPiA+ ID4gPiAtLS0KPiA+PiA+ID4gPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv bXRkL25hbmQtbWFjcm9uaXgudHh0IHwgMyArKysKPiA+PiA+ID4gPiA+ICAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspCj4gPj4gPiA+ID4gPgo+ID4+ID4gPiA+ID4gZGlmZiAtLWdpdAo+ ID4+ID4gPiA+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL25hbmQt bWFjcm9uaXgudHh0Cj4gPj4gPiA+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9tdGQvbmFuZC1tYWNyb25peC50eHQKPiA+PiA+ID4gPiA+IGluZGV4IGZmYWIyOGEyYzRk MS4uMDNmNjVjYTMyY2QzIDEwMDY0NAo+ID4+ID4gPiA+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9uYW5kLW1hY3Jvbml4LnR4dAo+ID4+ID4gPiA+ID4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9uYW5kLW1hY3Jvbml4LnR4 dAo+ID4+ID4gPiA+ID4gQEAgLTE2LDYgKzE2LDkgQEAgaW4gY2hpbGRyZW4gbm9kZXMuCj4gPj4g PiA+ID4gPiAgUmVxdWlyZWQgTkFORCBjaGlwIHByb3BlcnRpZXMgaW4gY2hpbGRyZW4gbW9kZToK PiA+PiA+ID4gPiA+ICAtIHJhbmRvbWl6ZXIgZW5hYmxlOiBzaG91bGQgYmUgIm14aWMsZW5hYmxl LXJhbmRvbWl6ZXItb3RwIgo+ID4+ID4gPiA+ID4KPiA+PiA+ID4gPiA+ICtPcHRpb25hbCBOQU5E IGNoaXAgcHJvcGVydGllcyBpbiBjaGlsZHJlbiBtb2RlOgo+ID4+ID4gPiA+ID4gKy0gYmxvY2sg cHJvdGVjdGlvbiBkaXNhYmxlOiBzaG91bGQgYmUKPiA+PiA+ID4gPiA+ICJteGljLGRpc2FibGUt YmxvY2stcHJvdGVjdGlvbiIKPiA+PiA+ID4gPiA+ICsgIAo+ID4+ID4gPiA+Cj4gPj4gPiA+ID4g QmVzaWRlcyB0aGUgZmFjdCB0aGF0IG5vd2FkYXlzIHdlIHByZWZlciB0byBzZWUgYmluZGluZyBj b252ZXJzaW9ucwo+ID4+ID4gPiA+IHRvCj4gPj4gPiA+ID4geWFtbCBiZWZvcmUgYWRkaW5nIGFu eXRoaW5nLCBJIGRvbid0IHRoaW5rIHRoaXMgd2lsbCBmbHkuCj4gPj4gPiA+ID4KPiA+PiA+ID4g PiBJJ20gbm90IHN1cmUgZXhhY3RseSB3aGF0ICJkaXNhYmxlIGJsb2NrIHByb3RlY3Rpb24iIG1l YW5zLCB3ZQo+ID4+ID4gPiA+IGFscmVhZHkgaGF2ZSBzaW1pbGFyIHByb3BlcnRpZXMgbGlrZSAi bG9jayIgYW5kICJzZWN1cmUtcmVnaW9ucyIsCj4gPj4gPiA+ID4gbm90Cj4gPj4gPiA+ID4gc3Vy ZSB0aGV5IHdpbGwgZml0IGJ1dCBJIHRoaW5rIGl0J3Mgd29ydGggY2hlY2tpbmcuICAKPiA+PiA+ ID4KPiA+PiA+ID4gQXMgZXhwbGFpbmVkIGluIDIvMiwgY29tbWl0IDAzYTUzOWM3YTExOCBpbnRy b2R1Y2VkIGEgcmVncmVzc2lvbiBvbgo+ID4+ID4gPiBTZXJjb21tIEg1MDAtcyAoQkNNNjMyNjgp IE9wZW5XcnQgZGV2aWNlcyB3aXRoIE1hY3Jvbml4IE1YMzBMRjFHMThBQwo+ID4+ID4gPiB3aGlj aCBoYW5ncyB0aGUgZGV2aWNlLgo+ID4+ID4gPgo+ID4+ID4gPiBUaGlzIGlzIHRoZSBsb2cgd2l0 aCBibG9jayBwcm90ZWN0aW9uIGRpc2FibGVkOgo+ID4+ID4gPiBbICAgIDAuNDk1ODMxXSBiY202 MzY4X25hbmQgMTAwMDAyMDAubmFuZDogdGhlcmUgaXMgbm90IHZhbGlkIG1hcHMKPiA+PiA+ID4g Zm9yCj4gPj4gPiA+IHN0YXRlIGRlZmF1bHQKPiA+PiA+ID4gWyAgICAwLjUwNDk5NV0gbmFuZDog ZGV2aWNlIGZvdW5kLCBNYW51ZmFjdHVyZXIgSUQ6IDB4YzIsIENoaXAgSUQ6Cj4gPj4gPiA+IDB4 ZjEKPiA+PiA+ID4gWyAgICAwLjUxMTUyNl0gbmFuZDogTWFjcm9uaXggTVgzMExGMUcxOEFDCj4g Pj4gPiA+IFsgICAgMC41MTU1ODZdIG5hbmQ6IDEyOCBNaUIsIFNMQywgZXJhc2Ugc2l6ZTogMTI4 IEtpQiwgcGFnZSBzaXplOgo+ID4+ID4gPiAyMDQ4LCBPT0Igc2l6ZTogNjQKPiA+PiA+ID4gWyAg ICAwLjUyMzUxNl0gYmNtNjM2OF9uYW5kIDEwMDAwMjAwLm5hbmQ6IGRldGVjdGVkIDEyOE1pQiB0 b3RhbCwKPiA+PiA+ID4gMTI4S2lCIGJsb2NrcywgMktpQiBwYWdlcywgMTZCIE9PQiwgOC1iaXQs IEJDSC00Cj4gPj4gPiA+IFsgICAgMC41MzU5MTJdIEJhZCBibG9jayB0YWJsZSBmb3VuZCBhdCBw YWdlIDY1NDcyLCB2ZXJzaW9uIDB4MDEKPiA+PiA+ID4gWyAgICAwLjU0NDI2OF0gQmFkIGJsb2Nr IHRhYmxlIGZvdW5kIGF0IHBhZ2UgNjU0MDgsIHZlcnNpb24gMHgwMQo+ID4+ID4gPiBbICAgIDAu OTU0MzI5XSA5IGZpeGVkLXBhcnRpdGlvbnMgcGFydGl0aW9ucyBmb3VuZCBvbiBNVEQgZGV2aWNl Cj4gPj4gPiA+IGJyY21uYW5kLjAKPiA+PiA+ID4gLi4uCj4gPj4gPiA+Cj4gPj4gPiA+IFRoaXMg aXMgdGhlIGxvZyB3aXRoIGJsb2NrIHByb3RlY3Rpb24gZW5hYmxlZDoKPiA+PiA+ID4gWyAgICAw LjQ5NTA5NV0gYmNtNjM2OF9uYW5kIDEwMDAwMjAwLm5hbmQ6IHRoZXJlIGlzIG5vdCB2YWxpZCBt YXBzCj4gPj4gPiA+IGZvcgo+ID4+ID4gPiBzdGF0ZSBkZWZhdWx0Cj4gPj4gPiA+IFsgICAgMC41 MDQyNDldIG5hbmQ6IGRldmljZSBmb3VuZCwgTWFudWZhY3R1cmVyIElEOiAweGMyLCBDaGlwIElE Ogo+ID4+ID4gPiAweGYxCj4gPj4gPiA+IFsgICAgMC41MTA3NzJdIG5hbmQ6IE1hY3Jvbml4IE1Y MzBMRjFHMThBQwo+ID4+ID4gPiBbICAgIDAuNTE0ODc0XSBuYW5kOiAxMjggTWlCLCBTTEMsIGVy YXNlIHNpemU6IDEyOCBLaUIsIHBhZ2Ugc2l6ZToKPiA+PiA+ID4gMjA0OCwgT09CIHNpemU6IDY0 Cj4gPj4gPiA+IFsgICAgMC41MjI3ODBdIGJjbTYzNjhfbmFuZCAxMDAwMDIwMC5uYW5kOiBkZXRl Y3RlZCAxMjhNaUIgdG90YWwsCj4gPj4gPiA+IDEyOEtpQiBibG9ja3MsIDJLaUIgcGFnZXMsIDE2 QiBPT0IsIDgtYml0LCBCQ0gtNAo+ID4+ID4gPiBbICAgIDAuNTM5Njg3XSBCYWQgYmxvY2sgdGFi bGUgbm90IGZvdW5kIGZvciBjaGlwIDAKPiA+PiA+ID4gWyAgICAwLjU1MDE1M10gQmFkIGJsb2Nr IHRhYmxlIG5vdCBmb3VuZCBmb3IgY2hpcCAwCj4gPj4gPiA+IFsgICAgMC41NTUwNjldIFNjYW5u aW5nIGRldmljZSBmb3IgYmFkIGJsb2Nrcwo+ID4+ID4gPiBbICAgIDAuNjAxMjEzXSBDUFUgMSBV bmFibGUgdG8gaGFuZGxlIGtlcm5lbCBwYWdpbmcgcmVxdWVzdCBhdAo+ID4+ID4gPiB2aXJ0dWFs Cj4gPj4gPiA+IGFkZHJlc3MgMTAyNzdmMDAsIGVwYyA9PSA4MDM5Y2U3MCwgcmEgPT0gODAxNmFk NTAKPiA+PiA+ID4gKioqIERldmljZSBoYW5ncyAqKioKPiA+PiA+ID4KPiA+PiA+ID4gRW5hYmxp bmcgbWFjcm9uaXhfbmFuZF9ibG9ja19wcm90ZWN0aW9uX3N1cHBvcnQoKSBtYWtlcyB0aGUgZGV2 aWNlCj4gPj4gPiA+IHVuYWJsZSB0byBkZXRlY3QgdGhlIGJhZCBibG9jayB0YWJsZSBhbmQgaGFu Z3MgaXQgd2hlbiB0cnlpbmcgdG8gc2Nhbgo+ID4+ID4gPiBmb3IgYmFkIGJsb2Nrcy4gIAo+ID4+ ID4KPiA+PiA+IFBsZWFzZSB0cmFjZSBuYW5kX21hY3Jvbml4LmMgYW5kIGxvb2s6Cj4gPj4gPiAt IGFyZSB0aGUgZ2V0X2ZlYXR1cmVzIGFuZCBzZXRfZmVhdHVyZXMgcmVhbGx5IHN1cHBvcnRlZCBi eSB0aGUKPiA+PiA+ICAgY29udHJvbGxlciBkcml2ZXI/ICAKPiA+Pgo+ID4+IFRoaXMgaXMgd2hh dCBJIGNvdWxkIGZpbmQgYnkgZGVidWdnaW5nOgo+ID4+IFsgICAgMC40OTQ5OTNdIGJjbTYzNjhf bmFuZCAxMDAwMDIwMC5uYW5kOiB0aGVyZSBpcyBub3QgdmFsaWQgbWFwcyBmb3IKPiA+PiBzdGF0 ZSBkZWZhdWx0Cj4gPj4gWyAgICAwLjUwNTM3NV0gbmFuZDogZGV2aWNlIGZvdW5kLCBNYW51ZmFj dHVyZXIgSUQ6IDB4YzIsIENoaXAgSUQ6IDB4ZjEKPiA+PiBbICAgIDAuNTEyMDc3XSBuYW5kOiBN YWNyb25peCBNWDMwTEYxRzE4QUMKPiA+PiBbICAgIDAuNTE1OTk0XSBuYW5kOiAxMjggTWlCLCBT TEMsIGVyYXNlIHNpemU6IDEyOCBLaUIsIHBhZ2Ugc2l6ZToKPiA+PiAyMDQ4LCBPT0Igc2l6ZTog NjQKPiA+PiBbICAgIDAuNTIzOTI4XSBiY202MzY4X25hbmQgMTAwMDAyMDAubmFuZDogZGV0ZWN0 ZWQgMTI4TWlCIHRvdGFsLAo+ID4+IDEyOEtpQiBibG9ja3MsIDJLaUIgcGFnZXMsIDE2QiBPT0Is IDgtYml0LCBCQ0gtNAo+ID4+IFsgICAgMC41MzQ0MTVdIGJjbTYzNjhfbmFuZCAxMDAwMDIwMC5u YW5kOiBsbF9vcCBjbWQgMHhhMDBlZQo+ID4+IFsgICAgMC41Mzk5ODhdIGJjbTYzNjhfbmFuZCAx MDAwMDIwMC5uYW5kOiBsbF9vcCBjbWQgMHg2MDBhMAo+ID4+IFsgICAgMC41NDU2NTldIGJjbTYz NjhfbmFuZCAxMDAwMDIwMC5uYW5kOiBsbF9vcCBjbWQgMHgxMDAwMAo+ID4+IFsgICAgMC41NTEy MTRdIGJjbTYzNjhfbmFuZCAxMDAwMDIwMC5uYW5kOiBOQU5EX0NNRF9HRVRfRkVBVFVSRVMgPSAw eDAwCj4gPj4gWyAgICAwLjU1Nzg0M10gYmNtNjM2OF9uYW5kIDEwMDAwMjAwLm5hbmQ6IGxsX29w IGNtZCAweDEwMDAwCj4gPj4gWyAgICAwLjU2MzQ3NV0gYmNtNjM2OF9uYW5kIDEwMDAwMjAwLm5h bmQ6IE5BTkRfQ01EX0dFVF9GRUFUVVJFUyA9IDB4MDAKPiA+PiBbICAgIDAuNTY5OTk4XSBiY202 MzY4X25hbmQgMTAwMDAyMDAubmFuZDogbGxfb3AgY21kIDB4MTAwMDAKPiA+PiBbICAgIDAuNTc1 NjUzXSBiY202MzY4X25hbmQgMTAwMDAyMDAubmFuZDogTkFORF9DTURfR0VUX0ZFQVRVUkVTID0g MHgwMAo+ID4+IFsgICAgMC41ODIyNDZdIGJjbTYzNjhfbmFuZCAxMDAwMDIwMC5uYW5kOiBsbF9v cCBjbWQgMHg4MDAxMDAwMAo+ID4+IFsgICAgMC41ODgwNjddIGJjbTYzNjhfbmFuZCAxMDAwMDIw MC5uYW5kOiBOQU5EX0NNRF9HRVRfRkVBVFVSRVMgPSAweDAwCj4gPj4gWyAgICAwLjU5NDY1N10g bmFuZDogbmFuZF9nZXRfZmVhdHVyZXM6IGFkZHI9YTAgc3ViZmVhdHVyZV9wYXJhbT1bMDAKPiA+ PiAwMCAwMCAwMF0gLT4gMAo+ID4+IFsgICAgMC42MDIzNDFdIG1hY3Jvbml4X25hbmRfYmxvY2tf cHJvdGVjdGlvbl9zdXBwb3J0Ogo+ID4+IE9ORklfRkVBVFVSRV9BRERSX01YSUNfUFJPVEVDVElP Tj0wCj4gPj4gWyAgICAwLjYxMDU0OF0gbWFjcm9uaXhfbmFuZF9ibG9ja19wcm90ZWN0aW9uX3N1 cHBvcnQ6ICE9Cj4gPj4gTVhJQ19CTE9DS19QUk9URUNUSU9OX0FMTF9MT0NLCj4gPj4gWyAgICAw LjYyNDc2MF0gQmFkIGJsb2NrIHRhYmxlIG5vdCBmb3VuZCBmb3IgY2hpcCAwCj4gPj4gWyAgICAw LjYzNTU0Ml0gQmFkIGJsb2NrIHRhYmxlIG5vdCBmb3VuZCBmb3IgY2hpcCAwCj4gPj4gWyAgICAw LjY0MDI3MF0gU2Nhbm5pbmcgZGV2aWNlIGZvciBiYWQgYmxvY2tzCj4gPj4KPiA+PiBJIGRvbid0 IGtub3cgaG93IHRvIHRlbGwgaWYgZ2V0X2ZlYXR1cmVzIC8gc2V0X2ZlYXR1cmVzIGlzIHJlYWxs eQo+ID4+IHN1cHBvcnRlZC4uLiAgCj4gPgo+ID4gTG9va3MgbGlrZSB5b3VyIGRyaXZlciBkb2Vz IG5vdCBzdXBwb3J0IGV4ZWNfb3AgYnV0IHRoZSBjb3JlIHByb3ZpZGVzIGEKPiA+IGdldC9zZXRf ZmVhdHVyZSBpbXBsZW1lbnRhdGlvbi4gIAo+IAo+IEFjY29yZGluZyB0byBGbG9yaWFuLCBsb3cg bGV2ZWwgc2hvdWxkIGJlIHN1cHBvcnRlZCBvbiBicmNtbmFuZAo+IGNvbnRyb2xsZXJzID49IDQu MAo+IEFsc286Cj4gaHR0cHM6Ly9naXRodWIuY29tL25vbWlzL2JjbTk2M3h4XzQuMTJMLjA2Ql9j b25zdW1lci9ibG9iL2UyZjIzZGRiYjIwYmY3NTY4OTM3MmI2ZTZhNWEwZGM2MTNmNmUzMTMvc2hh cmVkL29wZW5zb3VyY2UvaW5jbHVkZS9iY205NjN4eC82MzI2OF9tYXBfcGFydC5oI0wxNTk3CgpK dXN0IHRvIGJlIHN1cmUsIHlvdSdyZSB1c2luZyBhIG1haW5saW5lIGNvbnRyb2xsZXIgZHJpdmVy LCBub3QgdGhpcwpvbmU/Cgo+ID4gIAo+ID4+ICAKPiA+PiA+IC0gd2hhdCBpcyB0aGUgc3RhdGUg b2YgdGhlIGxvY2tpbmcgY29uZmlndXJhdGlvbiBpbiB0aGUgY2hpcCB3aGVuIHlvdQo+ID4+ID4g ICBib290PyAgCj4gPj4KPiA+PiBVbmxvY2tlZCwgSSBndWVzcy4uLgo+ID4+IEhvdyBjYW4gSSBj aGVjayB0aGF0PyAgCj4gPgo+ID4gSXQncyBpbiB5b3VyIGR1bXAsIHRoZSBjaGlwIHJldHVybnMg MCwgbWVhbmluZyBpdCdzIGFsbCB1bmxvY2tlZCwKPiA+IGFwcGFyZW50bHkuICAKPiAKPiBXZWxs LCBJIGNhbiByZWFkL3dyaXRlIHRoZSBkZXZpY2UgaWYgYmxvY2sgcHJvdGVjdGlvbiBpc27igJl0 IGRpc2FibGVkLAo+IHNvIEkgZ3Vlc3Mgd2UgY2FuIGNvbmZpcm0gaXTigJlzIHVubG9ja2Vk4oCm Cj4gCj4gPiAgCj4gPj4gPiAtIGlzIHRoZXJlIGFueXRoaW5nIHRoYXQgbG9ja3MgdGhlIGRldmlj ZSBieSBjYWxsaW5nIG14aWNfbmFuZF9sb2NrKCkgPyAgCj4gPgo+ID4gU28gbm9ib2R5IGxvY2tz IHRoZSBkZXZpY2UgSSBndWVzcz8gRGlkIHlvdSBhZGQgdHJhY2VzIHRoZXJlPyAgCj4gCj4gSXQg ZG9lc27igJl0IGdldCB0byB0aGUgcG9pbnQgdGhhdCBpdCBlbmFibGVkIHRoZSBsb2NrL3VubG9j ayBmdW5jdGlvbnMKPiBzaW5jZSBpdCBmYWlscyB3aGVuIGNoZWNraW5nIGlmIGZlYXR1cmUgaXMg MHgzOCwgc28gdGhlcmXigJlzIG5vIHBvaW50Cj4gaW4gYWRkaW5nIHRob3NlIHRyYWNlc+KApgoK UmlnaHQsIGl0IHJldHVybnMgYmVmb3JlIHNldHRpbmcgdGhlc2UgSSBndWVzcy4KCj4gCj4gPiAg Cj4gPj4gPiAtIGZpbmRpbmcgbm8gYmJ0IGlzIG9uZSB0aGluZywgaGFuZ2luZyBpcyBhbm90aGVy LCB3aGVyZSBpcyBpdCBoYW5naW5nCj4gPj4gPiAgIGV4YWN0bHk/IChvZmZzZXQgaW4gbmFuZC8g YW5kIGxpbmUgaW4gdGhlIGNvZGUpICAKPiA+Pgo+ID4+IEkndmUgZ290IG5vIGlkZWEuLi4gIAo+ ID4KPiA+IFlvdSBjYW4gdXNlIGZ0cmFjZSBvciBqdXN0IGFkZCBwcmludGtzIGEgYml0IGV2ZXJ5 d2hlcmUgYW5kIHRyeSB0byBnZXQKPiA+IGNsb3NlciBhbmQgY2xvc2VyLiAgCj4gCj4gSSB0aGlu ayB0aGF0IGFmdGVyIHRyeWluZyB0byBnZXQgdGhlIGZlYXR1cmUgaXQganVzdCBzdGFydCByZWFk aW5nCj4gbm9uc2Vuc2UgZnJvbSB0aGUgTkFORCBhbmQgYXQgc29tZSBwb2ludCBpdCBoYW5ncyBk dWUgdG8gdGhhdCBnYXJiYWdl4oCmCgpJdCBzaG91bGQgcmVmdXNlIHRvIG1vdW50IHRoZSBkZXZp Y2Ugc29tZWhvdywgYnV0IGluIG5vIGNhc2UgdGhlIGtlcm5lbApzaG91bGQgaGFuZy4KCj4gSXMg aXQgcG9zaWJsZSB0aGF0IHRoZSBOQU5EIHN0YXJ0cyBiZWhhdmluZyBsaWtlIHRoaXMgYWZ0ZXIg Z2V0dGluZwo+IHRoZSBmZWF0dXJlIGR1ZSB0byBzb21lIHNwZWNpZmljIGNvbmZpZyBvZiBteSBk ZXZpY2U/Cj4gCj4gPgo+ID4gSSBsb29rZWQgYXQgdGhlIHBhdGNoLCBJIGRvbid0IHNlZSBhbnl0 aGluZyBzdHJhbmdlLiBCZXNpZGVzLCBJIGhhdmUgYQo+ID4gY2xvc2UgZW5vdWdoIGRhdGFzaGVl dCBhbmQgSSBkb24ndCBzZWUgd2hhdCBjb3VsZCBjb25mdXNlIHRoZSBkZXZpY2UuCj4gPgo+ID4g QXJlIHlvdSByZWFsbHkgc3VyZSB0aGlzIHBhdGNoIGlzIHRoZSBwcm9ibGVtPyBJcyB0aGUgV1Ag cGluIHdpcmVkIG9uCj4gPiB5b3VyIGRlc2lnbj8gIAo+IAo+IFRoZXJl4oCZcyBubyBXUCBwaW4g aW4gYnJjbW5hbmQgY29udHJvbGxlcnMgPCA3LjAKCldoYXQgYWJvdXQgdGhlIGNoaXA/CgpUaGFu a3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9CAC6FD1C for ; Fri, 24 Mar 2023 14:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231215AbjCXOgM (ORCPT ); Fri, 24 Mar 2023 10:36:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230380AbjCXOgM (ORCPT ); Fri, 24 Mar 2023 10:36:12 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A04EF9D; Fri, 24 Mar 2023 07:36:06 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6C35FE000F; Fri, 24 Mar 2023 14:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1679668565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lv8p1+PnrZtKSya53OQStnceMrUDgZxb7dVA77owBQU=; b=LDvZj8jhrSHGoSqGXF0XTnlLPkBgVRq9egUk6tPUXR6//bl14C2On9KPoNqcs3EezMzKHQ mH+5cnvswV9S1tCBIQYNrEx6MJdsUl5byowb/CtQ555xlq3qh+nTTcxirEeaa+3lDHPHX1 ULZe7KTowTGVnFRDCuZosfZc7jxglLimnKRtxBwHrr5iv/isPgQYvBBT40nyZj9iDbU02b ZC8G+Jtdx3XPDnncvFkA9LJx9y3Yq2revwFVuWsArVVz2pDxkPqeQhXYxjXWp8f0mMGPhV gwIB69zyKpUH/pAe2CiGjT4vTwcbOCV8THQPya/zpJn7LjvSD89JRx3MXuVcIQ== Date: Fri, 24 Mar 2023 15:36:02 +0100 From: Miquel Raynal To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6?= Rojas Cc: richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, masonccyang@mxic.com.tw, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jaime Liao , YouChing Subject: Re: [PATCH 1/2] dt-bindings: mtd: nand: Macronix: document new binding Message-ID: <20230324153602.66a8841d@xps-13> In-Reply-To: References: <20230323124510.2484808-1-noltari@gmail.com> <20230323124510.2484808-2-noltari@gmail.com> <20230324104020.54754079@xps-13> <20230324114911.19e00ae1@xps-13> <20230324144559.3473c537@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi =C3=81lvaro, + YouChing and Jaime from Macronix TLDR for them: there is a misbehavior since Mason added block protection support. Just checking if the blocks are protected seems to misconfigure the chip entirely, see below. Any hints? noltari@gmail.com wrote on Fri, 24 Mar 2023 15:15:47 +0100: > Hi Miqu=C3=A8l, >=20 > 2023-03-24 14:45 GMT+01:00, Miquel Raynal : > > Hi =C3=81lvaro, > > > > noltari@gmail.com wrote on Fri, 24 Mar 2023 12:21:11 +0100: > > =20 > >> El vie, 24 mar 2023 a las 11:49, Miquel Raynal > >> () escribi=C3=B3: =20 > >> > > >> > Hi =C3=81lvaro, > >> > > >> > noltari@gmail.com wrote on Fri, 24 Mar 2023 11:31:17 +0100: > >> > =20 > >> > > Hi Miqu=C3=A8l, > >> > > > >> > > El vie, 24 mar 2023 a las 10:40, Miquel Raynal > >> > > () escribi=C3=B3: =20 > >> > > > > >> > > > Hi =C3=81lvaro, > >> > > > > >> > > > noltari@gmail.com wrote on Thu, 23 Mar 2023 13:45:09 +0100: > >> > > > =20 > >> > > > > Add new "mxic,disable-block-protection" binding documentation. > >> > > > > This binding allows disabling block protection support for tho= se > >> > > > > devices not > >> > > > > supporting it. > >> > > > > > >> > > > > Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas > >> > > > > --- > >> > > > > Documentation/devicetree/bindings/mtd/nand-macronix.txt | 3 += ++ > >> > > > > 1 file changed, 3 insertions(+) > >> > > > > > >> > > > > diff --git > >> > > > > a/Documentation/devicetree/bindings/mtd/nand-macronix.txt > >> > > > > b/Documentation/devicetree/bindings/mtd/nand-macronix.txt > >> > > > > index ffab28a2c4d1..03f65ca32cd3 100644 > >> > > > > --- a/Documentation/devicetree/bindings/mtd/nand-macronix.txt > >> > > > > +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt > >> > > > > @@ -16,6 +16,9 @@ in children nodes. > >> > > > > Required NAND chip properties in children mode: > >> > > > > - randomizer enable: should be "mxic,enable-randomizer-otp" > >> > > > > > >> > > > > +Optional NAND chip properties in children mode: > >> > > > > +- block protection disable: should be > >> > > > > "mxic,disable-block-protection" > >> > > > > + =20 > >> > > > > >> > > > Besides the fact that nowadays we prefer to see binding conversi= ons > >> > > > to > >> > > > yaml before adding anything, I don't think this will fly. > >> > > > > >> > > > I'm not sure exactly what "disable block protection" means, we > >> > > > already have similar properties like "lock" and "secure-regions", > >> > > > not > >> > > > sure they will fit but I think it's worth checking. =20 > >> > > > >> > > As explained in 2/2, commit 03a539c7a118 introduced a regression on > >> > > Sercomm H500-s (BCM63268) OpenWrt devices with Macronix MX30LF1G18= AC > >> > > which hangs the device. > >> > > > >> > > This is the log with block protection disabled: > >> > > [ 0.495831] bcm6368_nand 10000200.nand: there is not valid maps > >> > > for > >> > > state default > >> > > [ 0.504995] nand: device found, Manufacturer ID: 0xc2, Chip ID: > >> > > 0xf1 > >> > > [ 0.511526] nand: Macronix MX30LF1G18AC > >> > > [ 0.515586] nand: 128 MiB, SLC, erase size: 128 KiB, page size: > >> > > 2048, OOB size: 64 > >> > > [ 0.523516] bcm6368_nand 10000200.nand: detected 128MiB total, > >> > > 128KiB blocks, 2KiB pages, 16B OOB, 8-bit, BCH-4 > >> > > [ 0.535912] Bad block table found at page 65472, version 0x01 > >> > > [ 0.544268] Bad block table found at page 65408, version 0x01 > >> > > [ 0.954329] 9 fixed-partitions partitions found on MTD device > >> > > brcmnand.0 > >> > > ... > >> > > > >> > > This is the log with block protection enabled: > >> > > [ 0.495095] bcm6368_nand 10000200.nand: there is not valid maps > >> > > for > >> > > state default > >> > > [ 0.504249] nand: device found, Manufacturer ID: 0xc2, Chip ID: > >> > > 0xf1 > >> > > [ 0.510772] nand: Macronix MX30LF1G18AC > >> > > [ 0.514874] nand: 128 MiB, SLC, erase size: 128 KiB, page size: > >> > > 2048, OOB size: 64 > >> > > [ 0.522780] bcm6368_nand 10000200.nand: detected 128MiB total, > >> > > 128KiB blocks, 2KiB pages, 16B OOB, 8-bit, BCH-4 > >> > > [ 0.539687] Bad block table not found for chip 0 > >> > > [ 0.550153] Bad block table not found for chip 0 > >> > > [ 0.555069] Scanning device for bad blocks > >> > > [ 0.601213] CPU 1 Unable to handle kernel paging request at > >> > > virtual > >> > > address 10277f00, epc =3D=3D 8039ce70, ra =3D=3D 8016ad50 > >> > > *** Device hangs *** > >> > > > >> > > Enabling macronix_nand_block_protection_support() makes the device > >> > > unable to detect the bad block table and hangs it when trying to s= can > >> > > for bad blocks. =20 > >> > > >> > Please trace nand_macronix.c and look: > >> > - are the get_features and set_features really supported by the > >> > controller driver? =20 > >> > >> This is what I could find by debugging: > >> [ 0.494993] bcm6368_nand 10000200.nand: there is not valid maps for > >> state default > >> [ 0.505375] nand: device found, Manufacturer ID: 0xc2, Chip ID: 0xf1 > >> [ 0.512077] nand: Macronix MX30LF1G18AC > >> [ 0.515994] nand: 128 MiB, SLC, erase size: 128 KiB, page size: > >> 2048, OOB size: 64 > >> [ 0.523928] bcm6368_nand 10000200.nand: detected 128MiB total, > >> 128KiB blocks, 2KiB pages, 16B OOB, 8-bit, BCH-4 > >> [ 0.534415] bcm6368_nand 10000200.nand: ll_op cmd 0xa00ee > >> [ 0.539988] bcm6368_nand 10000200.nand: ll_op cmd 0x600a0 > >> [ 0.545659] bcm6368_nand 10000200.nand: ll_op cmd 0x10000 > >> [ 0.551214] bcm6368_nand 10000200.nand: NAND_CMD_GET_FEATURES =3D 0= x00 > >> [ 0.557843] bcm6368_nand 10000200.nand: ll_op cmd 0x10000 > >> [ 0.563475] bcm6368_nand 10000200.nand: NAND_CMD_GET_FEATURES =3D 0= x00 > >> [ 0.569998] bcm6368_nand 10000200.nand: ll_op cmd 0x10000 > >> [ 0.575653] bcm6368_nand 10000200.nand: NAND_CMD_GET_FEATURES =3D 0= x00 > >> [ 0.582246] bcm6368_nand 10000200.nand: ll_op cmd 0x80010000 > >> [ 0.588067] bcm6368_nand 10000200.nand: NAND_CMD_GET_FEATURES =3D 0= x00 > >> [ 0.594657] nand: nand_get_features: addr=3Da0 subfeature_param=3D[= 00 > >> 00 00 00] -> 0 > >> [ 0.602341] macronix_nand_block_protection_support: > >> ONFI_FEATURE_ADDR_MXIC_PROTECTION=3D0 > >> [ 0.610548] macronix_nand_block_protection_support: !=3D > >> MXIC_BLOCK_PROTECTION_ALL_LOCK > >> [ 0.624760] Bad block table not found for chip 0 > >> [ 0.635542] Bad block table not found for chip 0 > >> [ 0.640270] Scanning device for bad blocks > >> > >> I don't know how to tell if get_features / set_features is really > >> supported... =20 > > > > Looks like your driver does not support exec_op but the core provides a > > get/set_feature implementation. =20 >=20 > According to Florian, low level should be supported on brcmnand > controllers >=3D 4.0 > Also: > https://github.com/nomis/bcm963xx_4.12L.06B_consumer/blob/e2f23ddbb20bf75= 689372b6e6a5a0dc613f6e313/shared/opensource/include/bcm963xx/63268_map_part= .h#L1597 Just to be sure, you're using a mainline controller driver, not this one? > > =20 > >> =20 > >> > - what is the state of the locking configuration in the chip when you > >> > boot? =20 > >> > >> Unlocked, I guess... > >> How can I check that? =20 > > > > It's in your dump, the chip returns 0, meaning it's all unlocked, > > apparently. =20 >=20 > Well, I can read/write the device if block protection isn=E2=80=99t disab= led, > so I guess we can confirm it=E2=80=99s unlocked=E2=80=A6 >=20 > > =20 > >> > - is there anything that locks the device by calling mxic_nand_lock(= ) ? =20 > > > > So nobody locks the device I guess? Did you add traces there? =20 >=20 > It doesn=E2=80=99t get to the point that it enabled the lock/unlock funct= ions > since it fails when checking if feature is 0x38, so there=E2=80=99s no po= int > in adding those traces=E2=80=A6 Right, it returns before setting these I guess. >=20 > > =20 > >> > - finding no bbt is one thing, hanging is another, where is it hangi= ng > >> > exactly? (offset in nand/ and line in the code) =20 > >> > >> I've got no idea... =20 > > > > You can use ftrace or just add printks a bit everywhere and try to get > > closer and closer. =20 >=20 > I think that after trying to get the feature it just start reading > nonsense from the NAND and at some point it hangs due to that garbage=E2= =80=A6 It should refuse to mount the device somehow, but in no case the kernel should hang. > Is it posible that the NAND starts behaving like this after getting > the feature due to some specific config of my device? >=20 > > > > I looked at the patch, I don't see anything strange. Besides, I have a > > close enough datasheet and I don't see what could confuse the device. > > > > Are you really sure this patch is the problem? Is the WP pin wired on > > your design? =20 >=20 > There=E2=80=99s no WP pin in brcmnand controllers < 7.0 What about the chip? Thanks, Miqu=C3=A8l