Re: [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static

[Ondrej Zary <linux@zary.sk>]

On Thursday 23 March 2023 04:38:36 Damien Le Moal wrote:
> Compilation C=1 of the bpck6 protocol module generates the following
> message:
> 
> drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' was
> not declared. Should it be static?
> 
> Fix this by declaring mode_map as static.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Reviewed-by: Ondrej Zary <linux@zary.sk>

> ---
>  drivers/ata/pata_parport/bpck6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
> index 295dbe5cdaa4..76febd07a9bb 100644
> --- a/drivers/ata/pata_parport/bpck6.c
> +++ b/drivers/ata/pata_parport/bpck6.c
> @@ -59,8 +59,8 @@
>  #define PPCMODE_EPP_WORD	5
>  #define PPCMODE_EPP_DWORD	6
>  
> -int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
> -		   PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
> +static int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
> +			  PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
>  
>  static void bpck6_send_cmd(struct pi_adapter *pi, u8 cmd)
>  {


-- 
Ondrej Zary