From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>,
Yafang Shao <laoar.shao@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
John Fastabend <john.fastabend@gmail.com>
Subject: [Patch bpf-next] sock_map: include sk_psock memory overhead too
Date: Sun, 26 Mar 2023 15:16:12 -0700 [thread overview]
Message-ID: <20230326221612.169289-1-xiyou.wangcong@gmail.com> (raw)
From: Cong Wang <cong.wang@bytedance.com>
When a socket is added to a sockmap, sk_psock is allocated too as its
sk_user_data, therefore it should be consider as an overhead of sockmap
memory usage.
Before this patch:
1: sockmap flags 0x0
key 4B value 4B max_entries 2 memlock 656B
pids echo-sockmap(549)
After this patch:
9: sockmap flags 0x0
key 4B value 4B max_entries 2 memlock 1824B
pids echo-sockmap(568)
Fixes: 73d2c61919e9 ("bpf, net: sock_map memory usage")
Cc: Yafang Shao <laoar.shao@gmail.com>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
---
net/core/sock_map.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/core/sock_map.c b/net/core/sock_map.c
index 7c189c2e2fbf..22197e565ece 100644
--- a/net/core/sock_map.c
+++ b/net/core/sock_map.c
@@ -799,9 +799,17 @@ static void sock_map_fini_seq_private(void *priv_data)
static u64 sock_map_mem_usage(const struct bpf_map *map)
{
+ struct bpf_stab *stab = container_of(map, struct bpf_stab, map);
u64 usage = sizeof(struct bpf_stab);
+ int i;
usage += (u64)map->max_entries * sizeof(struct sock *);
+
+ for (i = 0; i < stab->map.max_entries; i++) {
+ if (stab->sks[i])
+ usage += sizeof(struct sk_psock);
+ }
+
return usage;
}
@@ -1412,7 +1420,7 @@ static u64 sock_hash_mem_usage(const struct bpf_map *map)
u64 usage = sizeof(*htab);
usage += htab->buckets_num * sizeof(struct bpf_shtab_bucket);
- usage += atomic_read(&htab->count) * (u64)htab->elem_size;
+ usage += atomic_read(&htab->count) * ((u64)htab->elem_size + sizeof(struct sk_psock));
return usage;
}
--
2.34.1
next reply other threads:[~2023-03-26 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 22:16 Cong Wang [this message]
2023-03-27 3:48 ` [Patch bpf-next] sock_map: include sk_psock memory overhead too Yafang Shao
2023-04-01 1:09 ` John Fastabend
2023-04-02 10:41 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326221612.169289-1-xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.