From: Christoph Hellwig <hch@lst.de>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -next v7 3/4] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state
Date: Mon, 27 Mar 2023 01:26:25 +0200 [thread overview]
Message-ID: <20230326232625.GC19631@lst.de> (raw)
In-Reply-To: <20230325071420.2246461-4-liushixin2@huawei.com>
On Sat, Mar 25, 2023 at 03:14:19PM +0800, Liu Shixin wrote:
> -/* used by param callback function */
> -static bool zswap_init_started;
> +#define ZSWAP_UNINIT 0x0
> +#define ZSWAP_INIT_SUCCEED 0x1
> +#define ZSWAP_INIT_FAILED 0x2
This should be a (named) enum.
next prev parent reply other threads:[~2023-03-26 23:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 7:14 [PATCH -next v7 0/4] Delay the initialization of zswap Liu Shixin
2023-03-25 7:14 ` [PATCH -next v7 1/4] mm/zswap: remove zswap_entry_cache_{create,destroy} helper function Liu Shixin
2023-03-26 23:19 ` Christoph Hellwig
2023-03-25 7:14 ` [PATCH -next v7 2/4] mm/zswap: skip invalid or unchanged parameter Liu Shixin
2023-03-26 3:08 ` Sergey Senozhatsky
2023-03-26 3:17 ` Sergey Senozhatsky
2023-03-26 4:53 ` Sergey Senozhatsky
2023-03-26 23:25 ` Christoph Hellwig
2023-03-27 1:22 ` Liu Shixin
2023-03-25 7:14 ` [PATCH -next v7 3/4] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Liu Shixin
2023-03-26 23:26 ` Christoph Hellwig [this message]
2023-03-25 7:14 ` [PATCH -next v7 4/4] mm/zswap: delay the initializaton of zswap Liu Shixin
2023-03-26 23:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326232625.GC19631@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=nathan@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.