From: Chaitanya Kulkarni <kch@nvidia.com>
To: <linux-nvme@lists.infradead.org>
Cc: <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>,
<hare@suse.de>, Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH V2 0/8] nvme-core: trivial cleanups
Date: Sun, 26 Mar 2023 23:04:10 -0700 [thread overview]
Message-ID: <20230327060418.86655-1-kch@nvidia.com> (raw)
Hi,
Small code cleanups for nvme-core and the last patch has fixing really
long argument list of __nvme_submit_sync_cmd().
Please have a closer look at patch 3 and 8. There are no functional
changes in any of these patches.
V2 is passing the blktests, see log below.
-ck
v1->v2:
1. Update Reviewed-by tags (Sagi)
2. Revne struct nvme_submit_cmd_data to nvme_submit_cmd_args. (Sagi)
3. Remove patch #1 (Sagi)
Chaitanya Kulkarni (8):
nvme-core: remove unnecessary else
nvme-core: remvoe extra line at end of function
nvme-core: code cleanup for __nvme_check_ready()
nvme-core: use normal pattern
nvme-core: open code nvme_delete_ctrl_sync()
nvme-core: cleanup for nvme_set_latency_tolerance
nvme-core: remove unneacessary else
nvme-core: fix nvme_submit_sync_cmd() args
drivers/nvme/host/auth.c | 13 +++-
drivers/nvme/host/core.c | 148 +++++++++++++++++++++---------------
drivers/nvme/host/fabrics.c | 60 ++++++++++++---
drivers/nvme/host/nvme.h | 16 +++-
4 files changed, 158 insertions(+), 79 deletions(-)
blktests (master) # ./check nvme; nvme_trtype=tcp ./check nvme
nvme/002 (create many subsystems and test discovery) [passed]
runtime 18.950s ... 19.715s
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
runtime 10.099s ... 10.095s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
runtime 1.471s ... 1.546s
nvme/005 (reset local loopback target) [passed]
runtime 6.825s ... 6.919s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
runtime 0.068s ... 0.074s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
runtime 0.044s ... 0.048s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
runtime 1.476s ... 1.518s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
runtime 1.444s ... 1.475s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 7.449s ... 7.685s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
runtime 60.217s ... 78.689s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
runtime ... 12.459s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
runtime 104.896s ... 79.450s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
runtime 10.311s ... 9.759s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
runtime 9.617s ... 8.870s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [passed]
runtime 13.747s ... 15.775s
nvme/017 (create/delete many file-ns and test discovery) [passed]
runtime 14.690s ... 13.533s
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
runtime 1.524s ... 1.490s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
runtime 1.592s ... 1.470s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
runtime 1.536s ... 1.467s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
runtime 1.472s ... 1.461s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
runtime 6.758s ... 6.827s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
runtime 1.449s ... 1.485s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
runtime 1.440s ... 1.556s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
runtime 1.434s ... 1.455s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
runtime 1.429s ... 1.460s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
runtime 1.446s ... 1.461s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
runtime 1.450s ... 1.470s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
runtime 1.589s ... 1.709s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
runtime 0.226s ... 0.237s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
runtime 53.920s ... 54.157s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
runtime 0.028s ... 0.026s
nvme/002 (create many subsystems and test discovery) [not run]
runtime 19.715s ...
nvme_trtype=tcp is not supported in this test
nvme/003 (test if we're sending keep-alives to a discovery controller) [passed]
runtime 10.095s ... 10.110s
nvme/004 (test nvme and nvmet UUID NS descriptors) [passed]
runtime 1.546s ... 1.158s
nvme/005 (reset local loopback target) [passed]
runtime 6.919s ... 6.211s
nvme/006 (create an NVMeOF target with a block device-backed ns) [passed]
runtime 0.074s ... 0.073s
nvme/007 (create an NVMeOF target with a file-backed ns) [passed]
runtime 0.048s ... 0.049s
nvme/008 (create an NVMeOF host with a block device-backed ns) [passed]
runtime 1.518s ... 1.160s
nvme/009 (create an NVMeOF host with a file-backed ns) [passed]
runtime 1.475s ... 1.152s
nvme/010 (run data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 7.685s ... 15.872s
nvme/011 (run data verification fio job on NVMeOF file-backed ns) [passed]
runtime 78.689s ... 67.854s
nvme/012 (run mkfs and data verification fio job on NVMeOF block device-backed ns) [passed]
runtime 12.459s ... 20.635s
nvme/013 (run mkfs and data verification fio job on NVMeOF file-backed ns) [passed]
runtime 79.450s ... 73.919s
nvme/014 (flush a NVMeOF block device-backed ns) [passed]
runtime 9.759s ... 8.695s
nvme/015 (unit test for NVMe flush for file backed ns) [passed]
runtime 8.870s ... 8.553s
nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [not run]
runtime 15.775s ...
nvme_trtype=tcp is not supported in this test
nvme/017 (create/delete many file-ns and test discovery) [not run]
runtime 13.533s ...
nvme_trtype=tcp is not supported in this test
nvme/018 (unit test NVMe-oF out of range access on a file backend) [passed]
runtime 1.490s ... 1.144s
nvme/019 (test NVMe DSM Discard command on NVMeOF block-device ns) [passed]
runtime 1.470s ... 1.159s
nvme/020 (test NVMe DSM Discard command on NVMeOF file-backed ns) [passed]
runtime 1.467s ... 1.136s
nvme/021 (test NVMe list command on NVMeOF file-backed ns) [passed]
runtime 1.461s ... 1.133s
nvme/022 (test NVMe reset command on NVMeOF file-backed ns) [passed]
runtime 6.827s ... 6.162s
nvme/023 (test NVMe smart-log command on NVMeOF block-device ns) [passed]
runtime 1.485s ... 1.164s
nvme/024 (test NVMe smart-log command on NVMeOF file-backed ns) [passed]
runtime 1.556s ... 1.130s
nvme/025 (test NVMe effects-log command on NVMeOF file-backed ns) [passed]
runtime 1.455s ... 1.141s
nvme/026 (test NVMe ns-descs command on NVMeOF file-backed ns) [passed]
runtime 1.460s ... 1.137s
nvme/027 (test NVMe ns-rescan command on NVMeOF file-backed ns) [passed]
runtime 1.461s ... 1.143s
nvme/028 (test NVMe list-subsys command on NVMeOF file-backed ns) [passed]
runtime 1.470s ... 1.138s
nvme/029 (test userspace IO via nvme-cli read/write interface) [passed]
runtime 1.709s ... 1.271s
nvme/030 (ensure the discovery generation counter is updated appropriately) [passed]
runtime 0.237s ... 0.146s
nvme/031 (test deletion of NVMeOF controllers immediately after setup) [passed]
runtime 54.157s ... 50.809s
nvme/038 (test deletion of NVMeOF subsystem without enabling) [passed]
runtime 0.026s ... 0.029s
blktests (master) #
--
2.29.0
next reply other threads:[~2023-03-27 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 6:04 Chaitanya Kulkarni [this message]
2023-03-27 6:04 ` [PATCH V2 1/8] nvme-core: remove unnecessary else Chaitanya Kulkarni
2023-03-28 0:40 ` Christoph Hellwig
2023-03-27 6:04 ` [PATCH V2 2/8] nvme-core: remvoe extra line at end of function Chaitanya Kulkarni
2023-03-27 6:04 ` [PATCH V2 3/8] nvme-core: code cleanup for __nvme_check_ready() Chaitanya Kulkarni
2023-03-27 11:15 ` Pankaj Raghav
2023-03-27 6:04 ` [PATCH V2 4/8] nvme-core: use normal pattern Chaitanya Kulkarni
2023-03-28 0:42 ` Christoph Hellwig
2023-03-27 6:04 ` [PATCH V2 5/8] nvme-core: open code nvme_delete_ctrl_sync() Chaitanya Kulkarni
2023-03-27 6:04 ` [PATCH V2 6/8] nvme-core: cleanup for nvme_set_latency_tolerance Chaitanya Kulkarni
2023-03-27 6:04 ` [PATCH V2 7/8] nvme-core: remove unneacessary else Chaitanya Kulkarni
2023-03-27 6:04 ` [PATCH V2 8/8] nvme-core: fix nvme_submit_sync_cmd() args Chaitanya Kulkarni
2023-03-28 0:43 ` Christoph Hellwig
2023-03-28 5:46 ` Chaitanya Kulkarni
2023-03-28 6:12 ` [PATCH V2 0/8] nvme-core: trivial cleanups Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327060418.86655-1-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.