All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom
Date: Mon, 27 Mar 2023 10:18:02 -0500	[thread overview]
Message-ID: <20230327151802.GA3485600-robh@kernel.org> (raw)
In-Reply-To: <5993d93e-f57b-51aa-85a3-f58ca0cf846d@linux.ibm.com>

On Tue, Mar 21, 2023 at 10:55:43AM -0500, Eddie James wrote:
> 
> On 3/21/23 10:46, Eddie James wrote:
> > 
> > On 3/21/23 10:19, Krzysztof Kozlowski wrote:
> > > On 21/03/2023 16:16, Eddie James wrote:
> > > > The AT30TSE is compatible with the JEDEC EE1004 standard. Document it
> > > > as a trivial I2C device.
> > > > 
> > > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > > Use subject prefixes matching the subsystem (which you can get for
> > > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > > your patch is touching).
> > 
> > 
> > Oops, sorry, will fix.
> > 
> > 
> > > 
> > > > ---
> > > > ? Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > > ? 1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > index 6f482a254a1d..43e26c73a95f 100644
> > > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > @@ -47,6 +47,8 @@ properties:
> > > > ??????????? - ams,iaq-core
> > > > ????????????? # i2c serial eeprom (24cxx)
> > > > ??????????? - at,24c08
> > > > +??????????? # i2c serial eeprom (EE1004 standard)
> > > AT30TSE?
> > > 
> > > > +????????? - atmel,at30tse
> > > Microchip does not find anything on AT30TSE. Are you sure this is the
> > > model name?
> > 
> > 
> > Yes: https://www.microchip.com/content/dam/mchp/documents/OTH/ProductDocuments/DataSheets/Atmel-8868-DTS-AT30TSE004A-Datasheet.pdf
> > 
> > 
> > Maybe it's actually an 8868? Or should I include the 004A as well?
> 
> 
> I found some other AT30TSE (AT30TSE752A for example) devices that do not
> appear compatible with the EE1004 standard, so I will include the full model
> number.

If this standard is sufficiently complete, then you might want a EE1004 
fallback compatible. Complete would mean power supply(ies) and any extra 
i/o are defined and the exact device model is discoverable.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	arnd@arndb.de, linux-aspeed@lists.ozlabs.org,
	gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom
Date: Mon, 27 Mar 2023 10:18:02 -0500	[thread overview]
Message-ID: <20230327151802.GA3485600-robh@kernel.org> (raw)
In-Reply-To: <5993d93e-f57b-51aa-85a3-f58ca0cf846d@linux.ibm.com>

On Tue, Mar 21, 2023 at 10:55:43AM -0500, Eddie James wrote:
> 
> On 3/21/23 10:46, Eddie James wrote:
> > 
> > On 3/21/23 10:19, Krzysztof Kozlowski wrote:
> > > On 21/03/2023 16:16, Eddie James wrote:
> > > > The AT30TSE is compatible with the JEDEC EE1004 standard. Document it
> > > > as a trivial I2C device.
> > > > 
> > > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > > Use subject prefixes matching the subsystem (which you can get for
> > > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > > your patch is touching).
> > 
> > 
> > Oops, sorry, will fix.
> > 
> > 
> > > 
> > > > ---
> > > >   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > > >   1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > index 6f482a254a1d..43e26c73a95f 100644
> > > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > > @@ -47,6 +47,8 @@ properties:
> > > >             - ams,iaq-core
> > > >               # i2c serial eeprom (24cxx)
> > > >             - at,24c08
> > > > +            # i2c serial eeprom (EE1004 standard)
> > > AT30TSE?
> > > 
> > > > +          - atmel,at30tse
> > > Microchip does not find anything on AT30TSE. Are you sure this is the
> > > model name?
> > 
> > 
> > Yes: https://www.microchip.com/content/dam/mchp/documents/OTH/ProductDocuments/DataSheets/Atmel-8868-DTS-AT30TSE004A-Datasheet.pdf
> > 
> > 
> > Maybe it's actually an 8868? Or should I include the 004A as well?
> 
> 
> I found some other AT30TSE (AT30TSE752A for example) devices that do not
> appear compatible with the EE1004 standard, so I will include the full model
> number.

If this standard is sufficiently complete, then you might want a EE1004 
fallback compatible. Complete would mean power supply(ies) and any extra 
i/o are defined and the exact device model is discoverable.

Rob

  reply	other threads:[~2023-03-27 15:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 15:16 [PATCH v2 0/4] eeprom: ee1004: Enable devices on multiple busses Eddie James
2023-03-21 15:16 ` Eddie James
2023-03-21 15:16 ` [PATCH v2 1/4] " Eddie James
2023-03-21 15:16   ` Eddie James
2023-03-21 15:39   ` Rob Herring
2023-03-21 15:39     ` Rob Herring
2023-03-21 15:45     ` Eddie James
2023-03-21 15:45       ` Eddie James
2023-03-21 15:16 ` [PATCH v2 2/4] doc: Add Atmel AT30TSE serial eeprom Eddie James
2023-03-21 15:16   ` Eddie James
2023-03-21 15:19   ` Krzysztof Kozlowski
2023-03-21 15:19     ` Krzysztof Kozlowski
2023-03-21 15:46     ` Eddie James
2023-03-21 15:46       ` Eddie James
2023-03-21 15:55       ` Eddie James
2023-03-21 15:55         ` Eddie James
2023-03-27 15:18         ` Rob Herring [this message]
2023-03-27 15:18           ` Rob Herring
2023-03-27 19:01           ` Eddie James
2023-03-27 19:01             ` Eddie James
2023-03-21 15:16 ` [PATCH v2 3/4] eeprom: ee1004: Add devicetree binding Eddie James
2023-03-21 15:16   ` Eddie James
2023-03-21 15:20   ` Krzysztof Kozlowski
2023-03-21 15:20     ` Krzysztof Kozlowski
2023-03-21 15:16 ` [PATCH v2 4/4] ARM: dts: aspeed: bonnell: Add DIMM SPD Eddie James
2023-03-21 15:16   ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230327151802.GA3485600-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.