From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23137C761A6 for ; Tue, 28 Mar 2023 02:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6G2DYg8ELtbcds+HAzH8fVD7RX7HwcvzaOlUuI7kips=; b=M4hWxM44v+xQmV ERKUpjTkOCi/56zlNgLfAm9+Vj9ADGa6CWwwBlsApUe7Y4466PzcP+aYT1F91xJ4tPEJK3rxgsh9B z5DGdUUn47J0HXnMirxJ22ZdOy0KzZcw19RdijcGkbT9NQq+1WllLiEpJz9Q0USFEWdEK8gDh+d/a 1f0IamgUNKxf71Ewvd3xr+5cGBGyS5TsZQpg3fP3hsPIAoKpad40dcMAdU8jIUan8S3BtClZXg4FP ei0zJTeaIv86iqNy2n5yKylpqU5SoKW152wU2GMXOq44mUrnwEpyJkoGdHIxoGbF++EujBDMCmAtF g4CaGZu5ll8VTg5fUCtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgygb-00Cr4a-0C; Tue, 28 Mar 2023 02:03:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgygU-00Cr39-1I; Tue, 28 Mar 2023 02:03:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94FB561551; Tue, 28 Mar 2023 02:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07F85C433EF; Tue, 28 Mar 2023 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679969017; bh=6G2DYg8ELtbcds+HAzH8fVD7RX7HwcvzaOlUuI7kips=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OX6ScXGO6/rjGImEN7aRNFH3B2f7/2aBDNXKhKfqDPgJg+3VrxOY0NG5rJoxK7ZxW vVrYX2UbNF+502CXMPlTSLm933frp+X7XJ4XMlhHEMy4rbnzuB6VnzJzwJ8OKepnZb gZED4ue40ZcVTlTiGjd1ywtJmGLf4kLtONmtVNYhA2s1Oyu6hqVrnOvUnPbmj0dTP2 cLumXnQh7MfGEyYmwbrdasOJqtI7NRc72ycgdgqq41PkEgVQZhI3j97prLV9X/5kak JXBkGLfpdYCADfJwaN4+XfwuKVKkq0ai8OyHm8Uvh8vta/obJBc7XSLjSgabAT/1oy ughYp2bWCDqlA== Date: Mon, 27 Mar 2023 19:03:34 -0700 From: Jakub Kicinski To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= Subject: Re: [PATCH net 4/7] net: dsa: mt7530: set both CPU port interfaces to PHY_INTERFACE_MODE_NA Message-ID: <20230327190334.6c5bcf87@kernel.org> In-Reply-To: <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> References: <20230326140818.246575-1-arinc.unal@arinc9.com> <20230326140818.246575-5-arinc.unal@arinc9.com> <20230327191242.4qabzrn3vtx3l2a7@skbuf> <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_190338_482168_9D1DCAE0 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ilya Lipnitskiy , =?UTF-8?B?UmVuw6k=?= van Dorst , Eric Dumazet , erkin.bozoglu@xeront.com, Florian Fainelli , Russell King , Richard van Schagen , Paolo Abeni , Landen Chao , Richard van Schagen , Sean Wang , DENG Qingfang , Russell King , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Oltean , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 28 Mar 2023 00:57:57 +0300 Ar=C4=B1n=C3=A7 =C3=9CNAL wrote: > I don't appreciate your consistent use of the word "abuse" on my=20 > patches. I'm by no means a senior C programmer. I'm doing my best to=20 > correct the driver. >=20 > Thank you for explaining the process of phylink with DSA, I will adjust=20 > my patches accordingly. >=20 > I suggest you don't take my patches seriously for a while, until I know=20 > better. Maybe my bad, I should have sent you a note on your previous series already. The patches may be fine, but the commit messages need to do a better job of describing what the goal of the change is, functionally. For fixes the bar is even higher because, as Vladimir points out, commit messages for fixes need to explain what user visible problem=20 the patch is resolving. Think of it as a letter to a person using the switch who hits a problem and wants to look thru the upstream commits to see if it's already fixed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA1DEC6FD1D for ; Tue, 28 Mar 2023 02:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8AqgFJdfn6MIASqK9XHoutmAVxmcK3chd5qXysbJZhk=; b=wQ1110zHre96Hx /sfOn8IJEEfRHQc4DuTuMxRDmdZiORZLA24Evyab8pScnrWyG8JLVofcic9XTK14nAgx7E/rSORaJ Y78VrK9kDbwVBiTqdiVm2yRJHpT6ICfX7BfhKD4zj+iHhtDK3fbrlXLRrM2Lf4Byjr2ebLuvUa2/O iXbo1P9QD+vRjd7oNGrZxGC451A8RpVTQCpI20G5+05gH8PBh9YL6e99FFrq5nqZXlxCDpRa6+pPT 7pFKe4P56Z6CDZ8tzYl4eln/spN2ggSsWEQc/xqYI1vF37YuQj7vdaz0HKkTqYSt0EKXfvaB43gmm 16k2lq2d2SnwJvfZwsJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgyga-00Cr4D-0d; Tue, 28 Mar 2023 02:03:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgygU-00Cr39-1I; Tue, 28 Mar 2023 02:03:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94FB561551; Tue, 28 Mar 2023 02:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07F85C433EF; Tue, 28 Mar 2023 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679969017; bh=6G2DYg8ELtbcds+HAzH8fVD7RX7HwcvzaOlUuI7kips=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OX6ScXGO6/rjGImEN7aRNFH3B2f7/2aBDNXKhKfqDPgJg+3VrxOY0NG5rJoxK7ZxW vVrYX2UbNF+502CXMPlTSLm933frp+X7XJ4XMlhHEMy4rbnzuB6VnzJzwJ8OKepnZb gZED4ue40ZcVTlTiGjd1ywtJmGLf4kLtONmtVNYhA2s1Oyu6hqVrnOvUnPbmj0dTP2 cLumXnQh7MfGEyYmwbrdasOJqtI7NRc72ycgdgqq41PkEgVQZhI3j97prLV9X/5kak JXBkGLfpdYCADfJwaN4+XfwuKVKkq0ai8OyHm8Uvh8vta/obJBc7XSLjSgabAT/1oy ughYp2bWCDqlA== Date: Mon, 27 Mar 2023 19:03:34 -0700 From: Jakub Kicinski To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Vladimir Oltean , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?UTF-8?B?UmVuw6k=?= van Dorst , Russell King , Ilya Lipnitskiy , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net 4/7] net: dsa: mt7530: set both CPU port interfaces to PHY_INTERFACE_MODE_NA Message-ID: <20230327190334.6c5bcf87@kernel.org> In-Reply-To: <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> References: <20230326140818.246575-1-arinc.unal@arinc9.com> <20230326140818.246575-5-arinc.unal@arinc9.com> <20230327191242.4qabzrn3vtx3l2a7@skbuf> <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_190338_482168_9D1DCAE0 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOCBNYXIgMjAyMyAwMDo1Nzo1NyArMDMwMCBBcsSxbsOnIMOcTkFMIHdyb3RlOgo+ IEkgZG9uJ3QgYXBwcmVjaWF0ZSB5b3VyIGNvbnNpc3RlbnQgdXNlIG9mIHRoZSB3b3JkICJhYnVz ZSIgb24gbXkgCj4gcGF0Y2hlcy4gSSdtIGJ5IG5vIG1lYW5zIGEgc2VuaW9yIEMgcHJvZ3JhbW1l ci4gSSdtIGRvaW5nIG15IGJlc3QgdG8gCj4gY29ycmVjdCB0aGUgZHJpdmVyLgo+IAo+IFRoYW5r IHlvdSBmb3IgZXhwbGFpbmluZyB0aGUgcHJvY2VzcyBvZiBwaHlsaW5rIHdpdGggRFNBLCBJIHdp bGwgYWRqdXN0IAo+IG15IHBhdGNoZXMgYWNjb3JkaW5nbHkuCj4gCj4gSSBzdWdnZXN0IHlvdSBk b24ndCB0YWtlIG15IHBhdGNoZXMgc2VyaW91c2x5IGZvciBhIHdoaWxlLCB1bnRpbCBJIGtub3cg Cj4gYmV0dGVyLgoKTWF5YmUgbXkgYmFkLCBJIHNob3VsZCBoYXZlIHNlbnQgeW91IGEgbm90ZSBv biB5b3VyIHByZXZpb3VzIHNlcmllcwphbHJlYWR5LiBUaGUgcGF0Y2hlcyBtYXkgYmUgZmluZSwg YnV0IHRoZSBjb21taXQgbWVzc2FnZXMgbmVlZCB0byBkbwphIGJldHRlciBqb2Igb2YgZGVzY3Jp YmluZyB3aGF0IHRoZSBnb2FsIG9mIHRoZSBjaGFuZ2UgaXMsIGZ1bmN0aW9uYWxseS4KCkZvciBm aXhlcyB0aGUgYmFyIGlzIGV2ZW4gaGlnaGVyIGJlY2F1c2UsIGFzIFZsYWRpbWlyIHBvaW50cyBv dXQsCmNvbW1pdCBtZXNzYWdlcyBmb3IgZml4ZXMgbmVlZCB0byBleHBsYWluIHdoYXQgdXNlciB2 aXNpYmxlIHByb2JsZW0gCnRoZSBwYXRjaCBpcyByZXNvbHZpbmcuIFRoaW5rIG9mIGl0IGFzIGEg bGV0dGVyIHRvIGEgcGVyc29uIHVzaW5nIHRoZQpzd2l0Y2ggd2hvIGhpdHMgYSBwcm9ibGVtIGFu ZCB3YW50cyB0byBsb29rIHRocnUgdGhlIHVwc3RyZWFtIGNvbW1pdHMKdG8gc2VlIGlmIGl0J3Mg YWxyZWFkeSBmaXhlZC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CC4C761A6 for ; Tue, 28 Mar 2023 02:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232206AbjC1CDk (ORCPT ); Mon, 27 Mar 2023 22:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjC1CDi (ORCPT ); Mon, 27 Mar 2023 22:03:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DBD82685; Mon, 27 Mar 2023 19:03:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97DBC6156F; Tue, 28 Mar 2023 02:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07F85C433EF; Tue, 28 Mar 2023 02:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679969017; bh=6G2DYg8ELtbcds+HAzH8fVD7RX7HwcvzaOlUuI7kips=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OX6ScXGO6/rjGImEN7aRNFH3B2f7/2aBDNXKhKfqDPgJg+3VrxOY0NG5rJoxK7ZxW vVrYX2UbNF+502CXMPlTSLm933frp+X7XJ4XMlhHEMy4rbnzuB6VnzJzwJ8OKepnZb gZED4ue40ZcVTlTiGjd1ywtJmGLf4kLtONmtVNYhA2s1Oyu6hqVrnOvUnPbmj0dTP2 cLumXnQh7MfGEyYmwbrdasOJqtI7NRc72ycgdgqq41PkEgVQZhI3j97prLV9X/5kak JXBkGLfpdYCADfJwaN4+XfwuKVKkq0ai8OyHm8Uvh8vta/obJBc7XSLjSgabAT/1oy ughYp2bWCDqlA== Date: Mon, 27 Mar 2023 19:03:34 -0700 From: Jakub Kicinski To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Vladimir Oltean , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?UTF-8?B?UmVuw6k=?= van Dorst , Russell King , Ilya Lipnitskiy , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net 4/7] net: dsa: mt7530: set both CPU port interfaces to PHY_INTERFACE_MODE_NA Message-ID: <20230327190334.6c5bcf87@kernel.org> In-Reply-To: <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> References: <20230326140818.246575-1-arinc.unal@arinc9.com> <20230326140818.246575-5-arinc.unal@arinc9.com> <20230327191242.4qabzrn3vtx3l2a7@skbuf> <8450084e-1474-17fa-32c2-a4653b74ff17@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Mar 2023 00:57:57 +0300 Ar=C4=B1n=C3=A7 =C3=9CNAL wrote: > I don't appreciate your consistent use of the word "abuse" on my=20 > patches. I'm by no means a senior C programmer. I'm doing my best to=20 > correct the driver. >=20 > Thank you for explaining the process of phylink with DSA, I will adjust=20 > my patches accordingly. >=20 > I suggest you don't take my patches seriously for a while, until I know=20 > better. Maybe my bad, I should have sent you a note on your previous series already. The patches may be fine, but the commit messages need to do a better job of describing what the goal of the change is, functionally. For fixes the bar is even higher because, as Vladimir points out, commit messages for fixes need to explain what user visible problem=20 the patch is resolving. Think of it as a letter to a person using the switch who hits a problem and wants to look thru the upstream commits to see if it's already fixed.