All of lore.kernel.org
 help / color / mirror / Atom feed
* + kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags.patch added to mm-unstable branch
@ 2023-03-27 20:19 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-03-27 20:19 UTC (permalink / raw)
  To: mm-commits, glider, elver, dvyukov, thunder.leizhen, akpm


The patch titled
     Subject: kmsan: fix a stale comment in kmsan_save_stack_with_flags()
has been added to the -mm mm-unstable branch.  Its filename is
     kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Zhen Lei <thunder.leizhen@huawei.com>
Subject: kmsan: fix a stale comment in kmsan_save_stack_with_flags()
Date: Mon, 27 Mar 2023 11:41:49 +0800

After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and commit
84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
__alloc_pages_nodemask"), the comment is no longer accurate.  Flag
'__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the comment
rather than update it.

Link: https://lkml.kernel.org/r/20230327034149.942-1-thunder.leizhen@huawei.com
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Marco Elver <elver@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/kmsan/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/kmsan/core.c~kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags
+++ a/mm/kmsan/core.c
@@ -73,7 +73,7 @@ depot_stack_handle_t kmsan_save_stack_wi
 
 	nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);
 
-	/* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
+	/* Don't sleep. */
 	flags &= ~__GFP_DIRECT_RECLAIM;
 
 	handle = __stack_depot_save(entries, nr_entries, flags, true);
_

Patches currently in -mm which might be from thunder.leizhen@huawei.com are

kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-27 20:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-27 20:19 + kmsan-fix-a-stale-comment-in-kmsan_save_stack_with_flags.patch added to mm-unstable branch Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.