From: Christoph Hellwig <hch@lst.de>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: linux-nvme@lists.infradead.org, p.raghav@samsung.com,
kbusch@kernel.org, hch@lst.de, sagi@grimberg.me
Subject: Re: [RFC v2 3/3] nvme: ignore starting sector while error logging for passthrough requests
Date: Tue, 28 Mar 2023 02:55:29 +0200 [thread overview]
Message-ID: <20230328005529.GA21497@lst.de> (raw)
In-Reply-To: <20230323230316.2914077-4-alan.adamson@oracle.com>
Yikes, no. Anything that needs to poke into details of passthrough
commands is fundamentally wrong. Maybe we need a separate log
message for passthrough that is just based on the cdw values instead
of trying to decode it.
next prev parent reply other threads:[~2023-03-28 0:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 23:03 [RFC v2 0/3] nvme: add passthrough error logging opt-in Alan Adamson
2023-03-23 23:03 ` [RFC v2 1/3] nvme: move fault injector to nvme-debugfs.c Alan Adamson
2023-03-27 11:08 ` Pankaj Raghav
2023-03-28 0:56 ` Christoph Hellwig
2023-03-28 8:53 ` Sagi Grimberg
2023-03-23 23:03 ` [RFC v2 2/3] nvme: add error logging opt-in Alan Adamson
2023-03-28 0:57 ` Christoph Hellwig
2023-03-28 8:56 ` Sagi Grimberg
2023-03-28 20:45 ` alan.adamson
2023-03-29 6:37 ` Sagi Grimberg
2023-03-29 16:08 ` alan.adamson
2023-03-30 13:38 ` Sagi Grimberg
2023-03-30 16:24 ` alan.adamson
2023-03-23 23:03 ` [RFC v2 3/3] nvme: ignore starting sector while error logging for passthrough requests Alan Adamson
2023-03-28 0:55 ` Christoph Hellwig [this message]
2023-03-28 8:56 ` Sagi Grimberg
2023-03-28 20:39 ` alan.adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328005529.GA21497@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.