From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it, paulson <lpaulsonraja@gmail.com>
Subject: Re: [LTP] [PATCH] Added test for mmap() with MAP_SHARED_VALIDATE.
Date: Tue, 28 Mar 2023 10:11:33 +0200 [thread overview]
Message-ID: <20230328081133.GA743322@pevik> (raw)
In-Reply-To: <CAEemH2eTt9P2FWhsS2VASCbLwcOvV4ESrRKLuxWS7HwTNGjSrQ@mail.gmail.com>
...
> > FYI we have various helpers in include/tst_test_macros.h, e.g. TST_EXP_FAIL()
> > for expected failures where return is just classical syscalls result
> > (0 for pass, -1 for error) or TST_EXP_FD() for file descriptors.
> > But these cannot be used here, because mmap returns pointer to void.
> > We might want to write helpers which use TEST_VOID() instead of TEST(),
> > after tests for mmap() are rewritten to new API, they could use it.
> Sounds good, but we can do this in later refactoring work on mmap tests.
> Now I'm slightly OK with not using TEST_ macros for everything:).
Sure (it will not block this effort, definitely for separate effort with low
priority).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-03-28 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 12:13 [LTP] [PATCH] Added test for mmap() with MAP_SHARED_VALIDATE paulson
2023-03-24 10:33 ` Petr Vorel
2023-03-25 4:01 ` Paulson Raja L
2023-03-27 10:21 ` Petr Vorel
2023-03-28 3:14 ` Li Wang
2023-03-28 8:17 ` Petr Vorel
2023-03-28 8:30 ` Li Wang
2023-03-28 10:39 ` Petr Vorel
2023-04-04 11:07 ` Petr Vorel
2023-04-04 11:15 ` Petr Vorel
2023-03-27 10:51 ` Petr Vorel
2023-03-28 3:39 ` Li Wang
2023-03-28 8:11 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328081133.GA743322@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=lpaulsonraja@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.