From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <simon.horman@corigine.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH net-next 01/11] can: rcar_canfd: Add transceiver support
Date: Tue, 28 Mar 2023 14:56:58 -0700 [thread overview]
Message-ID: <20230328145658.7fdbc394@kernel.org> (raw)
In-Reply-To: <20230327073354.1003134-2-mkl@pengutronix.de>
On Mon, 27 Mar 2023 09:33:44 +0200 Marc Kleine-Budde wrote:
> @@ -1836,6 +1849,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch)
>
> static int rcar_canfd_probe(struct platform_device *pdev)
> {
> + struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, };
> const struct rcar_canfd_hw_info *info;
> struct device *dev = &pdev->dev;
> void __iomem *addr;
[somehow this got stuck in my outgoing mail]
drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer
Could you follow up with a fix fix?
next prev parent reply other threads:[~2023-03-28 21:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 7:33 [PATCH net-next 0/11] pull-request: can-next 2023-03-27 Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 01/11] can: rcar_canfd: Add transceiver support Marc Kleine-Budde
2023-03-28 3:10 ` patchwork-bot+netdevbpf
2023-03-28 21:56 ` Jakub Kicinski [this message]
2023-03-29 6:42 ` Geert Uytterhoeven
2023-03-27 7:33 ` [PATCH net-next 02/11] can: rcar_canfd: Improve error messages Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 03/11] can: c_can: Remove redundant pci_clear_master Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 04/11] can: ctucanfd: " Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 05/11] can: kvaser_pciefd: " Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 06/11] can: esd_usb: Improve code readability by means of replacing struct esd_usb_msg with a union Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 07/11] can: m_can: Remove repeated check for is_peripheral Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 08/11] can: m_can: Always acknowledge all interrupts Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 09/11] can: m_can: Remove double interrupt enable Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 10/11] can: m_can: Disable unused interrupts Marc Kleine-Budde
2023-03-27 7:33 ` [PATCH net-next 11/11] can: m_can: Keep interrupts enabled during peripheral read Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328145658.7fdbc394@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.