From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Coiby Xu <Coiby.Xu@gmail.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH for-8.0] block/export: fix assume_graph_lock() assertion failure
Date: Tue, 28 Mar 2023 11:09:08 -0400 [thread overview]
Message-ID: <20230328150908.GA1625749@fedora> (raw)
In-Reply-To: <ZCLdNxESMsE0r92T@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Tue, Mar 28, 2023 at 02:27:35PM +0200, Kevin Wolf wrote:
> Am 27.03.2023 um 23:19 hat Stefan Hajnoczi geschrieben:
> > When I/O request parameters are validated for virtio-blk exports like
> > vhost-user-blk and vduse-blk, we call blk_get_geometry() from a
> > coroutine. This hits an assume_graph_lock() assertion failure.
> >
> > Use blk_co_nb_sectors() instead and mark virtio_blk_sect_range_ok() with
> > coroutine_fn.
> >
> > This assertion failure is triggered by any I/O to a vhost-user-blk
> > export.
> >
> > Fixes: 8ab8140a04cf ("block: Mark bdrv_co_refresh_total_sectors() and callers GRAPH_RDLOCK")
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> This is a duplicate of this fix:
>
> https://patchew.org/QEMU/20230327113959.60071-1-kwolf@redhat.com/
Okay, thanks. Your fix looks good.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-03-28 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 21:19 [PATCH for-8.0] block/export: fix assume_graph_lock() assertion failure Stefan Hajnoczi
2023-03-28 12:27 ` Kevin Wolf
2023-03-28 15:09 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328150908.GA1625749@fedora \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.