From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: brett.creeley@amd.com, davem@davemloft.net,
netdev@vger.kernel.org, drivers@pensando.io, leon@kernel.org,
jiri@resnulli.us
Subject: Re: [PATCH v6 net-next 01/14] pds_core: initial framework for pds_core PF driver
Date: Tue, 28 Mar 2023 15:17:00 -0700 [thread overview]
Message-ID: <20230328151700.526ea042@kernel.org> (raw)
In-Reply-To: <822ec781-ce1e-35ef-d448-a3078f68c04f@amd.com>
On Mon, 27 Mar 2023 23:19:28 -0700 Shannon Nelson wrote:
> > What are you "abstracting away", exactly? Which "later patch"?
> > I'm not going to read the 5k LoC submission to figure out what
> > you're trying to say :(
>
> I'm saying that more code is added in later patches around the
> devlink_register() for the health (patch 4) and parameters (patch 11).
> This allows me to have a simple line in the main probe logic that does
> the devlink-register related things, and then have the details collected
> together off to the side.
It's not supposed to be off to the side, that's my point.
It's a central interface for device control.
> Obviously, when I update the code for using the devl_* interfaces and
> explicit locking, those two patches will change a little.
next prev parent reply other threads:[~2023-03-28 22:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 19:02 [PATCH v6 net-next 00/14] pds_core driver Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 01/14] pds_core: initial framework for pds_core PF driver Shannon Nelson
2023-03-25 23:39 ` Jakub Kicinski
2023-03-26 4:07 ` Shannon Nelson
2023-03-28 0:43 ` Jakub Kicinski
2023-03-28 6:19 ` Shannon Nelson
2023-03-28 22:17 ` Jakub Kicinski [this message]
2023-03-29 20:53 ` Shannon Nelson
2023-03-30 2:27 ` Jakub Kicinski
2023-03-30 7:02 ` Leon Romanovsky
2023-03-30 7:43 ` Shannon Nelson
2023-03-30 16:46 ` Jakub Kicinski
2023-03-24 19:02 ` [PATCH v6 net-next 02/14] pds_core: add devcmd device interfaces Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 03/14] pds_core: health timer and workqueue Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 04/14] pds_core: add devlink health facilities Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 05/14] pds_core: set up device and adminq Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 06/14] pds_core: Add adminq processing and commands Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 07/14] pds_core: add FW update feature to devlink Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 08/14] pds_core: set up the VIF definitions and defaults Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 09/14] pds_core: add initial VF device handling Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 10/14] pds_core: add auxiliary_bus devices Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 11/14] pds_core: devlink params for enabling VIF support Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 12/14] pds_core: add the aux client API Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 13/14] pds_core: publish events to the clients Shannon Nelson
2023-03-24 19:02 ` [PATCH v6 net-next 14/14] pds_core: Kconfig and pds_core.rst Shannon Nelson
2023-03-25 20:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328151700.526ea042@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.