All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: David Woodhouse <dwmw@amazon.co.uk>, Paul Durrant <pdurrant@amazon.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: aio_set_event_notifier(is_external=true) in Xen code?
Date: Tue, 28 Mar 2023 11:50:50 -0400	[thread overview]
Message-ID: <20230328155050.GA1632689@fedora> (raw)

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi,
I'm removing the aio_disable_external() API from QEMU and noticed that
Xen code calls aio_set_fd_handler(is_external=true) in hw/xen/xen-bus.c
and hw/i386/kvm/xen_xenstore.c.

It wasn't clear to me whether is_external=true is necessary here.
is_external=true is mainly used to temporarily pause I/O submission in
the QEMU block layer. Maybe is_external=true was chosen out of caution
but actually has no effect in this code.

Does the Xen code rely on is_external=true?

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2023-03-28 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 15:50 Stefan Hajnoczi [this message]
2023-03-28 16:36 ` aio_set_event_notifier(is_external=true) in Xen code? Durrant, Paul
2023-03-28 18:10   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328155050.GA1632689@fedora \
    --to=stefanha@redhat.com \
    --cc=dwmw@amazon.co.uk \
    --cc=pdurrant@amazon.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.