From: Eric DeVolder <eric.devolder@oracle.com>
To: shannon.zhaosl@gmail.com, mst@redhat.com, imammedo@redhat.com,
ani@anisinha.ca, peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, marcel.apfelbaum@gmail.com,
pbonzini@redhat.com, richard.henderson@linaro.org,
eduardo@habkost.net
Cc: boris.ostrovsky@oracle.com, eric.devolder@oracle.com
Subject: [PATCH 1/2] hw/acpi: arm: bump MADT to revision 5
Date: Tue, 28 Mar 2023 11:59:25 -0400 [thread overview]
Message-ID: <20230328155926.2277-2-eric.devolder@oracle.com> (raw)
In-Reply-To: <20230328155926.2277-1-eric.devolder@oracle.com>
Currently ARM QEMU generates, and reports, MADT revision 4. ACPI 6.3
introduces MADT revision 5.
For MADT revision 5, the GICC structure adds an SPE Overflow Interrupt
field. This new 2-byte field is created from the existing 3-byte
Reserved field. The spec indicates if the SPE overflow interrupt is
not supported, to zero the field.
Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
---
hw/arm/virt-acpi-build.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 4156111d49..23268dd981 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -705,7 +705,7 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
int i;
VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
const MemMapEntry *memmap = vms->memmap;
- AcpiTable table = { .sig = "APIC", .rev = 4, .oem_id = vms->oem_id,
+ AcpiTable table = { .sig = "APIC", .rev = 5, .oem_id = vms->oem_id,
.oem_table_id = vms->oem_table_id };
acpi_table_begin(&table, table_data);
@@ -763,7 +763,9 @@ build_madt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
/* Processor Power Efficiency Class */
build_append_int_noprefix(table_data, 0, 1);
/* Reserved */
- build_append_int_noprefix(table_data, 0, 3);
+ build_append_int_noprefix(table_data, 0, 1);
+ /* SPE overflow Interrupt */
+ build_append_int_noprefix(table_data, 0, 2);
}
if (vms->gic_version != VIRT_GIC_VERSION_2) {
--
2.31.1
next prev parent reply other threads:[~2023-03-28 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 15:59 [PATCH 0/2] hw/acpi: bump MADT to revision 5 Eric DeVolder
2023-03-28 15:59 ` Eric DeVolder [this message]
2023-04-11 14:49 ` [PATCH 1/2] hw/acpi: arm: " Igor Mammedov
2023-03-28 15:59 ` [PATCH 2/2] hw/acpi: i386: " Eric DeVolder
2023-03-29 5:03 ` Michael S. Tsirkin
2023-03-29 13:16 ` Eric DeVolder
2023-03-29 13:19 ` Eric DeVolder
2023-03-29 16:55 ` Michael S. Tsirkin
2023-03-31 16:29 ` Igor Mammedov
2023-04-11 16:00 ` Igor Mammedov
2023-04-12 7:58 ` Igor Mammedov
2023-04-18 16:58 ` Eric DeVolder
2023-03-28 16:37 ` [PATCH 0/2] hw/acpi: " Eric DeVolder
2023-03-29 5:19 ` Michael S. Tsirkin
2023-03-29 13:14 ` Eric DeVolder
2023-03-29 16:47 ` Michael S. Tsirkin
2023-03-30 7:36 ` Ani Sinha
2023-03-30 13:44 ` Michael S. Tsirkin
2023-03-30 14:02 ` Ani Sinha
2023-03-30 14:11 ` Michael S. Tsirkin
2023-03-31 16:25 ` Igor Mammedov
2023-04-04 14:52 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328155926.2277-2-eric.devolder@oracle.com \
--to=eric.devolder@oracle.com \
--cc=ani@anisinha.ca \
--cc=boris.ostrovsky@oracle.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.