From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Remove ltp_clone_quick usage from pidns suite
Date: Wed, 29 Mar 2023 07:33:24 +0200 [thread overview]
Message-ID: <20230329053324.GA807387@pevik> (raw)
In-Reply-To: <877cvl6jw9.fsf@suse.de>
Hi all,
> > static void run(void)
> > {
> > - int ret;
> > + const struct tst_clone_args args = { CLONE_NEWNS, SIGCHLD };
> At some point CLONE_NEWNS was substituted for CLONE_NEWPID. It still
> passes because TST_EXP_PASS expects a zero return val. It should be
> TST_EXP_EXPR or similar.
Good catch. I suppose copy paste error. These were introduced during testsuite
rewrite, later Andrea fixed the docparse description in 3fc912172, but not the
actual value in tst_clone_args.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-03-29 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 12:43 [LTP] [PATCH v1] Remove ltp_clone_quick usage from pidns suite Andrea Cervesato via ltp
2023-03-13 10:04 ` Richard Palethorpe
2023-03-29 5:33 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329053324.GA807387@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.