From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1D1C74A5B for ; Wed, 29 Mar 2023 07:24:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbjC2HYI (ORCPT ); Wed, 29 Mar 2023 03:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbjC2HXu (ORCPT ); Wed, 29 Mar 2023 03:23:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEE483AB8 for ; Wed, 29 Mar 2023 00:23:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A1C461A4F for ; Wed, 29 Mar 2023 07:23:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40CBBC4339B; Wed, 29 Mar 2023 07:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680074623; bh=YpXZD7wouBKyLJ94ohtW5dFZZXReAJU908gcsRQxZfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oi59h7dZnkShH0B9LThWHjV/qeg3L4P8x8SlQhKXtY2MV/V85LGpbwAUGKWp05wx7 EMJxNKMIWHHzABUbawWLka4V3odHM/yeAMuC2qQ93wFtfQr1T1UmAh9GZZ/x8AokLH kFGtt0q3o9fQh+sgl33cZmFw+zDWIrbpJGiI4MwzVa7xBU3Q/GS9xWsVBiGkQ9eW6s mB4TZpaNdVvx+QPnVIImidpLq+QrOfXK9FbcEPraMzOc4iCia252qpiYSkwd7gaT6E 0HzQmnZZVAPdqn2HkLjQXuc8+nglE1qs6p6ruYrfYpKrFLCZCpEHkgpk5CDLjI6lXr XLHnbqND4dT7A== Date: Wed, 29 Mar 2023 10:23:39 +0300 From: Leon Romanovsky To: Selvin Xavier Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com Subject: Re: [PATCH for-next 7/7] RDMA/bnxt_re: Enable congestion control by default Message-ID: <20230329072339.GD831478@unreal> References: <1679562739-24472-1-git-send-email-selvin.xavier@broadcom.com> <1679562739-24472-8-git-send-email-selvin.xavier@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1679562739-24472-8-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Mar 23, 2023 at 02:12:19AM -0700, Selvin Xavier wrote: > Enable Congesion control by default. Issue FW command > enable the CC during driver load and disable it during > unload. > > Signed-off-by: Selvin Xavier > --- > drivers/infiniband/hw/bnxt_re/main.c | 24 ++++++- > drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 15 ++-- > drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 20 ++++-- > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 109 +++++++++++++++++++++++++++++ > drivers/infiniband/hw/bnxt_re/qplib_sp.h | 67 ++++++++++++++++++ > 5 files changed, 222 insertions(+), 13 deletions(-) <...> > index 06979f7..73f936c 100644 > --- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c > +++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c > @@ -96,7 +96,7 @@ static int __send_message(struct bnxt_qplib_rcfw *rcfw, > u32 sw_prod, cmdq_prod; > struct pci_dev *pdev; > unsigned long flags; > - u32 size, opcode; > + u32 bsize, opcode; > u16 cookie, cbit; > u8 *preq; <...> > memset(msg->resp, 0, sizeof(*msg->resp)); > crsqe->resp = (struct creq_qp_event *)msg->resp; > - crsqe->resp->cookie = msg->req->cookie; > + crsqe->resp->cookie = cookie; I see that you didn't change cookie type in this patch, but it is better to fix smatch/sparse warnings while you are changing the code. I don't want to see any warnings generated by new patches even for old code. drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:155:29: warning: incorrect type in assignment (different base types) drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:155:29: expected restricted __le16 [usertype] cookie drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:155:29: got unsigned short [assigned] [usertype] cookie drivers/infiniband/hw/bnxt_re/qplib_rcfw.h:96:13: warning: restricted __le16 degrades to integer Thanks