From: Yixin Shen <bobankhshen@gmail.com>
To: bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@kernel.org, song@kernel.org, yhs@fb.com,
bobankhshen@gmail.com
Subject: [PATCH bpf-next v2 1/2] bpf: allow a TCP CC to write app_limited
Date: Wed, 29 Mar 2023 07:35:57 +0000 [thread overview]
Message-ID: <20230329073558.8136-2-bobankhshen@gmail.com> (raw)
In-Reply-To: <20230329073558.8136-1-bobankhshen@gmail.com>
A CC that implements tcp_congestion_ops.cong_control() should be able to
write app_limited. A built-in CC or one from a kernel module is already
able to write to this member of struct tcp_sock.
For a BPF program, write access has not been allowed, yet.
Signed-off-by: Yixin Shen <bobankhshen@gmail.com>
---
net/ipv4/bpf_tcp_ca.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv4/bpf_tcp_ca.c b/net/ipv4/bpf_tcp_ca.c
index e8b27826283e..ea21c96c03aa 100644
--- a/net/ipv4/bpf_tcp_ca.c
+++ b/net/ipv4/bpf_tcp_ca.c
@@ -113,6 +113,9 @@ static int bpf_tcp_ca_btf_struct_access(struct bpf_verifier_log *log,
case offsetof(struct tcp_sock, ecn_flags):
end = offsetofend(struct tcp_sock, ecn_flags);
break;
+ case offsetof(struct tcp_sock, app_limited):
+ end = offsetofend(struct tcp_sock, app_limited);
+ break;
default:
bpf_log(log, "no write support to tcp_sock at off %d\n", off);
return -EACCES;
--
2.25.1
next prev parent reply other threads:[~2023-03-29 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:35 [PATCH bpf-next v2 0/2] Allow BPF TCP CCs to write app_limited Yixin Shen
2023-03-29 7:35 ` Yixin Shen [this message]
2023-03-29 7:35 ` [PATCH bpf-next v2 2/2] selftests/bpf: test a BPF CC writing app_limited Yixin Shen
2023-03-29 20:40 ` [PATCH bpf-next v2 0/2] Allow BPF TCP CCs to write app_limited patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329073558.8136-2-bobankhshen@gmail.com \
--to=bobankhshen@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.