Re: [PATCH net] bnx2x: use the right build_skb() helper

[Leon Romanovsky <leon@kernel.org>]

On Tue, Mar 28, 2023 at 05:00:13PM -0700, Jakub Kicinski wrote:
> build_skb() no longer accepts slab buffers. Since slab use is fairly
> uncommon we prefer the drivers to call a separate slab_build_skb()
> function appropriately.
> 
> bnx2x uses the old semantics where size of 0 meant buffer from slab.
> It sets the fp->rx_frag_size to 0 for MTUs which don't fit in a page.
> It needs to call slab_build_skb().
> 
> This fixes the WARN_ONCE() of incorrect API use seen with bnx2x.
> 
> Reported-by: Thomas Voegtle <tv@lio96.de>
> Link: https://lore.kernel.org/all/b8f295e4-ba57-8bfb-7d9c-9d62a498a727@lio96.de/
> Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: aelior@marvell.com
> CC: skalluru@marvell.com
> CC: manishc@marvell.com
> CC: keescook@chromium.org
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>