Re: [PATCH v4 1/4] bootstd: Enable BOOTSTD_DEFAULTS by default

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]

On Wed, Mar 29, 2023 at 08:16:36PM +1300, Simon Glass wrote:
> This is needed to enable the boot command used to start standard boot.
> Enable it by default. This brings in quite a few features, mostly in
> common with DISTRO_DEFAULTS
> 
> Disable this option for boards which don't have enough space.
> 
> Disable CONFIG_ENV_VARS_UBOOT_CONFIG for some Xilinx boards which have
> a very small environment. Disable BOOTSTD_DEFAULTS for smartweb since
> it is too close to its limit.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v4:
> - Rebase to -next
> 
>  boot/Kconfig                                 | 1 +
>  configs/bk4r1_defconfig                      | 1 +
>  configs/sama5d27_giantboard_defconfig        | 1 +
>  configs/sama5d27_som1_ek_mmc1_defconfig      | 1 +
>  configs/sama5d27_som1_ek_mmc_defconfig       | 1 +
>  configs/sama5d27_som1_ek_qspiflash_defconfig | 1 +
>  configs/sama5d27_wlsom1_ek_mmc_defconfig     | 1 +
>  configs/sama5d2_icp_mmc_defconfig            | 1 +
>  configs/sama5d2_xplained_emmc_defconfig      | 1 +
>  configs/sama5d2_xplained_mmc_defconfig       | 1 +
>  configs/sama5d2_xplained_qspiflash_defconfig | 1 +
>  configs/sheevaplug_defconfig                 | 1 +
>  configs/smartweb_defconfig                   | 1 +
>  configs/taurus_defconfig                     | 1 +
>  configs/tools-only_defconfig                 | 2 +-
>  configs/xilinx_versal_mini_emmc0_defconfig   | 1 +
>  configs/xilinx_versal_mini_emmc1_defconfig   | 1 +
>  configs/xilinx_zynqmp_mini_emmc0_defconfig   | 2 +-
>  configs/xilinx_zynqmp_mini_emmc1_defconfig   | 2 +-
>  19 files changed, 19 insertions(+), 3 deletions(-)
> 
> diff --git a/boot/Kconfig b/boot/Kconfig
> index d95a2a702665..61ebc2750154 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -435,6 +435,7 @@ if BOOTSTD
>  config BOOTSTD_DEFAULTS
>  	bool "Select some common defaults for standard boot"
>  	depends on BOOTSTD
> +	default y
>  	imply USE_BOOTCOMMAND
>  	select BOOT_DEFAULTS

I intentionally did not do this before, and I don't think it's right,
certainly right now. This fixes some boards (such as some mediatek SoCs
for example) that have boostd, have no bootcmd in environment and so
don't autoboot before bootstd, but do now. But it also bloats all of the
platforms that don't want bootstd because they have a real bootcmd
that's not some variant of "prepare to and then run distro_bootcmd".
Those should get bootstd disabled, first. Then we can evaluate if this
ends up being the right option.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]