From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF13DC74A5B for ; Wed, 29 Mar 2023 14:54:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 63B8D85D21; Wed, 29 Mar 2023 16:54:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="SjouN4Hu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2DE5185CB4; Wed, 29 Mar 2023 16:54:08 +0200 (CEST) Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF67185CB4 for ; Wed, 29 Mar 2023 16:54:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb30.google.com with SMTP id p204so19624015ybc.12 for ; Wed, 29 Mar 2023 07:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680101643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wnn67qmxc/b+xK22Oi/BbF4zpqsw/gcDg4v1aDrDN/E=; b=SjouN4Hu19uxnhzO4/bqO/QeGAnhXVM4t6FNc7sXlXy8FuA2eBrpt1xEKPJCXxp0y0 +qWNZ75JPykthiUnYViE2DGr5h/FDXUZMI3evjuaGZ5H4BnMaf/rpXSEoK4ZQQwOn3qE vtJib8rYEQOtgs5/tuboiV9HzI89AypTKvuzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680101643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wnn67qmxc/b+xK22Oi/BbF4zpqsw/gcDg4v1aDrDN/E=; b=LO7rJthKcA1JBmj8XgOd+FrVuYUaziNyPImKhSeqf/enQmky1ueSbPPDvdMuSYzXlc E8lWQ8QHwg1P9vHa0O1ifqiUB3aKUzB0ZtOporS21mYs/Eq+gytNUh6MA76+IE8+P1ot 7zPD36VoU6v+4FMtQVrSFpfzH5e6Hxqbz6EIjxIS7zS3qeIQZOy4TwGI64G2ofETY//E dauToDIS36vCkSXzbxyY1nENl9eaOB6P1pNlAohYMfyTNKFLiFJC1bQTJE+GG+ucpEel A0Z/wzPMpN5Pb9vAvv1912NbEZohtp0XTJOpr5Ghp2X1TceEI6LSL2jnorWjpsEtkVF9 m1Eg== X-Gm-Message-State: AAQBX9cg3iVMXmkdXBhfAcFnLhLMWuMGKekTnVGsdJUIG03ZnVWspgt5 g97wo+op341n1JWeAuQCkHfYRA== X-Google-Smtp-Source: AKy350bBY6o+TOCpsxwtjG/A/iDBOr73GVGADZbiAzDUWqU/w4Ng9MStwxi/2RALTCWfZncPWBCJ5g== X-Received: by 2002:a05:6902:1888:b0:acc:1061:455 with SMTP id cj8-20020a056902188800b00acc10610455mr23888294ybb.60.1680101643464; Wed, 29 Mar 2023 07:54:03 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-3b93-b60b-c6f7-8d57.res6.spectrum.com. [2603:6081:7b00:6400:3b93:b60b:c6f7:8d57]) by smtp.gmail.com with ESMTPSA id k8-20020a056902158800b00b7767ca749asm3523443ybu.55.2023.03.29.07.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 07:54:03 -0700 (PDT) Date: Wed, 29 Mar 2023 10:54:01 -0400 From: Tom Rini To: Peter Robinson Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [v4 0/7] Fix Rockchip RK3399 bootstd migration Message-ID: <20230329145401.GE6083@bill-the-cat> References: <20230324205816.2035181-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VhnBbVOQUe4Xxf5+" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --VhnBbVOQUe4Xxf5+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2023 at 06:50:41PM +0100, Peter Robinson wrote: > On Mon, Mar 27, 2023 at 5:02=E2=80=AFAM Simon Glass wr= ote: > > > > Hi Tom, > > > > On Sat, 25 Mar 2023 at 09:58, Tom Rini wrote: > > > > > > Hey all, > > > > > > I took a look at Simon's v3 series to fix the rk3399 bootstd migratio= n, > > > and it changed too much for everything else. I took about half of that > > > series and then reworked a few things. Now only rk3399 platforms chan= ge > > > at all and aside from bootcmd changes, the only thing is they now > > > disable true/test/sysboot/showvar/false/exit commands as those were > > > being pulled in from distro and now we don't set that flag. I think t= he > > > way I changed how we enable BOOTSTD_DEFAULTS should make it easier to > > > perform more SoC migrations. > > > > Thanks for digging into this. I haven't seen any comments on the rpi > > conversion, so perhaps people could test that? >=20 > I was planning on looking at that once 2023.04 was out but TBH I have > wasted so much time over the last few cycles dealing with regressions > through a bunch of these series that I now have so little time for > enhancements I now shy away. I know a lot of these series should > improve things in the future but they don't feel like when there's > unnecessary changes for things that are clearly untested. I too am unhappy with how some of these have gone. The _intent_ here is that getting the current "boot generic distro" framework is complex / error prone, and we can do better. Unfortunately the first set of platforms to switch to this are Rockchip and I think there was overlap there with platforms that got broken at the end of the v2023.01 cycle to fix other platforms, and then those sets of platforms flipped early in v2023.04 and took until -rc2? to get resolved. Which was less than ideal. > There's also a lot of change for changes sake, for example the > rockchips ATF binaries needed is called bl31.elf by the default output > of the ATF build process, for others it's bl31.bin, binman for what > ever reason has changed that to be atf-bl31, now I have to change the > entire build process to be able to work out what is what on a board by > board basis to be able to set the required variable to be able to > specify the ATF where previously it "just worked (tm)"..... I suppose > there is some perceived goal and improvement here but with both my > "U-Boot device maintainer" and "distro maintainer" hats on, both of > which I do in my own spare time, I currently fail to see it and I end > up. I wish I knew where to talk to with ATF / TF-A to get some agreed upon naming scheme going as one of the things that is very frustrating is getting the names and combinations of everything else that's required Just Right for every chip. And feedback that things aren't working is appreciated, since we do need to make things easier. --=20 Tom --VhnBbVOQUe4Xxf5+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQkUP8ACgkQFHw5/5Y0 tyzNgQv+IIXwzA8xVK7ykyf6CYt4EmJ/9T3Laa8dROLfCTa5roObrE05PzRSBzNg MsUKrOrAQy34KTMJvCQszT9of2RRuiFt8FCECNlzZO8ZplK+FTtLoz36Ud7bgLEZ aoiPFdRrleZBlEmnIEVmVwtApemgIOR86U2aos81DYJI8U3/RNhhoUNci7/jo4gD JLVEM1ZVXGg+0HYBuJaN1lu63llD9Sd3hoL2q2f6ZWgJy80yq4k90aggMYtX9Ic0 KMEKfkrndCXaEZoRcukguqmf1P382/lGANGT6HDNA5Ef2x3w2XPfcIOAIjGou6jL lyPg0T1mweiEBlyfaC+TFbqUpCVxpS2juuRGgbDm1/Gxy9mqck8z/0JQp0OCVaAH NF5WF080W0q9IGGwQPcJmJ+chxMA+ziqI5tYFHEccC+OrYSKPx7aqQICSty1rj8P qHhVbna226+ssgE2iz/IgIma/gbZ/Qw27k6Q00WTVe5PI/GSG2YLCusdzU3x/i0K az0aHTwx =MXPs -----END PGP SIGNATURE----- --VhnBbVOQUe4Xxf5+--