From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Louis Peens <louis.peens@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>
Subject: Re: [PATCH net-next 1/2] nfp: initialize netdev's dev_port with correct id
Date: Wed, 29 Mar 2023 19:38:31 -0700 [thread overview]
Message-ID: <20230329193831.2eb48e3c@kernel.org> (raw)
In-Reply-To: <DM6PR13MB3705D6F71A159185171319E3FC8E9@DM6PR13MB3705.namprd13.prod.outlook.com>
On Thu, 30 Mar 2023 01:40:30 +0000 Yinjun Zhang wrote:
> On Wed, 29 Mar 2023 12:22:27 -0700, Jakub Kicinski wrote:
> > On Wed, 29 Mar 2023 16:45:47 +0200 Louis Peens wrote:
> > > In some customized scenario, `dev_port` is used to rename netdev
> > > instead of `phys_port_name`, which requires to initialize it
> > > correctly to get expected netdev name.
> >
> > What do you mean by "which requires to initialize it correctly to get
> > expected netdev name." ?
>
> I mean it cannot be renamed by udev rules as expected if `dev_port`
> is not correctly initialized, because the second port doesn't match
> 'ATTR{dev_port}=="1"'.
Yes, but phys_port_name is still there, and can be used, right?
So why add another attr?
next prev parent reply other threads:[~2023-03-30 2:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 14:45 [PATCH net-next 0/2] Small series of enhancements Louis Peens
2023-03-29 14:45 ` [PATCH net-next 1/2] nfp: initialize netdev's dev_port with correct id Louis Peens
2023-03-29 18:49 ` Leon Romanovsky
2023-03-30 1:32 ` Yinjun Zhang
2023-03-29 19:22 ` Jakub Kicinski
2023-03-30 1:40 ` Yinjun Zhang
2023-03-30 2:38 ` Jakub Kicinski [this message]
2023-03-30 2:52 ` Yinjun Zhang
2023-03-30 3:10 ` Jakub Kicinski
2023-03-30 3:27 ` Yinjun Zhang
2023-03-30 3:58 ` Jakub Kicinski
2023-03-29 14:45 ` [PATCH net-next 2/2] nfp: separate the port's upper state with lower phy state Louis Peens
2023-03-29 18:52 ` Leon Romanovsky
2023-03-30 1:48 ` Yinjun Zhang
2023-03-29 19:24 ` Jakub Kicinski
2023-03-30 1:56 ` Yinjun Zhang
2023-03-30 2:41 ` Jakub Kicinski
2023-03-30 2:57 ` Yinjun Zhang
2023-03-30 3:12 ` Jakub Kicinski
2023-03-30 3:33 ` Yinjun Zhang
2023-03-30 4:00 ` Jakub Kicinski
2023-03-30 5:55 ` Yinjun Zhang
2023-03-30 17:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329193831.2eb48e3c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.