From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Jason Xing <kernelxing@tencent.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 0/4] net: rps/rfs improvements
Date: Wed, 29 Mar 2023 20:57:47 -0700 [thread overview]
Message-ID: <20230329205747.3ed24339@kernel.org> (raw)
In-Reply-To: <CANn89iKxuKs8muPAe+6jCjYdvoYa=39uXVKoCpKpOVRUFtqt7w@mail.gmail.com>
On Thu, 30 Mar 2023 05:39:35 +0200 Eric Dumazet wrote:
> > This was from "grep NET_RX /proc/softirqs" (more exactly a tool
> > parsing /proc/softirqs)
> >
> > So it should match the number of calls to net_rx_action(), but I can
> > double check if you want.
> >
> > (I had a simple hack to enable/disable the optimizations with a hijacked sysctl)
>
> Trace of real debug session, because numbers ;)
> Old platform with two Intel(R) Xeon(R) Gold 6268L CPU @ 2.80GHz (96
> threads total)
>
> 600 tcp_rr flows
>
> iroa23:/home/edumazet# cat /proc/sys/net/core/netdev_max_backlog
> 1000
> iroa23:/home/edumazet# ./interrupts
> hrtimer:99518 cal:2421783 timer:1034 sched:80505 rcu:7661 rps:2390765
> net_tx:43 net_rx:3344637 eth1-rx:295134 eth1-tx:558933 eth1:854074
> ^C
> iroa23:/home/edumazet# echo 1001 >/proc/sys/net/core/netdev_max_backlog
> iroa23:/home/edumazet# ./interrupts
> hrtimer:99545 cal:2358993 timer:1086 sched:77806 rcu:10928 rps:2419052
> net_tx:21 net_rx:3016301 eth1-rx:294612 eth1-tx:560331 eth1:855083
> ^C
>
> echo "(3344637 - 3016301)/3344637" | bc -ql
> .09816790282473105452
Very nice, thanks! (I didn't know about /proc/softirqs !)
next prev parent reply other threads:[~2023-03-30 3:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 23:50 [PATCH net-next 0/4] net: rps/rfs improvements Eric Dumazet
2023-03-28 23:50 ` [PATCH net-next 1/4] net: napi_schedule_rps() cleanup Eric Dumazet
2023-03-28 23:50 ` [PATCH net-next 2/4] net: add softnet_data.in_net_rx_action Eric Dumazet
2023-03-28 23:50 ` [PATCH net-next 3/4] net: optimize napi_schedule_rps() Eric Dumazet
2023-03-28 23:50 ` [PATCH net-next 4/4] net: optimize ____napi_schedule() to avoid extra NET_RX_SOFTIRQ Eric Dumazet
2023-03-29 12:47 ` Yunsheng Lin
2023-03-29 15:47 ` Eric Dumazet
2023-03-30 2:33 ` Yunsheng Lin
2023-03-30 2:57 ` Eric Dumazet
2023-03-30 6:47 ` Yunsheng Lin
2023-03-30 7:36 ` Yunsheng Lin
2023-03-30 9:50 ` Jason Xing
2023-03-30 11:39 ` Paolo Abeni
2023-03-30 11:44 ` Eric Dumazet
2023-03-30 12:03 ` Jason Xing
2023-03-29 2:40 ` [PATCH net-next 0/4] net: rps/rfs improvements Jason Xing
2023-03-30 3:04 ` Jakub Kicinski
2023-03-30 3:15 ` Eric Dumazet
2023-03-30 3:39 ` Eric Dumazet
2023-03-30 3:57 ` Jakub Kicinski [this message]
2023-03-30 12:00 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2023-03-29 13:17 Aiden Leong
2023-03-29 13:18 ` Aiden Leong
2023-03-29 15:33 ` Eric Dumazet
2023-03-29 16:21 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329205747.3ed24339@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kernelxing@tencent.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.