From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org, bpf@vger.kernel.org
Subject: Re: [PATCH 12/16] virtio_net: introduce virtnet_get_netdev()
Date: Wed, 29 Mar 2023 21:22:03 -0700 [thread overview]
Message-ID: <20230329212203.3c3bf199@kernel.org> (raw)
In-Reply-To: <20230328092847.91643-13-xuanzhuo@linux.alibaba.com>
On Tue, 28 Mar 2023 17:28:43 +0800 Xuan Zhuo wrote:
> +const struct net_device_ops *virtnet_get_netdev(void)
> +{
> + return &virtnet_netdev;
> +}
Why not just make the virtnet_netdev symbol visible?
Many drivers do that.
If you prefer the function maybe virtnet_get_ndos() would be a better
name for example? The current name sounds like it will get a... well..
a netdev. And it gets ops.
next prev parent reply other threads:[~2023-03-30 4:22 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 9:28 [PATCH 00/16] virtio-net: split virtio-net.c Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 01/16] virtio_net: add a separate directory for virtio-net Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 02/16] virtio_net: move struct to header file Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-30 4:18 ` Jakub Kicinski
2023-03-30 6:01 ` Xuan Zhuo
2023-03-30 6:01 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 03/16] virtio_net: add prefix to the struct inside " Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 04/16] virtio_net: separating cpu-related funs Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 05/16] virtio_net: separate virtnet_ctrl_set_queues() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 06/16] virtio_net: separate virtnet_ctrl_set_mac_address() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 07/16] virtio_net: remove lock from virtnet_ack_link_announce() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 08/16] virtio_net: separating the APIs of cq Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 09/16] virtio_net: introduce virtnet_rq_update_stats() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 10/16] virtio_net: separating the funcs of ethtool Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 11/16] virtio_net: introduce virtnet_dev_rx_queue_group() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 12/16] virtio_net: introduce virtnet_get_netdev() Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-30 4:22 ` Jakub Kicinski [this message]
2023-03-30 6:01 ` Xuan Zhuo
2023-03-30 6:01 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 13/16] virtio_net: prepare for virtio Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 14/16] virtio_net: move virtnet_[en/dis]able_delayed_refill to header file Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 15/16] virtio_net: add APIs to register/unregister virtio driver Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-28 9:28 ` [PATCH 16/16] virtio_net: separating the virtio code Xuan Zhuo
2023-03-28 9:28 ` Xuan Zhuo
2023-03-30 4:15 ` Jakub Kicinski
2023-03-30 6:00 ` Xuan Zhuo
2023-03-30 6:00 ` Xuan Zhuo
2023-03-30 6:17 ` [PATCH 00/16] virtio-net: split virtio-net.c Michael S. Tsirkin
2023-03-30 6:17 ` Michael S. Tsirkin
2023-03-31 7:21 ` Xuan Zhuo
2023-03-31 7:21 ` Xuan Zhuo
2023-03-31 7:35 ` Jason Wang
2023-03-31 7:35 ` Jason Wang
2023-03-31 7:48 ` Xuan Zhuo
2023-03-31 7:48 ` Xuan Zhuo
2023-03-31 8:00 ` Michael S. Tsirkin
2023-03-31 8:00 ` Michael S. Tsirkin
2023-03-31 8:10 ` Xuan Zhuo
2023-03-31 8:10 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329212203.3c3bf199@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.