From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51EC8C2D6 for ; Thu, 30 Mar 2023 05:41:37 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id iw3so17085890plb.6 for ; Wed, 29 Mar 2023 22:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680154896; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TAnOB62ctYJ+xcEWyxTBLF5P3A7lopNUPybiMwLxhiM=; b=DTUrhqlp4U3R4lE552xBdl6Uc+TbMd6p8lMlbl3NjzDuTayKTinFKrApFHtf7OcIRH bUHI+FW26gqUrW0FsC2iL+vNGMZTxR7qVckNlZM/HNF0GCu3DMyIyZF+5xhGbufvIpYp FRZCp3xm611OkXsJKCmXIsGnRIgm1Bh4tZPmj/Zt9MuVogc2DrrC84VWLJfQjbmcfMaA fF5+vyQluAzErZ36nR2lJfkW/X1OUT8kP80n0ZEIytT5H3mxFffBPv9CsXN8bS/GTC2E y5zwKankCvXB37XjmwcatDeTjV2CSa7Vktt4EY1MvtGz00ZPX5p/MsXttBDL4oU881AI Rr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680154896; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TAnOB62ctYJ+xcEWyxTBLF5P3A7lopNUPybiMwLxhiM=; b=H0pxErEK5ML7kAxQF+FbcDPUbnUxePmIXNdtKL9Z6BodQD3tdJKmWdnGPeYbO25SZc wPA+ltxSL9lkZgSyW5c68wBDadKcZ5JCbtM8MAsfsvph6MtxORxuCY91Isid8pimCTvz e1ySB0If7rtPPVVTcX71f97ML5X+yWAQ2chE81MVoeay14f+6UKLRgJNJXLeoTa48357 qU3g7mP6FMpEYj5FPDT/mfgTeGlM7zOfHrOOMf56s8UjxQN7dRotH9aWeCjRP1ZglRZ8 gszZ8gASXF/ImjP6Cibn/y5x4A6q3pptJHZhIqkK3VYOKWDmsSsVMqcnIUU+w/h+FfBB kkaA== X-Gm-Message-State: AAQBX9drLl7TjejuhEQG4BMGhgXOrNKF0zq2xbvljdrMwZSfaSTsBEL+ cb3kBFFLHU3ssqjIf87xqBNU X-Google-Smtp-Source: AKy350aX6sHQt/xsMqLk0oB5MMOu2GEEt7EWROffMK/zg7fgAZiw32FaOUuJxhy2awLRaeopdDNM3Q== X-Received: by 2002:a17:903:2442:b0:19a:9dab:3438 with SMTP id l2-20020a170903244200b0019a9dab3438mr5523514pls.2.1680154896628; Wed, 29 Mar 2023 22:41:36 -0700 (PDT) Received: from thinkpad ([117.216.120.213]) by smtp.gmail.com with ESMTPSA id c10-20020a170902b68a00b0019edf07eb06sm23926181pls.122.2023.03.29.22.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 22:41:36 -0700 (PDT) Date: Thu, 30 Mar 2023 11:11:27 +0530 From: Manivannan Sadhasivam To: Will Deacon Cc: joro@8bytes.org, catalin.marinas@arm.com, kernel-team@android.com, linux-kernel@vger.kernel.org, steev@kali.org, iommu@lists.linux.dev, johan+linaro@kernel.org, andersson@kernel.org, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Subject: Re: [PATCH v5] iommu/arm-smmu-qcom: Limit the SMR groups to 128 Message-ID: <20230330054127.GA9876@thinkpad> References: <20230327080029.11584-1-manivannan.sadhasivam@linaro.org> <167991987524.1305084.466646756285487652.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <167991987524.1305084.466646756285487652.b4-ty@kernel.org> On Mon, Mar 27, 2023 at 01:52:01PM +0100, Will Deacon wrote: > On Mon, 27 Mar 2023 13:30:29 +0530, Manivannan Sadhasivam wrote: > > Some platforms support more than 128 stream matching groups than what is > > defined by the ARM SMMU architecture specification. But due to some unknown > > reasons, those additional groups don't exhibit the same behavior as the > > architecture supported ones. > > > > For instance, the additional groups will not detect the quirky behavior of > > some firmware versions intercepting writes to S2CR register, thus skipping > > the quirk implemented in the driver and causing boot crash. > > > > [...] > > Applied to will (for-joerg/arm-smmu/updates), thanks! > Thanks Will! Could you please tag this patch for 6.3-rcS? Even though this patch is not fixing any issue introduced in 6.3, the affected platform (SC8280XP) has reasonable upstream support in 6.3 and the distro folks would like to stick to it for some time. This patch will allow them to boot mainline without any additional out-of-tree patches. - Mani > [1/1] iommu/arm-smmu-qcom: Limit the SMR groups to 128 > https://git.kernel.org/will/c/122611347326 > > Cheers, > -- > Will > > https://fixes.arm64.dev > https://next.arm64.dev > https://will.arm64.dev -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33BD6C6FD1D for ; Thu, 30 Mar 2023 05:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PQhX/dgW/cC/cwdy1SqDWS9Xq/H+9qYd4YLh7LQ9Afk=; b=ts/+D987NWlJAS 84M/EQyD+m0YNH3Goc1xvBP0OXt3GoBMwnNU0g47i2PVjTcLM03C/rc4sew8mUlCOG91QzC6S/U/F fYFO8dCC92fwnLsdaVSllkAGiixD6HLsNrbQTzHo2tyaIlAnY5J6w03YsOsYIu3RCLhlSiWoXB4q+ jJiIVoFVfoGO1BMc1I0SO+uw/1ma6NEPcd1aNlOStDL4eyX77P4dtU1m74cwQa5EmhHuIplleadaQ MklXs0GfvNBvAqBO3hU5YkzAIVZHfiTvAAeCR2Gtd+SfdaxOgLYO8rC53txt1lYzNTI1GvI+LVqCZ jvB6dd6Sbsb+YWbG5tyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phl2c-002fAb-09; Thu, 30 Mar 2023 05:41:42 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phl2Y-002f9n-2R for linux-arm-kernel@lists.infradead.org; Thu, 30 Mar 2023 05:41:40 +0000 Received: by mail-pj1-x102a.google.com with SMTP id l7so16242336pjg.5 for ; Wed, 29 Mar 2023 22:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680154896; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TAnOB62ctYJ+xcEWyxTBLF5P3A7lopNUPybiMwLxhiM=; b=DTUrhqlp4U3R4lE552xBdl6Uc+TbMd6p8lMlbl3NjzDuTayKTinFKrApFHtf7OcIRH bUHI+FW26gqUrW0FsC2iL+vNGMZTxR7qVckNlZM/HNF0GCu3DMyIyZF+5xhGbufvIpYp FRZCp3xm611OkXsJKCmXIsGnRIgm1Bh4tZPmj/Zt9MuVogc2DrrC84VWLJfQjbmcfMaA fF5+vyQluAzErZ36nR2lJfkW/X1OUT8kP80n0ZEIytT5H3mxFffBPv9CsXN8bS/GTC2E y5zwKankCvXB37XjmwcatDeTjV2CSa7Vktt4EY1MvtGz00ZPX5p/MsXttBDL4oU881AI Rr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680154896; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TAnOB62ctYJ+xcEWyxTBLF5P3A7lopNUPybiMwLxhiM=; b=6YuRFzrVp5rP2G6845iG1tPhwSbPvesE0wJc7CpiUDQLwFasY376KNqeiRRAu9EWJJ jFc2sFtD4xO1GirmzxyDlDQUKsAlNNtjv37UzWFM6nMd19/EgkmWsG/+yjcYWFkHePbt qFNcVaoPKVPg3lvrPofkr35/+M17sqdhXvGA+DIlWbSUoOD2sYpxSNEMlmdxifPwqgqX clRYnBm1G4gewgBlaqAvCcxk9g1CYinqtABBLbaLPruqqfq5/M2f8y/VHZasmxKmEQ2B Er7KaKN96+vjl9BUUyXGHGrEZmy4oJ5fduXCYkHuSe8W1aMLIh1aFrScgf+qvaiduHcO ODQQ== X-Gm-Message-State: AAQBX9dL/phN3FTdragOq4Pc1BPT9GdsLtIJ7vLoiIspL17AmVcD8BPr FpeJoE6Oqe5maKEWHtyp7m3W X-Google-Smtp-Source: AKy350aX6sHQt/xsMqLk0oB5MMOu2GEEt7EWROffMK/zg7fgAZiw32FaOUuJxhy2awLRaeopdDNM3Q== X-Received: by 2002:a17:903:2442:b0:19a:9dab:3438 with SMTP id l2-20020a170903244200b0019a9dab3438mr5523514pls.2.1680154896628; Wed, 29 Mar 2023 22:41:36 -0700 (PDT) Received: from thinkpad ([117.216.120.213]) by smtp.gmail.com with ESMTPSA id c10-20020a170902b68a00b0019edf07eb06sm23926181pls.122.2023.03.29.22.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 22:41:36 -0700 (PDT) Date: Thu, 30 Mar 2023 11:11:27 +0530 From: Manivannan Sadhasivam To: Will Deacon Cc: joro@8bytes.org, catalin.marinas@arm.com, kernel-team@android.com, linux-kernel@vger.kernel.org, steev@kali.org, iommu@lists.linux.dev, johan+linaro@kernel.org, andersson@kernel.org, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Subject: Re: [PATCH v5] iommu/arm-smmu-qcom: Limit the SMR groups to 128 Message-ID: <20230330054127.GA9876@thinkpad> References: <20230327080029.11584-1-manivannan.sadhasivam@linaro.org> <167991987524.1305084.466646756285487652.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <167991987524.1305084.466646756285487652.b4-ty@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_224138_841555_AA82B9E6 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjcsIDIwMjMgYXQgMDE6NTI6MDFQTSArMDEwMCwgV2lsbCBEZWFjb24gd3Jv dGU6Cj4gT24gTW9uLCAyNyBNYXIgMjAyMyAxMzozMDoyOSArMDUzMCwgTWFuaXZhbm5hbiBTYWRo YXNpdmFtIHdyb3RlOgo+ID4gU29tZSBwbGF0Zm9ybXMgc3VwcG9ydCBtb3JlIHRoYW4gMTI4IHN0 cmVhbSBtYXRjaGluZyBncm91cHMgdGhhbiB3aGF0IGlzCj4gPiBkZWZpbmVkIGJ5IHRoZSBBUk0g U01NVSBhcmNoaXRlY3R1cmUgc3BlY2lmaWNhdGlvbi4gQnV0IGR1ZSB0byBzb21lIHVua25vd24K PiA+IHJlYXNvbnMsIHRob3NlIGFkZGl0aW9uYWwgZ3JvdXBzIGRvbid0IGV4aGliaXQgdGhlIHNh bWUgYmVoYXZpb3IgYXMgdGhlCj4gPiBhcmNoaXRlY3R1cmUgc3VwcG9ydGVkIG9uZXMuCj4gPiAK PiA+IEZvciBpbnN0YW5jZSwgdGhlIGFkZGl0aW9uYWwgZ3JvdXBzIHdpbGwgbm90IGRldGVjdCB0 aGUgcXVpcmt5IGJlaGF2aW9yIG9mCj4gPiBzb21lIGZpcm13YXJlIHZlcnNpb25zIGludGVyY2Vw dGluZyB3cml0ZXMgdG8gUzJDUiByZWdpc3RlciwgdGh1cyBza2lwcGluZwo+ID4gdGhlIHF1aXJr IGltcGxlbWVudGVkIGluIHRoZSBkcml2ZXIgYW5kIGNhdXNpbmcgYm9vdCBjcmFzaC4KPiA+IAo+ ID4gWy4uLl0KPiAKPiBBcHBsaWVkIHRvIHdpbGwgKGZvci1qb2VyZy9hcm0tc21tdS91cGRhdGVz KSwgdGhhbmtzIQo+IAoKVGhhbmtzIFdpbGwhIENvdWxkIHlvdSBwbGVhc2UgdGFnIHRoaXMgcGF0 Y2ggZm9yIDYuMy1yY1M/IEV2ZW4gdGhvdWdoIHRoaXMgcGF0Y2gKaXMgbm90IGZpeGluZyBhbnkg aXNzdWUgaW50cm9kdWNlZCBpbiA2LjMsIHRoZSBhZmZlY3RlZCBwbGF0Zm9ybSAoU0M4MjgwWFAp IGhhcwpyZWFzb25hYmxlIHVwc3RyZWFtIHN1cHBvcnQgaW4gNi4zIGFuZCB0aGUgZGlzdHJvIGZv bGtzIHdvdWxkIGxpa2UgdG8gc3RpY2sgdG8KaXQgZm9yIHNvbWUgdGltZS4gVGhpcyBwYXRjaCB3 aWxsIGFsbG93IHRoZW0gdG8gYm9vdCBtYWlubGluZSB3aXRob3V0IGFueQphZGRpdGlvbmFsIG91 dC1vZi10cmVlIHBhdGNoZXMuCgotIE1hbmkKCj4gWzEvMV0gaW9tbXUvYXJtLXNtbXUtcWNvbTog TGltaXQgdGhlIFNNUiBncm91cHMgdG8gMTI4Cj4gICAgICAgaHR0cHM6Ly9naXQua2VybmVsLm9y Zy93aWxsL2MvMTIyNjExMzQ3MzI2IAo+IAo+IENoZWVycywKPiAtLSAKPiBXaWxsCj4gCj4gaHR0 cHM6Ly9maXhlcy5hcm02NC5kZXYKPiBodHRwczovL25leHQuYXJtNjQuZGV2Cj4gaHR0cHM6Ly93 aWxsLmFybTY0LmRldgoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7g rprgrr/grrXgrq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK