All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@nvidia.com>
To: Mark Zhang <markzhang@nvidia.com>
Cc: <jgg@nvidia.com>, <chuck.lever@oracle.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH RESEND rdma-next] RDMA/cm: Trace icm_send_rej event before the cm state is reset
Date: Thu, 30 Mar 2023 10:37:25 +0300	[thread overview]
Message-ID: <20230330073725.GU831478@unreal> (raw)
In-Reply-To: <20230330072351.481200-1-markzhang@nvidia.com>

On Thu, Mar 30, 2023 at 10:23:51AM +0300, Mark Zhang wrote:
> Trace icm_send_rej event before the cm state is reset to idle, so that
> correct cm state will be logged. For example when an incoming request is
> rejected, the old trace log was:
>     icm_send_rej: local_id=961102742 remote_id=3829151631 state=IDLE reason=REJ_CONSUMER_DEFINED
> With this patch:
>     icm_send_rej: local_id=312971016 remote_id=3778819983 state=MRA_REQ_SENT reason=REJ_CONSUMER_DEFINED
> 
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Fixes: 8dc105befe16 ("RDMA/cm: Add tracepoints to track MAD send operations")
> ---
>  drivers/infiniband/core/cm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

For future reference:
1. You sent new version, so your patch should have vXXX in subject and not RESEND.
2. Changelog is missing.
3. Signed-off-by should be last.

There is no need to resend this patch, we will fix when we will apply it.

Thanks

  reply	other threads:[~2023-03-30  7:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  7:23 [PATCH RESEND rdma-next] RDMA/cm: Trace icm_send_rej event before the cm state is reset Mark Zhang
2023-03-30  7:37 ` Leon Romanovsky [this message]
2023-03-30  7:39   ` Mark Zhang
2023-04-09  9:53 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330073725.GU831478@unreal \
    --to=leonro@nvidia.com \
    --cc=chuck.lever@oracle.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=markzhang@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.