From: Jakub Kicinski <kuba@kernel.org>
To: Andy Roulin <aroulin@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@nvidia.com,
andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz,
mlxsw@nvidia.com, idosch@nvidia.com,
Danielle Ratson <danieller@nvidia.com>
Subject: Re: [PATCH net-next] ethtool: reset #lanes when lanes is omitted
Date: Thu, 30 Mar 2023 10:38:56 -0700 [thread overview]
Message-ID: <20230330103856.4f725998@kernel.org> (raw)
In-Reply-To: <6e02aaab-18fe-692d-52cb-71212db44ade@nvidia.com>
On Thu, 30 Mar 2023 09:56:58 -0700 Andy Roulin wrote:
> Subject: [PATCH net-next] ethtool: reset #lanes when lanes is omitted
This should have been tagged for net, right?
> If the number of lanes was forced and then subsequently the user
> omits this parameter, the ksettings->lanes is reset. The driver
> should then reset the number of lanes to the device's default
> for the specified speed.
>
> However, although the ksettings->lanes is set to 0, the mod variable
> is not set to true to indicate the driver and userspace should be
> notified of the changes.
>
> Fixes: 012ce4dd3102 ("ethtool: Extend link modes settings uAPI with lanes")
> Signed-off-by: Andy Roulin <aroulin@nvidia.com>
> Reviewed-by: Danielle Ratson <danieller@nvidia.com>
next prev parent reply other threads:[~2023-03-30 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 16:56 [PATCH net-next] ethtool: reset #lanes when lanes is omitted Andy Roulin
2023-03-30 17:38 ` Jakub Kicinski [this message]
2023-03-30 18:18 ` Andy Roulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330103856.4f725998@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=aroulin@nvidia.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.