From: Christoph Hellwig <hch@lst.de>
To: Chris Mason <clm@meta.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: don't offload CRCs generation to helpers if it is fast
Date: Thu, 30 Mar 2023 23:06:49 +0200 [thread overview]
Message-ID: <20230330210649.GA30487@lst.de> (raw)
In-Reply-To: <ce173f2b-06f5-f7b3-2cea-5a431a180da8@meta.com>
On Thu, Mar 30, 2023 at 11:42:11AM -0400, Chris Mason wrote:
> I spent a while convincing myself we really don't need sync_writers, and
> it's great to get rid of that. Tangent-man noticed that we're really
> close to being able to drop struct btrfs_bio_ctrl->sync_io.
>
> As far as I can tell, it's only mirroring wbc->sync_mode, and the only
> place that still cares is lock_extent_buffer_for_io(), and we could just
> pass down the wbc.
btrfs_bio_ctrl->sync_io is already gone in misc-next and replaced with
a check for wbc->sync_mode.
next prev parent reply other threads:[~2023-03-30 21:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 0:13 don't offload CRCs generation to helpers if it is fast Christoph Hellwig
2023-03-29 0:13 ` [PATCH 1/4] btrfs: fix fast csum detection Christoph Hellwig
2023-04-03 18:35 ` David Sterba
2023-04-04 5:06 ` Christoph Hellwig
2023-04-04 17:13 ` David Sterba
2023-03-29 0:13 ` [PATCH 2/4] btrfs: remove the sync_writers field in struct btrfs_inode Christoph Hellwig
2023-04-05 13:50 ` David Sterba
2023-03-29 0:13 ` [PATCH 3/4] btrfs: never defer I/O submission for fast CRC implementations Christoph Hellwig
2023-03-29 0:13 ` [PATCH 4/4] btrfs: remove hipri_workers workqueue Christoph Hellwig
2023-03-30 15:42 ` don't offload CRCs generation to helpers if it is fast Chris Mason
2023-03-30 21:06 ` Christoph Hellwig [this message]
2023-03-31 17:31 ` David Sterba
2023-04-05 23:14 ` David Sterba
2023-04-06 5:23 ` Christoph Hellwig
2023-04-10 17:17 ` Christoph Hellwig
2023-04-11 19:09 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330210649.GA30487@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=clm@meta.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.