From: Jakub Kicinski <kuba@kernel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>,
Intel Corporation <linuxwwan@intel.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@linux.intel.com>,
Liu Haijun <haijun.liu@mediatek.com>,
M Chetan Kumar <m.chetan.kumar@linux.intel.com>,
Ricardo Martinez <ricardo.martinez@linux.intel.com>,
Loic Poulain <loic.poulain@linaro.org>,
Sergey Ryazanov <ryazanov.s.a@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: wwan: t7xx: do not compile with -Werror by default
Date: Thu, 30 Mar 2023 23:27:17 -0700 [thread overview]
Message-ID: <20230330232717.1f8bf5ea@kernel.org> (raw)
In-Reply-To: <20230329102640.8830-1-jirislaby@kernel.org>
On Wed, 29 Mar 2023 12:26:39 +0200 Jiri Slaby (SUSE) wrote:
> There is no reason for any code in the kernel to be built with -Werror
> by default. Note that we have generic CONFIG_WERROR. OTOH, some drivers
> may want to do this only on per-driver basis. Some do
> CONFIG_DRM_I915_WERROR or alike. But I reused the scsi's:
> ifdef WARNINGS_BECOME_ERRORS
> approach.
>
> Now, if one wants to build t7xx with -Werror, they may say:
> make WARNINGS_BECOME_ERRORS=1
As you said we have CONFIG_WERROR now, so I'd vote to delete
that line completely.
next prev parent reply other threads:[~2023-03-31 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 10:26 [PATCH] net: wwan: t7xx: do not compile with -Werror by default Jiri Slaby (SUSE)
2023-03-31 6:27 ` Jakub Kicinski [this message]
2023-03-31 6:35 ` [PATCH] net: wwan: t7xx: do not compile with -Werror Jiri Slaby (SUSE)
2023-03-31 6:36 ` Jiri Slaby
2023-03-31 6:51 ` Jakub Kicinski
2023-03-31 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330232717.1f8bf5ea@kernel.org \
--to=kuba@kernel.org \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=jirislaby@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.