All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-wired-lan] [PATCH bpf RFC-V3 4/5] mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
Date: Fri, 31 Mar 2023 03:12:05 +0800	[thread overview]
Message-ID: <202303310203.lHSJJtAT-lkp@intel.com> (raw)
In-Reply-To: <168019608094.3557870.11753259102366277974.stgit@firesoul>

Hi Jesper,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bpf/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Jesper-Dangaard-Brouer/xdp-rss-hash-types-representation/20230331-010857
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
patch link:    https://lore.kernel.org/r/168019608094.3557870.11753259102366277974.stgit%40firesoul
patch subject: [Intel-wired-lan] [PATCH bpf RFC-V3 4/5] mlx4: bpf_xdp_metadata_rx_hash add xdp rss hash type
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230331/202303310203.lHSJJtAT-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8d79e730d9b22b00ef3a0bbf73d3aa2c68fb898b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jesper-Dangaard-Brouer/xdp-rss-hash-types-representation/20230331-010857
        git checkout 8d79e730d9b22b00ef3a0bbf73d3aa2c68fb898b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx4/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303310203.lHSJJtAT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx4/en_rx.c: In function 'mlx4_en_xdp_rx_hash':
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c:698:21: warning: implicit conversion from 'enum xdp_rss_type_bits' to 'enum xdp_rss_hash_type' [-Wenum-conversion]
     698 |                 xht = XDP_RSS_L4_TCP;
         |                     ^
   drivers/net/ethernet/mellanox/mlx4/en_rx.c:700:21: warning: implicit conversion from 'enum xdp_rss_type_bits' to 'enum xdp_rss_hash_type' [-Wenum-conversion]
     700 |                 xht = XDP_RSS_L4_UDP;
         |                     ^


vim +698 drivers/net/ethernet/mellanox/mlx4/en_rx.c

   683	
   684	int mlx4_en_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash,
   685				enum xdp_rss_hash_type *rss_type)
   686	{
   687		struct mlx4_en_xdp_buff *_ctx = (void *)ctx;
   688		struct mlx4_cqe *cqe = _ctx->cqe;
   689		enum xdp_rss_hash_type xht = 0;
   690		__be16 status;
   691	
   692		if (unlikely(!(_ctx->dev->features & NETIF_F_RXHASH)))
   693			return -ENODATA;
   694	
   695		*hash = be32_to_cpu(cqe->immed_rss_invalid);
   696		status = cqe->status;
   697		if (status & cpu_to_be16(MLX4_CQE_STATUS_TCP))
 > 698			xht = XDP_RSS_L4_TCP;
   699		if (status & cpu_to_be16(MLX4_CQE_STATUS_UDP))
   700			xht = XDP_RSS_L4_UDP;
   701		if (status & cpu_to_be16(MLX4_CQE_STATUS_IPV4|MLX4_CQE_STATUS_IPV4F))
   702			xht |= XDP_RSS_L3_IPV4;
   703		if (status & cpu_to_be16(MLX4_CQE_STATUS_IPV6)) {
   704			xht |= XDP_RSS_L3_IPV6;
   705			if (cqe->ipv6_ext_mask)
   706				xht |= XDP_RSS_L3_DYNHDR;
   707		}
   708		*rss_type = xht;
   709	
   710		return 0;
   711	}
   712	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

  reply	other threads:[~2023-03-30 19:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 17:07 [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Jesper Dangaard Brouer
2023-03-30 17:07 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 17:07 ` [PATCH bpf RFC-V3 1/5] xdp: rss hash types representation Jesper Dangaard Brouer
2023-03-30 17:07   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 18:35   ` Stanislav Fomichev
2023-03-30 18:35     ` [Intel-wired-lan] " Stanislav Fomichev
2023-03-30 18:56     ` Jesper Dangaard Brouer
2023-03-30 18:56       ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 19:02       ` Stanislav Fomichev
2023-03-30 19:02         ` [Intel-wired-lan] " Stanislav Fomichev
2023-03-30 19:08         ` Jesper Dangaard Brouer
2023-03-30 19:08           ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-31 11:49           ` Jesper Dangaard Brouer
2023-03-31 11:49             ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 17:07 ` [PATCH bpf RFC-V3 2/5] mlx5: bpf_xdp_metadata_rx_hash add xdp rss hash type Jesper Dangaard Brouer
2023-03-30 17:07   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 17:07 ` [PATCH bpf RFC-V3 3/5] veth: " Jesper Dangaard Brouer
2023-03-30 17:07   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 17:08 ` [PATCH bpf RFC-V3 4/5] mlx4: " Jesper Dangaard Brouer
2023-03-30 17:08   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 19:12   ` kernel test robot [this message]
2023-03-30 17:08 ` [PATCH bpf RFC-V3 5/5] selftests/bpf: Adjust bpf_xdp_metadata_rx_hash for new arg Jesper Dangaard Brouer
2023-03-30 17:08   ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 18:38 ` [PATCH bpf RFC-V3 0/5] XDP-hints: API change for RX-hash kfunc bpf_xdp_metadata_rx_hash Stanislav Fomichev
2023-03-30 18:38   ` [Intel-wired-lan] " Stanislav Fomichev
2023-03-30 19:04   ` Jesper Dangaard Brouer
2023-03-30 19:04     ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-03-30 19:24 ` [xdp-hints] " Toke Høiland-Jørgensen
2023-03-30 19:24   ` [Intel-wired-lan] " Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202303310203.lHSJJtAT-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=brouer@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.