From: Rob Herring <robh@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
vigneshr@ti.com, srk@ti.com, r-gunasekaran@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: tps6598x: make interrupts optional
Date: Fri, 31 Mar 2023 13:55:07 -0500 [thread overview]
Message-ID: <20230331185507.GA1938596-robh@kernel.org> (raw)
In-Reply-To: <271f0be0-9cb2-0c74-c112-33020e9a7342@kernel.org>
On Wed, Mar 29, 2023 at 10:05:33AM +0300, Roger Quadros wrote:
> Hi Heikki & Rob,
>
> On 24/03/2023 15:37, Roger Quadros wrote:
> > The driver can poll for interrupt status so interrupts
> > can be optional. It is still recommended to use the
> > interrupt line. Polling should only be used for debug
> > and prototyping.
> >
> > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > ---
> > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > index 348a715d61f4..8c2db282735a 100644
> > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> > @@ -35,8 +35,6 @@ properties:
> > required:
> > - compatible
> > - reg
> > - - interrupts
> > - - interrupt-names
> >
> > additionalProperties: true
> >
>
> We need this patch as well along with the driver changes [1]
> Could you please Ack. Thanks!
If get_maintainers.pl had been properly used, then it probably would
have been acked by Krzysztof already. Otherwise, it's in my queue if the
DT list is copied.
Acked-by: Rob Herring <robh@kernel.org>
Rob
next prev parent reply other threads:[~2023-03-31 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:18 [PATCH] usb: typec: tps6598x: Add support for polling interrupts status Roger Quadros
2023-03-24 13:37 ` [PATCH] dt-bindings: usb: tps6598x: make interrupts optional Roger Quadros
2023-03-29 7:05 ` Roger Quadros
2023-03-29 10:43 ` Heikki Krogerus
2023-03-31 18:55 ` Rob Herring [this message]
2023-03-28 13:51 ` [PATCH] usb: typec: tps6598x: Add support for polling interrupts status Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331185507.GA1938596-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.