From: Jakub Kicinski <kuba@kernel.org>
To: Shailend Chand <shailend@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net] gve: Secure enough bytes in the first TX desc for all TCP pkts
Date: Fri, 31 Mar 2023 21:29:24 -0700 [thread overview]
Message-ID: <20230331212924.49bc1c64@kernel.org> (raw)
In-Reply-To: <20230330220939.2341562-1-shailend@google.com>
On Thu, 30 Mar 2023 15:09:39 -0700 Shailend Chand wrote:
> + /* If the skb is gso, then we want the tcp header alone in the first segment
> + * otherwise we want the spec-stipulated minimum of 182B.
> */
> hlen = is_gso ? l4_hdr_offset + tcp_hdrlen(skb) :
> - skb_headlen(skb);
> + min_t(int, 182, skb->len);
What spec are we talking about here?
Please add a define for the magic number.
prev parent reply other threads:[~2023-04-01 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 22:09 [PATCH net] gve: Secure enough bytes in the first TX desc for all TCP pkts Shailend Chand
2023-04-01 4:29 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331212924.49bc1c64@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shailend@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.