All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/net/ethernet/ti/cpsw_priv.c:1492 cpsw_qos_configure_clsflower() warn: ignoring unreachable code.
Date: Sat, 1 Apr 2023 16:30:35 +0800	[thread overview]
Message-ID: <202304011615.Bia0Ruhc-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Grygorii Strashko <grygorii.strashko@ti.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7b50567bdcad8925ca1e075feb7171c12015afd1
commit: 127c9e970f59edaaaa7a7134e55752314c9691da net: ethernet: ti: cpsw_new: enable bc/mc storm prevention support
date:   12 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 12 months ago
config: arm64-randconfig-m041-20230329 (https://download.01.org/0day-ci/archive/20230401/202304011615.Bia0Ruhc-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304011615.Bia0Ruhc-lkp@intel.com/

smatch warnings:
drivers/net/ethernet/ti/cpsw_priv.c:1492 cpsw_qos_configure_clsflower() warn: ignoring unreachable code.

vim +1492 drivers/net/ethernet/ti/cpsw_priv.c

127c9e970f59ed Grygorii Strashko 2022-04-12  1484  
127c9e970f59ed Grygorii Strashko 2022-04-12  1485  static int cpsw_qos_configure_clsflower(struct cpsw_priv *priv, struct flow_cls_offload *cls)
127c9e970f59ed Grygorii Strashko 2022-04-12  1486  {
127c9e970f59ed Grygorii Strashko 2022-04-12  1487  	struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
127c9e970f59ed Grygorii Strashko 2022-04-12  1488  	struct netlink_ext_ack *extack = cls->common.extack;
127c9e970f59ed Grygorii Strashko 2022-04-12  1489  	const struct flow_action_entry *act;
127c9e970f59ed Grygorii Strashko 2022-04-12  1490  	int i, ret;
127c9e970f59ed Grygorii Strashko 2022-04-12  1491  
127c9e970f59ed Grygorii Strashko 2022-04-12 @1492  	flow_action_for_each(i, act, &rule->action) {
127c9e970f59ed Grygorii Strashko 2022-04-12  1493  		switch (act->id) {
127c9e970f59ed Grygorii Strashko 2022-04-12  1494  		case FLOW_ACTION_POLICE:
127c9e970f59ed Grygorii Strashko 2022-04-12  1495  			ret = cpsw_qos_clsflower_policer_validate(&rule->action, act, extack);
127c9e970f59ed Grygorii Strashko 2022-04-12  1496  			if (ret)
127c9e970f59ed Grygorii Strashko 2022-04-12  1497  				return ret;
127c9e970f59ed Grygorii Strashko 2022-04-12  1498  
127c9e970f59ed Grygorii Strashko 2022-04-12  1499  			return cpsw_qos_clsflower_add_policer(priv, extack, cls,
127c9e970f59ed Grygorii Strashko 2022-04-12  1500  							      act->police.rate_pkt_ps);
127c9e970f59ed Grygorii Strashko 2022-04-12  1501  		default:
127c9e970f59ed Grygorii Strashko 2022-04-12  1502  			NL_SET_ERR_MSG_MOD(extack, "Action not supported");
127c9e970f59ed Grygorii Strashko 2022-04-12  1503  			return -EOPNOTSUPP;
127c9e970f59ed Grygorii Strashko 2022-04-12  1504  		}
127c9e970f59ed Grygorii Strashko 2022-04-12  1505  	}
127c9e970f59ed Grygorii Strashko 2022-04-12  1506  	return -EOPNOTSUPP;
127c9e970f59ed Grygorii Strashko 2022-04-12  1507  }
127c9e970f59ed Grygorii Strashko 2022-04-12  1508  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

             reply	other threads:[~2023-04-01  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  8:30 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-05  1:39 drivers/net/ethernet/ti/cpsw_priv.c:1492 cpsw_qos_configure_clsflower() warn: ignoring unreachable code kernel test robot
2022-12-08  7:10 kernel test robot
2022-09-19 13:46 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202304011615.Bia0Ruhc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.