From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 403E4C76196 for ; Sat, 1 Apr 2023 17:27:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D85FC41841; Sat, 1 Apr 2023 17:27:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D85FC41841 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1680370063; bh=78I30zeautq3lr0I8kldRmW+PB0+eua0mpWpNFCs+/U=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=h4iISGpN4XqS9UF+R6BM6EUTD7JWeZDCz3rg1ryrJOozkf857SkFq03lLakVpSr9E +bfkHUqsofpJGXida6rvqEhy6HH+M+gQEZWv7o2dvqdYSfp8Mw6kHeqisFp6fDk76u dF4G+zcsics/kpV2QZfgwHKuj2wh8avVu8nE5wqMzci9WrJdVIv4ZuicNgo8nQNbka sfRP3DWzhb8aRA0FwX10OucQDDZOA6qxxRuUqWCBvmJt1BQLMEBRWXqxIUyA2hn1vq nmI9x22Pa4C6bC0SNe4v11f+tB2yYQblHELGLx0mjxzKcVVqw5HvW9WFLSfE0iqtpU XqUzP72H3GYXw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5sa29HjR4ksH; Sat, 1 Apr 2023 17:27:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9C57641844; Sat, 1 Apr 2023 17:27:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9C57641844 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1D7451BF318 for ; Sat, 1 Apr 2023 17:27:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id EA56540136 for ; Sat, 1 Apr 2023 17:27:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EA56540136 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6qgmXKhbsk-o for ; Sat, 1 Apr 2023 17:27:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org BF495400C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id BF495400C6 for ; Sat, 1 Apr 2023 17:27:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-CYuGsK1dOFOTVqNxOGJJoQ-1; Sat, 01 Apr 2023 13:27:32 -0400 X-MC-Unique: CYuGsK1dOFOTVqNxOGJJoQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AEC94101A531; Sat, 1 Apr 2023 17:27:31 +0000 (UTC) Received: from toolbox.redhat.com (ovpn-192-6.brq.redhat.com [10.40.192.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA53F40C20FA; Sat, 1 Apr 2023 17:27:29 +0000 (UTC) From: Michal Schmidt To: intel-wired-lan@lists.osuosl.org Date: Sat, 1 Apr 2023 19:26:59 +0200 Message-Id: <20230401172659.38508-5-mschmidt@redhat.com> In-Reply-To: <20230401172659.38508-1-mschmidt@redhat.com> References: <20230401172659.38508-1-mschmidt@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680370055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SNKv27E0TSrQzuBdoriRm3TI5q4rweM0mIElGLkLGAQ=; b=dUZqDysz+Ysg7PECphbbbGYWYwALZFvCl1AnadV8b2XJaGIw2R8oLByzJUB6Fr7fqX5z9+ wCmdW7Zw/N+Qz3QYJfofwVmwbjARKjIL/VvcTEleoUENEA5R+RxWyVRi09N7warUg7L8YE JlzchrwWqVLWxcIlJjWLvFDvtro7Ay4= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dUZqDysz Subject: [Intel-wired-lan] [PATCH net-next 4/4] ice: sleep, don't busy-wait, in the SQ send retry loop X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , Karol Kolacinski , Tony Nguyen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" 10 ms is a lot of time to spend busy-waiting. Sleeping is clearly allowed here, because we have just returned from ice_sq_send_cmd(), which takes a mutex. On kernels with HZ=100, this msleep may be twice as long, but I don't think it matters. I did not actually observe any retries happening here. Signed-off-by: Michal Schmidt --- drivers/net/ethernet/intel/ice/ice_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index 539b756f227c..438367322bcd 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -1643,7 +1643,7 @@ ice_sq_send_cmd_retry(struct ice_hw *hw, struct ice_ctl_q_info *cq, memcpy(desc, &desc_cpy, sizeof(desc_cpy)); - mdelay(ICE_SQ_SEND_DELAY_TIME_MS); + msleep(ICE_SQ_SEND_DELAY_TIME_MS); } while (++idx < ICE_SQ_SEND_MAX_EXECUTE); -- 2.39.2 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan