From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Max Georgiev <glipus@gmail.com>,
kory.maincent@bootlin.com, netdev@vger.kernel.org,
maxime.chevallier@bootlin.com
Subject: Re: [PATCH net-next RFC] Add NDOs for hardware timestamp get/set
Date: Sat, 1 Apr 2023 22:30:48 +0300 [thread overview]
Message-ID: <20230401193048.f4j3h6mbe7ti2zo6@skbuf> (raw)
In-Reply-To: <20230401122450.0fd88313@kernel.org>
On Sat, Apr 01, 2023 at 12:24:50PM -0700, Jakub Kicinski wrote:
> On Sat, 1 Apr 2023 22:12:15 +0300 Vladimir Oltean wrote:
> > My understanding of Jakub's objection is that the scope of the
> > NETDEV_ETH_IOCTL is too wide, and as such, it would need to change to
> > something like NETDEV_HWTSTAMP_SET. I can make that change if that is
> > the only objection, and resubmit that as preparation work for the
> > ndo_hwtstamp_set() effort.
>
> My objection to the IOCTL is that there's a lot of boilerplate that
> the drivers have to copy and that it makes it harder to do meaningful
> work in the core.
By "NETDEV_ETH_IOCTL" I mean a netdev notifier with this name, and so,
I was expecting objections to that...
I can change that notifier proposal to be scoped only to the hwtstamping
operation, and that notifier would be 100% orthogonal to which API is
used to get/set hwtstamping, ndo_eth_ioctl() or ndo_hwtstamp_set().
next prev parent reply other threads:[~2023-04-01 19:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 4:56 [PATCH net-next RFC] Add NDOs for hardware timestamp get/set Maxim Georgiev
2023-03-31 5:35 ` Jakub Kicinski
2023-03-31 17:51 ` Max Georgiev
2023-03-31 18:10 ` Jakub Kicinski
2023-04-01 18:16 ` Vladimir Oltean
2023-04-01 19:12 ` Vladimir Oltean
2023-04-01 19:24 ` Jakub Kicinski
2023-04-01 19:30 ` Vladimir Oltean [this message]
2023-04-01 20:18 ` Vladimir Oltean
2023-04-02 14:28 ` Max Georgiev
2023-04-02 16:56 ` Vladimir Oltean
2023-04-01 16:08 ` Vladimir Oltean
2023-04-01 17:55 ` Jakub Kicinski
2023-04-01 18:20 ` Vladimir Oltean
2023-04-01 18:22 ` Vladimir Oltean
2023-04-01 19:14 ` Jakub Kicinski
2023-04-01 19:19 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230401193048.f4j3h6mbe7ti2zo6@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=glipus@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.