All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: meta-virtualization@lists.yoctoproject.org
Cc: Martin Jansa <Martin.Jansa@gmail.com>
Subject: [meta-virtualization][PATCH] crun: fix REQUIRED_DISTRO_FEATURES
Date: Sun,  2 Apr 2023 00:10:27 +0200	[thread overview]
Message-ID: <20230401221027.2776494-1-Martin.Jansa@gmail.com> (raw)

* features_check was inherit twice and REQUIRED_DISTRO_FEATURES
  was set twice as well but both with ?= so the 2nd one was ignored

* seccomp was added in:
  commit b8f2edd39af6b7ac4461158b0d0382e88e93d6f1
  Author: Bruce Ashfield <bruce.ashfield@gmail.com>
  Date:   Wed Jun 30 11:22:42 2021 -0400
  Subject: crun: add seccomp distro features check

  but there was already systemd from:

  commit 144d1ae8973e8c67709d7b544dc53b80bf924754
  Author: Bruce Ashfield <bruce.ashfield@gmail.com>
  Date:   Fri Apr 23 10:32:24 2021 -0400
  Subject: crun: use REQUIRED_DISTRO_FEATURES to indicate systemd dependency

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-containers/crun/crun_git.bb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/recipes-containers/crun/crun_git.bb b/recipes-containers/crun/crun_git.bb
index 7db609e..15c18a1 100644
--- a/recipes-containers/crun/crun_git.bb
+++ b/recipes-containers/crun/crun_git.bb
@@ -20,14 +20,12 @@ SRC_URI = "git://github.com/containers/crun.git;branch=main;name=crun;protocol=h
 PV = "1.8.1+git${SRCREV_crun}"
 S = "${WORKDIR}/git"
 
-REQUIRED_DISTRO_FEATURES ?= "systemd"
+REQUIRED_DISTRO_FEATURES ?= "systemd seccomp"
 
 inherit autotools-brokensep pkgconfig features_check
 
 PACKAGECONFIG ??= ""
 
-inherit features_check
-REQUIRED_DISTRO_FEATURES ?= "seccomp"
 
 DEPENDS = "yajl libcap go-md2man-native m4-native"
 # TODO: is there a packageconfig to turn this off ?
-- 
2.40.0



             reply	other threads:[~2023-04-01 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01 22:10 Martin Jansa [this message]
2023-04-12 17:07 ` [meta-virtualization][PATCH] crun: fix REQUIRED_DISTRO_FEATURES Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230401221027.2776494-1-Martin.Jansa@gmail.com \
    --to=martin.jansa@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.