From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19317C76196 for ; Mon, 3 Apr 2023 06:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229454AbjDCG20 (ORCPT ); Mon, 3 Apr 2023 02:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbjDCG2Y (ORCPT ); Mon, 3 Apr 2023 02:28:24 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21713106 for ; Sun, 2 Apr 2023 23:28:23 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4E85F6601F13; Mon, 3 Apr 2023 07:28:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680503301; bh=3cCU26BeElxI1SYG7ZzjCqv3azvdrsk7odwOKt1GgKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f1bNOiDRafxwJwMOjlKyKSgFzn6LTOq8DL5Psqb03SUE/9wn1O9UJOM7riWvUbDJh dgYT0RBky4HhU0VoCoqw5Y+KM12zR6E9VsA8/bSnKQE2HHGjtRHtRRrzKJwznElVr9 Jh4JHC0a1uWpthXmZ+pgUbfEbfSboeZcIHbf9/y8mSxmymIIPBU4FAwwfRUoWc6DF+ UTNXd5MvIOKPnXBKG0GjLnKtJTCan8DoGdURaMDYMlBGOv8qxCfZTYMaIvV+DQBY8d R8qsfBR02ZhUu14N8v5tdl31VHwVhJpB1o3FddG5R8GuqaxXoYaSrwAu9BiexQdP3+ WruiQUBjJ8S9Q== Date: Mon, 3 Apr 2023 08:28:18 +0200 From: Boris Brezillon To: Steven Price Cc: Rob Herring , Alyssa Rosenzweig , Robin Murphy , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, david.heidelberg@collabora.com Subject: Re: [PATCH] drm/panfrost: Fix the panfrost_mmu_map_fault_addr() error path Message-ID: <20230403082707.11ec0a07@collabora.com> In-Reply-To: <6749e0dd-bc07-b399-9718-0972993034cd@arm.com> References: <20210521093811.1018992-1-boris.brezillon@collabora.com> <6749e0dd-bc07-b399-9718-0972993034cd@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org +David On Fri, 21 May 2021 11:42:04 +0100 Steven Price wrote: > On 21/05/2021 10:38, Boris Brezillon wrote: > > Make sure all bo->base.pages entries are either NULL or pointing to a > > valid page before calling drm_gem_shmem_put_pages(). > > > > Reported-by: Tomeu Vizoso > > Cc: > > Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") > > Signed-off-by: Boris Brezillon > > Reviewed-by: Steven Price Queued to drm-misc-fixes. > > > --- > > drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > > index 569509c2ba27..d76dff201ea6 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > > @@ -460,6 +460,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, > > if (IS_ERR(pages[i])) { > > mutex_unlock(&bo->base.pages_lock); > > ret = PTR_ERR(pages[i]); > > + pages[i] = NULL; > > goto err_pages; > > } > > } > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58475C761A6 for ; Mon, 3 Apr 2023 06:28:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 562EC10E134; Mon, 3 Apr 2023 06:28:26 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F61710E134 for ; Mon, 3 Apr 2023 06:28:24 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4E85F6601F13; Mon, 3 Apr 2023 07:28:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680503301; bh=3cCU26BeElxI1SYG7ZzjCqv3azvdrsk7odwOKt1GgKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f1bNOiDRafxwJwMOjlKyKSgFzn6LTOq8DL5Psqb03SUE/9wn1O9UJOM7riWvUbDJh dgYT0RBky4HhU0VoCoqw5Y+KM12zR6E9VsA8/bSnKQE2HHGjtRHtRRrzKJwznElVr9 Jh4JHC0a1uWpthXmZ+pgUbfEbfSboeZcIHbf9/y8mSxmymIIPBU4FAwwfRUoWc6DF+ UTNXd5MvIOKPnXBKG0GjLnKtJTCan8DoGdURaMDYMlBGOv8qxCfZTYMaIvV+DQBY8d R8qsfBR02ZhUu14N8v5tdl31VHwVhJpB1o3FddG5R8GuqaxXoYaSrwAu9BiexQdP3+ WruiQUBjJ8S9Q== Date: Mon, 3 Apr 2023 08:28:18 +0200 From: Boris Brezillon To: Steven Price Subject: Re: [PATCH] drm/panfrost: Fix the panfrost_mmu_map_fault_addr() error path Message-ID: <20230403082707.11ec0a07@collabora.com> In-Reply-To: <6749e0dd-bc07-b399-9718-0972993034cd@arm.com> References: <20210521093811.1018992-1-boris.brezillon@collabora.com> <6749e0dd-bc07-b399-9718-0972993034cd@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, stable@vger.kernel.org, david.heidelberg@collabora.com, Rob Herring , Alyssa Rosenzweig , Robin Murphy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" +David On Fri, 21 May 2021 11:42:04 +0100 Steven Price wrote: > On 21/05/2021 10:38, Boris Brezillon wrote: > > Make sure all bo->base.pages entries are either NULL or pointing to a > > valid page before calling drm_gem_shmem_put_pages(). > > > > Reported-by: Tomeu Vizoso > > Cc: > > Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") > > Signed-off-by: Boris Brezillon > > Reviewed-by: Steven Price Queued to drm-misc-fixes. > > > --- > > drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > > index 569509c2ba27..d76dff201ea6 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > > @@ -460,6 +460,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, > > if (IS_ERR(pages[i])) { > > mutex_unlock(&bo->base.pages_lock); > > ret = PTR_ERR(pages[i]); > > + pages[i] = NULL; > > goto err_pages; > > } > > } > > >