From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Maxim Georgiev" <glipus@gmail.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next 7/7] net: create a netdev notifier for DSA to reject PTP on DSA master
Date: Mon, 3 Apr 2023 08:30:19 -0700 [thread overview]
Message-ID: <20230403083019.120b72fd@kernel.org> (raw)
In-Reply-To: <20230402123755.2592507-8-vladimir.oltean@nxp.com>
On Sun, 2 Apr 2023 15:37:55 +0300 Vladimir Oltean wrote:
> The established way for unrelated modules to react on a net device event
> is via netdevice notifiers. So we create a new notifier which gets
> called whenever there is an attempt to change hardware timestamping
> settings on a device.
Two core parts of the kernel are not "unrelated modules".
Notifiers make the code harder to maintain and reason about.
But what do I know, clearly the code is amazing since it
has been applied in <22h on a weekend :|
next prev parent reply other threads:[~2023-04-03 15:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 12:37 [PATCH net-next 0/7] Convert dsa_master_ioctl() to netdev notifier Vladimir Oltean
2023-04-02 12:37 ` [PATCH net-next 1/7] net: don't abuse "default" case for unknown ioctl in dev_ifsioc() Vladimir Oltean
2023-04-02 12:46 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 2/7] net: simplify handling of dsa_ndo_eth_ioctl() return code Vladimir Oltean
2023-04-02 12:47 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 3/7] net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls to dedicated handlers Vladimir Oltean
2023-04-02 12:52 ` Florian Fainelli
2023-04-02 12:53 ` Vladimir Oltean
2023-04-02 12:56 ` Florian Fainelli
2023-04-02 13:01 ` Vladimir Oltean
2023-04-02 13:03 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 4/7] net: move copy_from_user() out of net_hwtstamp_validate() Vladimir Oltean
2023-04-02 12:52 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 5/7] net: add struct kernel_hwtstamp_config and make net_hwtstamp_validate() use it Vladimir Oltean
2023-04-02 12:57 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 6/7] net: dsa: make dsa_port_supports_hwtstamp() construct a fake ifreq Vladimir Oltean
2023-04-02 12:57 ` Florian Fainelli
2023-04-02 12:37 ` [PATCH net-next 7/7] net: create a netdev notifier for DSA to reject PTP on DSA master Vladimir Oltean
2023-04-02 13:01 ` Florian Fainelli
2023-04-03 15:30 ` Jakub Kicinski [this message]
2023-04-03 16:48 ` Vladimir Oltean
2023-04-03 9:20 ` [PATCH net-next 0/7] Convert dsa_master_ioctl() to netdev notifier patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403083019.120b72fd@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=glipus@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kory.maincent@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.