From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Andrew Davis <afd@ti.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: omap: Convert omap.txt to yaml
Date: Mon, 3 Apr 2023 12:18:13 +0200 [thread overview]
Message-ID: <20230403121813.55c8aa2a@aktux> (raw)
In-Reply-To: <3865a750-2cd1-c92f-8bd2-22dfeea43769@kernel.org>
Hi,
On Sun, 2 Apr 2023 13:26:46 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 01/04/2023 16:02, Andreas Kemnade wrote:
> > From: Andrew Davis <afd@ti.com>
> >
> > Convert omap.txt to yaml.
> >
> > Signed-off-by: Andrew Davis <afd@ti.com>
> > [various cleanup, adding Epson Moverio BT-200]
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Your CC list is broken in few ways. Just use the script, don't re-invent
> the addresses.
>
well, I am using the script and added a few adresses obviously missing.
But maybe I have used the script from an older kernel. The patch was against
linux-next.
[...]
> > + - description: TI DRA7 SoC based platforms
> > + items:
> > + - enum:
> > + - ti,dra718-evm
>
> This is not correct. Maybe you forgot to fix DTS, but anyway it's
> confusing to have dra718-evm with dra768 SoC. Is this really proper
> combination?
>
dra718-evm has a lot of compatibles, no idea if that is sane.
And to better discuss such things I added the omap mailinglist (with a typo,
sorry). To avoid that trouble in the future, I added a patch to MAINTAINERS.
But I think it is better to not convert dra7 stuff for now, then
it can be discussed by the right people.
Regards,
Andreas
next prev parent reply other threads:[~2023-04-03 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 14:02 [PATCH v3 0/2] dt-bindings: omap: Convert omap.txt to yaml Andreas Kemnade
2023-04-01 14:02 ` [PATCH v3 1/2] " Andreas Kemnade
2023-04-02 11:26 ` Krzysztof Kozlowski
2023-04-03 10:18 ` Andreas Kemnade [this message]
2023-04-03 10:35 ` Krzysztof Kozlowski
2023-04-01 14:02 ` [PATCH v3 2/2] MAINTAINERS: add board bindings list to OMAP2+ files Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403121813.55c8aa2a@aktux \
--to=andreas@kemnade.info \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.