From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16534C76196 for ; Mon, 3 Apr 2023 14:17:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 702DF85845; Mon, 3 Apr 2023 16:17:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="E0IOuq+2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B66385CA7; Mon, 3 Apr 2023 16:17:49 +0200 (CEST) Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3DCC48575B for ; Mon, 3 Apr 2023 16:17:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb29.google.com with SMTP id p204so34918886ybc.12 for ; Mon, 03 Apr 2023 07:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680531464; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B/0Vu4IxRYip6xZRMGL6ApVlaX/TlZz9FLBMXtd8Yjc=; b=E0IOuq+2MjG4Ur/ZnP70Qj4CSbVQmwnZDih4IV/f4H476lIJHYmD0hDbvDWWe47z/k +G1as/hvLBfBtsllPv8Gxhds6TpBr/p4/CRpxYDXKQCiv7ju53vRhCMNyHTxck2fp4+m YHtW2bZwg/ec5IYC+jPIM8BbvQX7Rl13gBjCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680531464; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B/0Vu4IxRYip6xZRMGL6ApVlaX/TlZz9FLBMXtd8Yjc=; b=MHu9x7fE73r7Mqg46GgGGm3lYmcrJtXKLEl/kVR0/2UFVvFdL+rnXHoSEF7a2UgmH0 QoitMy4VwE2nAh91qmWLfY6RO7tfUx9erSDYqsl7yoN80SZbRMrTHxn4rdpvBMUwkoXg C/9eQTLNslnFfQ0dclsoNXWggu+9jvpX94Zx0VtCsFdPHf8lpOtmUvMulcmfhDgyIyCY P7VZYNX72XLgLAMwOTeyqrVQDZFWT6tARDIt8pCnoK9c6kbW1YhoR3y7J+TBbBwxKYi2 VAdqR77PeH6al0M/PObIsBg0wVqSyhMUmsfXUKxFxCCl78zItSTVwMXbaB3rS3L9a14h HlOA== X-Gm-Message-State: AAQBX9cPBOOBZan4AC9KxaipI07RhKBfY+MLGExKDf6FRsW/EePVKUYW cwoY+ZJ+lABfvkm/D0+t1uJgtA== X-Google-Smtp-Source: AKy350Zr4jABKsuLM6guin7+9/cZL4NhaXLH3YwskyKDvxWHKFZ+7EGDdxBsDrJa9ozIch2rmowdGw== X-Received: by 2002:a25:ae06:0:b0:8cc:c967:dd40 with SMTP id a6-20020a25ae06000000b008ccc967dd40mr34482327ybj.38.1680531464753; Mon, 03 Apr 2023 07:17:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-d003-8cc0-db8c-6109.res6.spectrum.com. [2603:6081:7b00:6400:d003:8cc0:db8c:6109]) by smtp.gmail.com with ESMTPSA id 127-20020a251285000000b00b7767ca7486sm2580596ybs.35.2023.04.03.07.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 07:17:44 -0700 (PDT) Date: Mon, 3 Apr 2023 10:17:42 -0400 From: Tom Rini To: Ilias Apalodimas Cc: Simon Glass , Heinrich Schuchardt , U-Boot Mailing List , Vagrant Cascadian , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich Subject: Re: [PATCH v5 3/8] bootstd: Support booting EFI where multiple options exist Message-ID: <20230403141742.GF19998@bill-the-cat> References: <20230331102559.v5.1.Id5a4b4ee7b653591dfb25e75204c17215521164b@changeid> <20230331102559.v5.3.Ifa423a8f295b3c11e50821222b0db1e869d0c051@changeid> <20230331180222.GB13222@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3tX+wLIKYU90aO8Q" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --3tX+wLIKYU90aO8Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 12:56:49PM +0300, Ilias Apalodimas wrote: > On Sat, Apr 01, 2023 at 07:31:49PM +1300, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 1 Apr 2023 at 07:02, Tom Rini wrote: > > > > > > On Fri, Mar 31, 2023 at 10:25:56AM +1300, Simon Glass wrote: > > > > > > > The current EFI implementation has a strange quirk where it watches > > > > loaded files and uses the last-loaded file to determine the device = that > > > > is being booted from. > > > > > > > > This is confusing with bootstd, where multiple options may exist. E= ven > > > > loading a device tree will cause it to go wrong. There is no API for > > > > passing this information, since the only entry into booting an EFI = image > > > > is the 'bootefi' command. > > > > > > > > To work around this, call efi_set_bootdev() for EFI images, if poss= ible, > > > > just before booting. > > > > > > > > Signed-off-by: Simon Glass > > > > > > Shouldn't this all be a simple wrapper around the EFI Standard > > > BootDeviceOrder or whatever that's called? > > > > I think you are referring to boot manager, which isn't used here. This > > is replicating the existing distroboot functionality in standard boot. >=20 > The distroboot functionality *was* trying to behave like the EFI spec > expects the bootmanager to behave. Unfortunately I haven't had time to > review the distroboot patches closely, but back when this started, my poi= nt > was that EFI doesn't need anything. Whenever the EFI flow is added boots= td > should 'just' call the bootmanager. Yes, this. We're trying make things cleaner overall, so the EFI portion of bootstd distro boot should just be "call EFI bootmanager" as that has a well defined standard way to specify what devices to try in what order. --=20 Tom --3tX+wLIKYU90aO8Q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQq3/8ACgkQFHw5/5Y0 tyxcAgv/TGp50qXMoCF51zNy990smEMc4sB4u1qbIzHHnQts3dBS+yrqmLokvULZ MkdpW9nh6hx9OeCX8G36gw3X6FTAG392PnSYdV6mYuqtddrAnZ6/p/dqjAkBXSHy 17PPJAuB/THm9RIekXv/XyRS/YQC7w/s+gVAQXBDkg104hHPLUSLJvb3Qfpb+e/c i62ej0JRh3VpJhI8sLbUHGVJFfA2INIQ0R+hufLPl78AykV6f8eevho4b9nftHDq y7aoXIpatW/sQJjXMSpUhGYxXopyDELiyRFSse7pFOxSslb3YKItZzhp0PXRd7Og dMR49gxAc8MfHP53JIMrvXEZSGPl7Vqqt4p80SiARQRFYqZ1uLOlGKSK3AU92fnO +UaZyGfplT+Tc6kZZ7i3RHiwPVXgfZwFBQqhktFYoIT77MSFeHz+MRlTgOgAAqlK 1JoXzdtPH5hxnW9MeVGQHpJ6jfHDeGZh7T1kYNc2oLfHFcTN5g2DRHJEPAHQOcSa 009v0iqg =DYaG -----END PGP SIGNATURE----- --3tX+wLIKYU90aO8Q--