Re: [PATCH v5 8/8] bootstd: Enable BOOTSTD_DEFAULTS by default

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

On Sat, Apr 01, 2023 at 07:31:56PM +1300, Simon Glass wrote:
> Hi Tom,
> 
> On Sat, 1 Apr 2023 at 07:00, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Fri, Mar 31, 2023 at 10:26:01AM +1300, Simon Glass wrote:
> >
> > > This is needed to enable the boot command used to start standard boot.
> > > Enable it by default. This brings in quite a few features, mostly in
> > > common with DISTRO_DEFAULTS
> > >
> > > Exclude boards which have what looks like a custom boot command:
> > >
> > >    git grep CONFIG_BOOTCOM configs/* |grep -v distro_bootcmd  |
> > >        sed -n 's/configs\/\(.*\)_defconfig.*/\1/p'
> > >
> > > Disable this option for boards which don't have enough space.
> > >
> > > Disable CONFIG_ENV_VARS_UBOOT_CONFIG for some Xilinx boards which have
> > > a very small environment. Disable BOOTSTD_DEFAULTS for smartweb since
> > > it is too close to its limit.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > I wasn't clear, sorry. What I want to see first is a standalone patch
> > that disables BOOTSTD on platforms that have their own custom bootcmd,
> > that is not just a more complex wrapper around distro_bootcmd (those
> > platforms will require more work to convert, but won't be impacted by
> > BOOTSTD_DEFAULTS being default). It needs to be on its own so it can be
> > reviewed.  Thanks.
> 
> Oh OK, I was wondering how it could be standard if it was just

"standard" as in default/regular, not "standard" as in rigidly defined
by external specification.

> disabling BOOTSTD_DEFAULTS... I will give it a crack. I wonder if this
> is the same set which doesn't enable DISTRO_DEFAULTS?

The ones which do things around "run distro_bootcmd" ? No, probably not.
But the ones which have unexplained large size growth? Likely yes.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]