From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92DDCC76188 for ; Mon, 3 Apr 2023 14:46:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C90CA85C98; Mon, 3 Apr 2023 16:46:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hIbakTjx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C7AD685CA7; Mon, 3 Apr 2023 16:46:22 +0200 (CEST) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DDAB85C5A for ; Mon, 3 Apr 2023 16:46:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb34.google.com with SMTP id n125so35021498ybg.7 for ; Mon, 03 Apr 2023 07:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680533178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EwOmz7CaX575Tj3vn6YxCEes0dBMC5goMWKp1bToTnw=; b=hIbakTjxuAww2eeXP5Cd49rHDUOEYhGIOXAtcLXgO8hBZNytPzhlvow3C1WkKcEYD3 PZe71YaNbbmR5eQpxjkTR8d0hI3Y3evOpRMambQYkbbyJnwX0HbYdMU7iOuZ/UBQZPoD 4909ne/8npGh3gspqZYwypw1EwTBvwIvqkJd0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680533178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EwOmz7CaX575Tj3vn6YxCEes0dBMC5goMWKp1bToTnw=; b=CPTlzDVYIluArkoYTPqSJ23QE5ADSZzX3fMNYf79P5bEWuAsn320CNPZCXSSBH5hd4 VqpJf0GBwWLYvCxiVl2UYMOopP0hwiiX4SXqdqyRNf+r27nJh2SIvDC2JlzVxmUUD57c 7fw2j9gv5ykTORXzpUyt+2b8e8LGfClxMJPnyZarhTgKcmbgDotqUanXfD3rSIuyXDz9 fIOzftMRojbnAE67YnaHMXugeM+fWQzk9KxO7fCOqgeJykNKF3ydh25s3kbxYh6XysNL W5USNMIt6BoDNuMlt7LDPZTLRZ0FOrSHCT7GbadTKQQagEtxhQKJR+6B0NdfYxpV4o0q IlAw== X-Gm-Message-State: AAQBX9cnquuVBzQz/3s2fWIXiqeaGLPHYRg1hTpXiBToXNKHg1F7Ls+I z+yaiME16hUWov2dDuCHqnNWBA== X-Google-Smtp-Source: AKy350a0LeXiZICb/m1LczfRDCBl7e36+opAxrKTc2M0o+a2qoDIOPpWQQicS37GSYM0E7XdssRn2g== X-Received: by 2002:a25:ea03:0:b0:b87:cd46:2baf with SMTP id p3-20020a25ea03000000b00b87cd462bafmr3469089ybd.52.1680533178324; Mon, 03 Apr 2023 07:46:18 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-d003-8cc0-db8c-6109.res6.spectrum.com. [2603:6081:7b00:6400:d003:8cc0:db8c:6109]) by smtp.gmail.com with ESMTPSA id o10-20020a25ea4a000000b00b7c9b3b735esm2593400ybe.4.2023.04.03.07.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 07:46:18 -0700 (PDT) Date: Mon, 3 Apr 2023 10:46:16 -0400 From: Tom Rini To: AKASHI Takahiro , Simon Glass , U-Boot Mailing List , Ilias Apalodimas , Heinrich Schuchardt Subject: Re: [PATCH v2] disk: Use a helper function to reduce duplication Message-ID: <20230403144616.GJ19998@bill-the-cat> References: <20230319192957.1084530-1-sjg@chromium.org> <20230331141703.GV13222@bill-the-cat> <20230403000613.GA37805@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rVoMxovl2BW8tJUY" Content-Disposition: inline In-Reply-To: <20230403000613.GA37805@laputa> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --rVoMxovl2BW8tJUY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 09:06:13AM +0900, AKASHI Takahiro wrote: > Hi Tom, >=20 > On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote: > > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote: > >=20 > > > Reduce the duplicated code slightly by using a helper function to han= dle > > > the common code. > > >=20 > > > This reduces the code size very slightly. > > >=20 > > > Signed-off-by: Simon Glass > >=20 > > Applied to u-boot/next, thanks! >=20 > I think I said nak against this patch. > https://lists.denx.de/pipermail/u-boot/2023-March/512677.html Ah I missed that, sorry, reverting. --=20 Tom --rVoMxovl2BW8tJUY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQq5q8ACgkQFHw5/5Y0 tyzFCQwAqj33HjQy13oHoRbk/wcoy5ZALC5t7ltAFZLutiw/DO/5vbTo31/yVJA9 bs3VnCg6PmWmxuvu/fw4xtSKB/mLOV36qfADkPi0ryZkFgEWoSy/+fdfLy5eHwlZ V+CPVmKpOBj5aK73k0s3BNr6mToXykjX2xEKFyjN6GjVjCYXv5gX9l4pW5W9BbCF dkaF/wZR2IEIXsVyO0S9tqBwqNfviZKc5A7OTZUkycYfcV4kvR7tdY6kYosJ7xrC HzeFcoush/mPeyDGyn6Ubri5O0Dsxx34lqz9zvZbk6vPlShCAOhNbGD//kl4Ky/X J1xwoRsdr95lGHAZyvRlK+bjZ5jV0ddBzcD4wQatjZ9s12xQ+kGh2H8VqiVjUmIc 1hJ/ss/HJ01t3LXGrEEPfqvNbzepBv5XFA+i8c8mJ48NrDFUXbCI6iqdSAsV5gWq ArQI8Brs80Jxvey4WbgGlantfezAhv3DRD/siy8+ap3cZ0UMcl5yIiD/0iPE49Xl /1juI63g =RrZt -----END PGP SIGNATURE----- --rVoMxovl2BW8tJUY--