All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Stefan Wahren <stefan.wahren@chargebyte.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-imx@nxp.com, soc@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, stefan.wahren@i2se.com
Subject: Re: [PATCH V4 2/6] dt-bindings: w1: Add DS2482/DS2484 I2C to 1-W bridges
Date: Mon, 3 Apr 2023 13:14:07 -0500	[thread overview]
Message-ID: <20230403181407.GA1242137-robh@kernel.org> (raw)
In-Reply-To: <20230331210840.4061-3-stefan.wahren@chargebyte.com>

On Fri, Mar 31, 2023 at 11:08:36PM +0200, Stefan Wahren wrote:
> Even this binding look trivial, the actual hardware supports more
> features (e.g. sleep mode control GPIO). So add this as a dedicated
> devicetree binding for the Maxim DS2482/DS2484 I2C to 1-W bridges,
> which can be extended later.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> ---
>  .../devicetree/bindings/w1/maxim,ds2482.yaml  | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> 
> diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> new file mode 100644
> index 000000000000..fd692a3a7400
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/w1/maxim,ds2482.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim One wire bus master controller
> +
> +maintainers:
> +  - Stefan Wahren <stefan.wahren@chargebyte.com>
> +
> +description: |
> +  I2C to 1-wire bridges
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ds2482-100.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/DS2482-800.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/DS2484.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,ds2482
> +      - maxim,ds2484
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

To allow children, all that's needed for 1-wire is:

additionalProperties:
  type: object

> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      onewire@18 {
> +        compatible = "maxim,ds2484";
> +        reg = <0x18>;
> +      };
> +    };
> -- 
> 2.17.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Stefan Wahren <stefan.wahren@chargebyte.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-imx@nxp.com, soc@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, stefan.wahren@i2se.com
Subject: Re: [PATCH V4 2/6] dt-bindings: w1: Add DS2482/DS2484 I2C to 1-W bridges
Date: Mon, 3 Apr 2023 13:14:07 -0500	[thread overview]
Message-ID: <20230403181407.GA1242137-robh@kernel.org> (raw)
In-Reply-To: <20230331210840.4061-3-stefan.wahren@chargebyte.com>

On Fri, Mar 31, 2023 at 11:08:36PM +0200, Stefan Wahren wrote:
> Even this binding look trivial, the actual hardware supports more
> features (e.g. sleep mode control GPIO). So add this as a dedicated
> devicetree binding for the Maxim DS2482/DS2484 I2C to 1-W bridges,
> which can be extended later.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
> ---
>  .../devicetree/bindings/w1/maxim,ds2482.yaml  | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> 
> diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> new file mode 100644
> index 000000000000..fd692a3a7400
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/w1/maxim,ds2482.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim One wire bus master controller
> +
> +maintainers:
> +  - Stefan Wahren <stefan.wahren@chargebyte.com>
> +
> +description: |
> +  I2C to 1-wire bridges
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/ds2482-100.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/DS2482-800.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/DS2484.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,ds2482
> +      - maxim,ds2484
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

To allow children, all that's needed for 1-wire is:

additionalProperties:
  type: object

> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      onewire@18 {
> +        compatible = "maxim,ds2484";
> +        reg = <0x18>;
> +      };
> +    };
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-04-03 18:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 21:08 [PATCH V4 0/6] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-31 21:08 ` Stefan Wahren
2023-03-31 21:08 ` [PATCH V4 1/6] dt-bindings: vendor-prefixes: add chargebyte Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren
2023-03-31 21:08 ` [PATCH V4 2/6] dt-bindings: w1: Add DS2482/DS2484 I2C to 1-W bridges Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren
2023-04-02 10:28   ` Krzysztof Kozlowski
2023-04-02 10:28     ` Krzysztof Kozlowski
2023-04-03 18:14   ` Rob Herring [this message]
2023-04-03 18:14     ` Rob Herring
2023-03-31 21:08 ` [PATCH V4 3/6] w1: ds2482: add i2c id for DS2484 Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren
2023-03-31 21:08 ` [PATCH V4 4/6] dt-bindings: ARM: fsl: Add chargebyte Tarragon Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren
2023-03-31 21:08 ` [PATCH V4 5/6] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren
2023-03-31 21:08 ` [PATCH V4 6/6] ARM: imx_v6_v7_defconfig: Enable Tarragon peripheral drivers Stefan Wahren
2023-03-31 21:08   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403181407.GA1242137-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=olof@lixom.net \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=stefan.wahren@chargebyte.com \
    --cc=stefan.wahren@i2se.com \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.