From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, willy@infradead.org,
viro@zeniv.linux.org.uk, senozhatsky@chromium.org,
minchan@kernel.org, mcgrof@kernel.org, martin@omnibond.com,
hubcap@omnibond.com, hch@lst.de, brauner@kernel.org,
axboe@kernel.dk, p.raghav@samsung.com
Subject: Re: + zram-always-chain-bio-to-the-parent-in-read_from_bdev_async.patch added to mm-unstable branch
Date: Tue, 4 Apr 2023 11:00:48 +0900 [thread overview]
Message-ID: <20230404020048.GG12892@google.com> (raw)
In-Reply-To: <20230403204245.2B976C433D2@smtp.kernel.org>
On (23/04/03 13:42), Andrew Morton wrote:
[..]
> zram_bvec_read() is called with the bio set to NULL only in
> writeback_store() function. When a writeback is triggered,
> zram_bvec_read() is called only if ZRAM_WB flag is not set. That will
> result only calling zram_read_from_zspool() in __zram_bvec_read().
>
> rw_page callback used to call read_from_bdev_async with a NULL parent bio
> but that has been removed since commit 3222d8c2a7f8 ("block: remove
> ->rw_page").
>
> We can now safely always call bio_chain() as read_from_bdev_async() will
> be called with a parent bio set. A WARN_ON_ONCE is added if this function
> is called with parent set to NULL.
>
> Link: https://lore.kernel.org/linux-mm/ZBHcl8Pz2ULb4RGD@infradead.org/ [1]
> Link: https://lore.kernel.org/linux-mm/20230322135013.197076-1-p.raghav@samsung.com/ [2]
> Link: https://lore.kernel.org/linux-mm/8adb0770-6124-e11f-2551-6582db27ed32@samsung.com/ [3]
> Link: https://lkml.kernel.org/r/20230403132221.94921-2-p.raghav@samsung.com
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Martin Brandenburg <martin@omnibond.com>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Mike Marshall <hubcap@omnibond.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2023-04-04 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:42 + zram-always-chain-bio-to-the-parent-in-read_from_bdev_async.patch added to mm-unstable branch Andrew Morton
2023-04-04 2:00 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404020048.GG12892@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.