From: Dexuan Cui <decui@microsoft.com>
To: bhelgaas@google.com, davem@davemloft.net, decui@microsoft.com,
edumazet@google.com, haiyangz@microsoft.com, jakeo@microsoft.com,
kuba@kernel.org, kw@linux.com, kys@microsoft.com,
leon@kernel.org, linux-pci@vger.kernel.org,
lpieralisi@kernel.org, mikelley@microsoft.com, pabeni@redhat.com,
robh@kernel.org, saeedm@nvidia.com, wei.liu@kernel.org,
longli@microsoft.com, boqun.feng@gmail.com,
ssengar@microsoft.com, helgaas@kernel.org
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v2 0/6] pci-hyper: Fix race condition bugs for fast device hotplug
Date: Mon, 3 Apr 2023 19:05:39 -0700 [thread overview]
Message-ID: <20230404020545.32359-1-decui@microsoft.com> (raw)
Before the guest finishes probing a device, the host may be already starting
to remove the device. Currently there are multiple race condition bugs in the
pci-hyperv driver, which can cause the guest to panic. The patchset fixes
the crashes.
The patchset also does some cleanup work: patch 3 removes the useless
hv_pcichild_state, and patch 4 reverts an old patch which is not really
useful (without patch 4, it would be hard to make patch 5 clean).
Patch 6 removes the use of a global mutex lock, and enables async-probing
to allow concurrent device probing for faster boot.
In v2, I dropped the "debug code" before the real patch body to avoid
confusion; I fixed some minor issues pointed out by Michael Kelely:
fixed "goto release_state_lock" in patch 5, and improved the commit log
of patch 6; I added Wei Hu's Acked-by to patch 4. I added the cc:stable
tag to all the 6 patches.
v2 is based on v6.3-rc5.
I have been testing the patchset with
https://lwn.net/ml/linux-kernel/20230316091540.494366-1-alexander.stein%40ew.tq-group.com/
for several days, and no panic/hang is observed (earlier the kernel
would panic/hang within 1 day in my long haul testing).
The patchset is also availsble in my github branch:
https://github.com/dcui/tdx/commits/decui/vpci/v6.3-rc5-v2
v1 can be found here:
https://lwn.net/ml/linux-kernel/20230328045122.25850-1-decui%40microsoft.com/
Please review. Thanks!
Dexuan Cui (6):
PCI: hv: Fix a race condition bug in hv_pci_query_relations()
PCI: hv: Fix a race condition in hv_irq_unmask() that can cause panic
PCI: hv: Remove the useless hv_pcichild_state from struct hv_pci_dev
Revert "PCI: hv: Fix a timing issue which causes kdump to fail
occasionally"
PCI: hv: Add a per-bus mutex state_lock
PCI: hv: Use async probing to reduce boot time
drivers/pci/controller/pci-hyperv.c | 145 +++++++++++++++++-----------
1 file changed, 86 insertions(+), 59 deletions(-)
--
2.25.1
next reply other threads:[~2023-04-04 2:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 2:05 Dexuan Cui [this message]
2023-04-04 2:05 ` [PATCH v2 1/6] PCI: hv: Fix a race condition bug in hv_pci_query_relations() Dexuan Cui
2023-04-07 16:03 ` Michael Kelley (LINUX)
2023-04-04 2:05 ` [PATCH v2 2/6] PCI: hv: Fix a race condition in hv_irq_unmask() that can cause panic Dexuan Cui
2023-04-07 16:05 ` Michael Kelley (LINUX)
2023-04-04 2:05 ` [PATCH v2 3/6] PCI: hv: Remove the useless hv_pcichild_state from struct hv_pci_dev Dexuan Cui
2023-04-07 16:05 ` Michael Kelley (LINUX)
2023-04-04 2:05 ` [PATCH v2 4/6] Revert "PCI: hv: Fix a timing issue which causes kdump to fail occasionally" Dexuan Cui
2023-04-07 16:33 ` Michael Kelley (LINUX)
2023-04-04 2:05 ` [PATCH v2 5/6] PCI: hv: Add a per-bus mutex state_lock Dexuan Cui
2023-04-07 16:10 ` Michael Kelley (LINUX)
2023-04-04 2:05 ` [PATCH v2 6/6] PCI: hv: Use async probing to reduce boot time Dexuan Cui
2023-04-07 16:11 ` Michael Kelley (LINUX)
2023-04-07 16:14 ` Michael Kelley (LINUX)
2023-04-08 0:23 ` Dexuan Cui
2023-04-11 17:31 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404020545.32359-1-decui@microsoft.com \
--to=decui@microsoft.com \
--cc=bhelgaas@google.com \
--cc=boqun.feng@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=jakeo@microsoft.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=lpieralisi@kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saeedm@nvidia.com \
--cc=ssengar@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.