From: kernel test robot <lkp@intel.com>
To: John Fastabend <john.fastabend@gmail.com>,
cong.wang@bytedance.com, jakub@cloudflare.com,
daniel@iogearbox.net, lmb@isovalent.com, edumazet@google.com
Cc: oe-kbuild-all@lists.linux.dev, john.fastabend@gmail.com,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
andrii@kernel.org, will@isovalent.com
Subject: Re: [PATCH bpf v3 01/12] bpf: sockmap, pass skb ownership through read_skb
Date: Tue, 4 Apr 2023 10:10:56 +0800 [thread overview]
Message-ID: <202304040949.mjn0pmKV-lkp@intel.com> (raw)
In-Reply-To: <20230403200138.937569-2-john.fastabend@gmail.com>
Hi John,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf/master]
url: https://github.com/intel-lab-lkp/linux/commits/John-Fastabend/bpf-sockmap-pass-skb-ownership-through-read_skb/20230404-040431
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
patch link: https://lore.kernel.org/r/20230403200138.937569-2-john.fastabend%40gmail.com
patch subject: [PATCH bpf v3 01/12] bpf: sockmap, pass skb ownership through read_skb
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230404/202304040949.mjn0pmKV-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/44ddc6a14f8903f3f97d347b5303f678a8e2c3ea
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review John-Fastabend/bpf-sockmap-pass-skb-ownership-through-read_skb/20230404-040431
git checkout 44ddc6a14f8903f3f97d347b5303f678a8e2c3ea
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/ipv4/ net/unix/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304040949.mjn0pmKV-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/ipv4/udp.c: In function 'udp_read_skb':
>> net/ipv4/udp.c:1816:18: warning: unused variable 'copied' [-Wunused-variable]
1816 | int err, copied;
| ^~~~~~
--
net/unix/af_unix.c: In function 'unix_read_skb':
>> net/unix/af_unix.c:2556:18: warning: unused variable 'copied' [-Wunused-variable]
2556 | int err, copied;
| ^~~~~~
vim +/copied +1816 net/ipv4/udp.c
2276f58ac5890e Paolo Abeni 2017-05-16 1812
965b57b469a589 Cong Wang 2022-06-15 1813 int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
d7f571188ecf25 Cong Wang 2021-03-30 1814 {
d7f571188ecf25 Cong Wang 2021-03-30 1815 struct sk_buff *skb;
31f1fbcb346c93 Peilin Ye 2022-09-22 @1816 int err, copied;
d7f571188ecf25 Cong Wang 2021-03-30 1817
31f1fbcb346c93 Peilin Ye 2022-09-22 1818 try_again:
ec095263a96572 Oliver Hartkopp 2022-04-11 1819 skb = skb_recv_udp(sk, MSG_DONTWAIT, &err);
d7f571188ecf25 Cong Wang 2021-03-30 1820 if (!skb)
d7f571188ecf25 Cong Wang 2021-03-30 1821 return err;
099f896f498a2b Cong Wang 2021-11-14 1822
099f896f498a2b Cong Wang 2021-11-14 1823 if (udp_lib_checksum_complete(skb)) {
31f1fbcb346c93 Peilin Ye 2022-09-22 1824 int is_udplite = IS_UDPLITE(sk);
31f1fbcb346c93 Peilin Ye 2022-09-22 1825 struct net *net = sock_net(sk);
31f1fbcb346c93 Peilin Ye 2022-09-22 1826
31f1fbcb346c93 Peilin Ye 2022-09-22 1827 __UDP_INC_STATS(net, UDP_MIB_CSUMERRORS, is_udplite);
31f1fbcb346c93 Peilin Ye 2022-09-22 1828 __UDP_INC_STATS(net, UDP_MIB_INERRORS, is_udplite);
099f896f498a2b Cong Wang 2021-11-14 1829 atomic_inc(&sk->sk_drops);
099f896f498a2b Cong Wang 2021-11-14 1830 kfree_skb(skb);
31f1fbcb346c93 Peilin Ye 2022-09-22 1831 goto try_again;
099f896f498a2b Cong Wang 2021-11-14 1832 }
099f896f498a2b Cong Wang 2021-11-14 1833
db39dfdc1c3bd9 Peilin Ye 2022-09-20 1834 WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));
44ddc6a14f8903 John Fastabend 2023-04-03 1835 return recv_actor(sk, skb);
d7f571188ecf25 Cong Wang 2021-03-30 1836 }
965b57b469a589 Cong Wang 2022-06-15 1837 EXPORT_SYMBOL(udp_read_skb);
d7f571188ecf25 Cong Wang 2021-03-30 1838
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-04-04 2:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:01 [PATCH bpf v3 00/12] bpf sockmap fixes John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 01/12] bpf: sockmap, pass skb ownership through read_skb John Fastabend
2023-04-04 2:10 ` kernel test robot [this message]
2023-04-03 20:01 ` [PATCH bpf v3 02/12] bpf: sockmap, convert schedule_work into delayed_work John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 03/12] bpf: sockmap, improved check for empty queue John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 04/12] bpf: sockmap, handle fin correctly John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 05/12] bpf: sockmap, TCP data stall on recv before accept John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 06/12] bpf: sockmap, wake up polling after data copy John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 07/12] bpf: sockmap incorrectly handling copied_seq John Fastabend
2023-04-04 3:02 ` kernel test robot
2023-04-04 3:12 ` kernel test robot
2023-04-03 20:01 ` [PATCH bpf v3 08/12] bpf: sockmap, pull socket helpers out of listen test for general use John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 09/12] bpf: sockmap, build helper to create connected socket pair John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 10/12] bpf: sockmap, test shutdown() correctly exits epoll and recv()=0 John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 11/12] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer John Fastabend
2023-04-03 20:01 ` [PATCH bpf v3 12/12] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304040949.mjn0pmKV-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=lmb@isovalent.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=will@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.