From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
a.zummo@towertech.it, jdelvare@suse.com, linux@roeck-us.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Date: Tue, 4 Apr 2023 11:56:05 +0200 [thread overview]
Message-ID: <202304040956056c59af98@mail.local> (raw)
In-Reply-To: <0fd972bd-c5e7-65cc-6992-09c4c3e88f95@linaro.org>
On 04/04/2023 10:14:33+0200, Krzysztof Kozlowski wrote:
> On 04/04/2023 09:44, Alexandre Belloni wrote:
> >>
> >>> charging will always
> >>> enable a diode, select a resistor and then have or not an extra diode.
> >>> Figure2 of the MAX31329 datasheet is great.
> >>
> >> So the diode is in the max313xx? Then why enabling it is a property of
> >> DT? Either this should be inferred from compatible or is even a policy,
> >> not a DT property. Just because device has a register for something, is
> >> not an argument that "something" should be in DT.
> >
> > Well, it depends on the battery that is installed on the board so it
> > makes sense to have it in DT.
>
> OK, that would be a good reason, but I wonder why? Why choosing diode or
> not depends on the battery? Wouldn't you always want to have the diode?
>
It limits the maximum current used to charge the battery or supercap to
not exceed what is allowed.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-04-04 9:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 15:43 [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Ibrahim Tilki
2023-04-03 15:43 ` [PATCH v5 1/2] " Ibrahim Tilki
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-23 22:52 ` Chris Packham
2023-04-23 23:27 ` Chris Packham
2023-04-03 15:43 ` [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs Ibrahim Tilki
2023-04-04 6:17 ` Krzysztof Kozlowski
2023-04-04 7:10 ` Alexandre Belloni
2023-04-04 7:21 ` Krzysztof Kozlowski
2023-04-04 7:44 ` Alexandre Belloni
2023-04-04 8:14 ` Krzysztof Kozlowski
2023-04-04 9:32 ` Tilki, Ibrahim
2023-04-04 9:56 ` Alexandre Belloni [this message]
2023-04-04 10:06 ` Krzysztof Kozlowski
2023-04-04 12:18 ` Alexandre Belloni
2023-04-04 9:26 ` Tilki, Ibrahim
2023-04-04 10:08 ` Krzysztof Kozlowski
2023-04-04 10:35 ` Tilki, Ibrahim
2023-04-04 12:26 ` Alexandre Belloni
2023-04-04 12:29 ` Alexandre Belloni
2023-04-04 13:02 ` Krzysztof Kozlowski
2023-04-04 14:50 ` Tilki, Ibrahim
2023-04-04 13:10 ` Krzysztof Kozlowski
2023-04-04 15:40 ` Tilki, Ibrahim
2023-04-05 6:16 ` Krzysztof Kozlowski
2024-01-26 2:22 ` [PATCH v5 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-01-26 7:51 ` Nuno Sá
2024-01-29 3:28 ` Chris Packham
2024-01-29 7:55 ` Nuno Sá
2024-02-02 0:28 ` Chris Packham
2024-02-02 6:56 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304040956056c59af98@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.